From: Dan Carpenter <dan.carpenter@oracle.com>
To: Himanshu Jha <himanshujha199640@gmail.com>
Cc: devel@driverdev.osuosl.org, lars@metafoo.de,
Michael.Hennerich@analog.com, linux-iio@vger.kernel.org,
gregkh@linuxfoundation.org, 21cnbao@gmail.com,
linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de,
jic23@kernel.org
Subject: Re: [PATCH 4/4] staging: iio: accel: Move adis16201 driver out of staging
Date: Mon, 12 Feb 2018 17:45:42 +0300 [thread overview]
Message-ID: <20180212144542.qievoq76rvjigwm4@mwanda> (raw)
In-Reply-To: <20180212144157.GC12142@himanshu-Vostro-3559>
On Mon, Feb 12, 2018 at 08:11:57PM +0530, Himanshu Jha wrote:
> On Mon, Feb 12, 2018 at 04:18:26PM +0300, Dan Carpenter wrote:
> > I think -M is prefered for these types of diffs? Not sure.
>
> I wrote about that in the cover letter if you missed. :)
>
Yeah. I seldom read cover letters.
> > > + ret = adis_init(st, indio_dev, spi, &adis16201_data);
> > > + if (ret)
> > > + return ret;
> > > +
> > > + ret = adis_setup_buffer_and_trigger(st, indio_dev, NULL);
> > > + if (ret)
> > > + return ret;
> >
> > We should clean up the IRQ which we enabled in adis_init() instead of
> > returning directly.
>
> I'm not sure about how to do that.
>
I believe in you that you can figure it out. :)
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Himanshu Jha <himanshujha199640@gmail.com>
Cc: devel@driverdev.osuosl.org, lars@metafoo.de,
Michael.Hennerich@analog.com, linux-iio@vger.kernel.org,
gregkh@linuxfoundation.org, 21cnbao@gmail.com,
linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de,
jic23@kernel.org
Subject: Re: [PATCH 4/4] staging: iio: accel: Move adis16201 driver out of staging
Date: Mon, 12 Feb 2018 17:45:42 +0300 [thread overview]
Message-ID: <20180212144542.qievoq76rvjigwm4@mwanda> (raw)
In-Reply-To: <20180212144157.GC12142@himanshu-Vostro-3559>
On Mon, Feb 12, 2018 at 08:11:57PM +0530, Himanshu Jha wrote:
> On Mon, Feb 12, 2018 at 04:18:26PM +0300, Dan Carpenter wrote:
> > I think -M is prefered for these types of diffs? Not sure.
>
> I wrote about that in the cover letter if you missed. :)
>
Yeah. I seldom read cover letters.
> > > + ret = adis_init(st, indio_dev, spi, &adis16201_data);
> > > + if (ret)
> > > + return ret;
> > > +
> > > + ret = adis_setup_buffer_and_trigger(st, indio_dev, NULL);
> > > + if (ret)
> > > + return ret;
> >
> > We should clean up the IRQ which we enabled in adis_init() instead of
> > returning directly.
>
> I'm not sure about how to do that.
>
I believe in you that you can figure it out. :)
regards,
dan carpenter
next prev parent reply other threads:[~2018-02-12 14:45 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 11:54 [PATCH 0/4] staging: iio: accel: adis16201 driver cleanup Himanshu Jha
2018-02-12 11:54 ` Himanshu Jha
2018-02-12 11:54 ` [PATCH 1/4] staging: iio: accel: adis16201: Use SPDX identifier Himanshu Jha
2018-02-12 11:54 ` Himanshu Jha
2018-02-12 11:54 ` [PATCH 2/4] staging: iio: accel: Remove unnecessary comments and add suitable suffix Himanshu Jha
2018-02-12 11:54 ` Himanshu Jha
2018-02-12 12:53 ` Dan Carpenter
2018-02-12 12:53 ` Dan Carpenter
2018-02-12 14:35 ` Himanshu Jha
2018-02-12 14:35 ` Himanshu Jha
2018-02-12 14:57 ` Dan Carpenter
2018-02-12 14:57 ` Dan Carpenter
2018-02-12 19:46 ` Himanshu Jha
2018-02-12 19:46 ` Himanshu Jha
2018-02-17 12:19 ` Jonathan Cameron
2018-02-17 12:19 ` Jonathan Cameron
2018-02-17 12:16 ` Jonathan Cameron
2018-02-17 12:16 ` Jonathan Cameron
2018-02-12 11:54 ` [PATCH 3/4] staging: iio: accel: Use sign_extend32 and adjust a switch statement Himanshu Jha
2018-02-12 11:54 ` Himanshu Jha
2018-02-12 13:10 ` Dan Carpenter
2018-02-12 13:10 ` Dan Carpenter
2018-02-17 12:23 ` Jonathan Cameron
2018-02-17 12:23 ` Jonathan Cameron
2018-02-17 17:24 ` Dan Carpenter
2018-02-17 17:24 ` Dan Carpenter
2018-02-12 11:54 ` [PATCH 4/4] staging: iio: accel: Move adis16201 driver out of staging Himanshu Jha
2018-02-12 11:54 ` Himanshu Jha
2018-02-12 13:18 ` Dan Carpenter
2018-02-12 13:18 ` Dan Carpenter
2018-02-12 14:41 ` Himanshu Jha
2018-02-12 14:41 ` Himanshu Jha
2018-02-12 14:45 ` Dan Carpenter [this message]
2018-02-12 14:45 ` Dan Carpenter
2018-02-17 12:26 ` Jonathan Cameron
2018-02-17 12:26 ` Jonathan Cameron
2018-02-12 14:10 ` Philippe Ombredanne
2018-02-12 14:10 ` Philippe Ombredanne
2018-02-12 14:37 ` Himanshu Jha
2018-02-12 14:37 ` Himanshu Jha
2018-02-12 22:18 ` Philippe Ombredanne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212144542.qievoq76rvjigwm4@mwanda \
--to=dan.carpenter@oracle.com \
--cc=21cnbao@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=himanshujha199640@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.