From: Brijesh Singh <brijesh.singh@amd.com> To: qemu-devel@nongnu.org Cc: Alistair Francis <alistair.francis@xilinx.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, "Daniel P . Berrange" <berrange@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>, Eduardo Habkost <ehabkost@redhat.com>, Eric Blake <eblake@redhat.com>, kvm@vger.kernel.org, Marcel Apfelbaum <marcel@redhat.com>, Markus Armbruster <armbru@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, Richard Henderson <richard.henderson@linaro.org>, Stefan Hajnoczi <stefanha@gmail.com>, Thomas Lendacky <Thomas.Lendacky@amd.com>, Borislav Petk Subject: [PATCH v8 28/28] sev/i386: add migration blocker Date: Mon, 12 Feb 2018 09:37:15 -0600 [thread overview] Message-ID: <20180212153715.87555-29-brijesh.singh@amd.com> (raw) In-Reply-To: <20180212153715.87555-1-brijesh.singh@amd.com> SEV guest migration is not implemented yet. Signed-off-by: Brijesh Singh <brijesh.singh@amd.com> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> --- target/i386/sev.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/target/i386/sev.c b/target/i386/sev.c index 2713e3591d40..4029299ace6e 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -20,6 +20,7 @@ #include "sysemu/sysemu.h" #include "trace.h" #include "qapi-event.h" +#include "migration/blocker.h" #include <sys/ioctl.h> #include <linux/psp-sev.h> @@ -33,6 +34,7 @@ static bool sev_active; static int sev_fd; static SEVState *sev_state; static MemoryRegionRAMReadWriteOps sev_ops; +static Error *sev_mig_blocker; #define SEV_FW_MAX_ERROR 0x17 @@ -603,6 +605,7 @@ static void sev_launch_finish(SEVState *s) { int ret, error; + Error *local_err = NULL; trace_kvm_sev_launch_finish(); ret = sev_ioctl(KVM_SEV_LAUNCH_FINISH, 0, &error); @@ -613,6 +616,16 @@ sev_launch_finish(SEVState *s) } sev_set_guest_state(SEV_STATE_RUNNING); + + /* add migration blocker */ + error_setg(&sev_mig_blocker, + "SEV: Migration is not implemented"); + ret = migrate_add_blocker(sev_mig_blocker, &local_err); + if (local_err) { + error_report_err(local_err); + error_free(sev_mig_blocker); + exit(1); + } } static void -- 2.14.3
WARNING: multiple messages have this Message-ID (diff)
From: Brijesh Singh <brijesh.singh@amd.com> To: qemu-devel@nongnu.org Cc: Alistair Francis <alistair.francis@xilinx.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, "Daniel P . Berrange" <berrange@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>, Eduardo Habkost <ehabkost@redhat.com>, Eric Blake <eblake@redhat.com>, kvm@vger.kernel.org, Marcel Apfelbaum <marcel@redhat.com>, Markus Armbruster <armbru@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, Richard Henderson <richard.henderson@linaro.org>, Stefan Hajnoczi <stefanha@gmail.com>, Thomas Lendacky <Thomas.Lendacky@amd.com>, Borislav Petkov <bp@suse.de>, Alexander Graf <agraf@suse.de>, Bruce Rogers <brogers@suse.com>, Brijesh Singh <brijesh.singh@amd.com> Subject: [Qemu-devel] [PATCH v8 28/28] sev/i386: add migration blocker Date: Mon, 12 Feb 2018 09:37:15 -0600 [thread overview] Message-ID: <20180212153715.87555-29-brijesh.singh@amd.com> (raw) In-Reply-To: <20180212153715.87555-1-brijesh.singh@amd.com> SEV guest migration is not implemented yet. Signed-off-by: Brijesh Singh <brijesh.singh@amd.com> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> --- target/i386/sev.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/target/i386/sev.c b/target/i386/sev.c index 2713e3591d40..4029299ace6e 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -20,6 +20,7 @@ #include "sysemu/sysemu.h" #include "trace.h" #include "qapi-event.h" +#include "migration/blocker.h" #include <sys/ioctl.h> #include <linux/psp-sev.h> @@ -33,6 +34,7 @@ static bool sev_active; static int sev_fd; static SEVState *sev_state; static MemoryRegionRAMReadWriteOps sev_ops; +static Error *sev_mig_blocker; #define SEV_FW_MAX_ERROR 0x17 @@ -603,6 +605,7 @@ static void sev_launch_finish(SEVState *s) { int ret, error; + Error *local_err = NULL; trace_kvm_sev_launch_finish(); ret = sev_ioctl(KVM_SEV_LAUNCH_FINISH, 0, &error); @@ -613,6 +616,16 @@ sev_launch_finish(SEVState *s) } sev_set_guest_state(SEV_STATE_RUNNING); + + /* add migration blocker */ + error_setg(&sev_mig_blocker, + "SEV: Migration is not implemented"); + ret = migrate_add_blocker(sev_mig_blocker, &local_err); + if (local_err) { + error_report_err(local_err); + error_free(sev_mig_blocker); + exit(1); + } } static void -- 2.14.3
next prev parent reply other threads:[~2018-02-12 15:39 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-12 15:36 [PATCH v8 00/28] x86: Secure Encrypted Virtualization (AMD) Brijesh Singh 2018-02-12 15:36 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:36 ` [PATCH v8 01/28] memattrs: add debug attribute Brijesh Singh 2018-02-12 15:36 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:36 ` [PATCH v8 02/28] exec: add ram_debug_ops support Brijesh Singh 2018-02-12 15:36 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:36 ` [PATCH v8 03/28] exec: add debug version of physical memory read and write API Brijesh Singh 2018-02-12 15:36 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:36 ` [PATCH v8 04/28] monitor/i386: use debug APIs when accessing guest memory Brijesh Singh 2018-02-12 15:36 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:36 ` [PATCH v8 05/28] target/i386: add memory encryption feature cpuid support Brijesh Singh 2018-02-12 15:36 ` [Qemu-devel] " Brijesh Singh 2018-02-12 18:38 ` Eduardo Habkost 2018-02-12 18:38 ` [Qemu-devel] " Eduardo Habkost 2018-02-12 21:07 ` Brijesh Singh 2018-02-12 21:07 ` [Qemu-devel] " Brijesh Singh 2018-02-12 21:19 ` Borislav Petkov 2018-02-12 21:19 ` [Qemu-devel] " Borislav Petkov 2018-02-13 15:39 ` Brijesh Singh 2018-02-13 15:39 ` [Qemu-devel] " Brijesh Singh 2018-02-13 15:41 ` Borislav Petkov 2018-02-13 15:41 ` Borislav Petkov 2018-02-13 15:45 ` Dr. David Alan Gilbert 2018-02-13 15:45 ` Dr. David Alan Gilbert 2018-02-12 15:36 ` [PATCH v8 06/28] machine: add -memory-encryption property Brijesh Singh 2018-02-12 15:36 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:36 ` [PATCH v8 07/28] kvm: update kvm.h to include memory encryption ioctls Brijesh Singh 2018-02-12 15:36 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:36 ` [PATCH v8 08/28] docs: add AMD Secure Encrypted Virtualization (SEV) Brijesh Singh 2018-02-12 15:36 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:36 ` [PATCH v8 09/28] target/i386: add Secure Encrypted Virtulization (SEV) object Brijesh Singh 2018-02-12 15:36 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:36 ` [PATCH v8 10/28] sev/i386: add command to initialize the memory encryption context Brijesh Singh 2018-02-12 15:36 ` [Qemu-devel] " Brijesh Singh 2018-02-12 18:57 ` Eduardo Habkost 2018-02-12 18:57 ` [Qemu-devel] " Eduardo Habkost 2018-02-12 15:36 ` [PATCH v8 11/28] sev/i386: register the guest memory range which may contain encrypted data Brijesh Singh 2018-02-12 15:36 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:36 ` [PATCH v8 12/28] kvm: introduce memory encryption APIs Brijesh Singh 2018-02-12 15:36 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:37 ` [PATCH v8 13/28] qmp: add query-sev command Brijesh Singh 2018-02-12 15:37 ` [Qemu-devel] " Brijesh Singh 2018-02-12 17:27 ` Eric Blake 2018-02-12 17:27 ` [Qemu-devel] " Eric Blake 2018-02-12 18:47 ` Brijesh Singh 2018-02-12 18:47 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:37 ` [PATCH v8 14/28] hmp: add 'info sev' command Brijesh Singh 2018-02-12 15:37 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:37 ` [PATCH v8 15/28] sev/i386: add command to create launch memory encryption context Brijesh Singh 2018-02-12 15:37 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:37 ` [PATCH v8 16/28] sev/i386: add command to encrypt guest memory region Brijesh Singh 2018-02-12 15:37 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:37 ` [PATCH v8 17/28] target/i386: encrypt bios rom Brijesh Singh 2018-02-12 15:37 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:37 ` [PATCH v8 18/28] sev/i386: add support to LAUNCH_MEASURE command Brijesh Singh 2018-02-12 15:37 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:37 ` [PATCH v8 19/28] sev/i386: finalize the SEV guest launch flow Brijesh Singh 2018-02-12 15:37 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:37 ` [PATCH v8 20/28] hw/i386: set ram_debug_ops when memory encryption is enabled Brijesh Singh 2018-02-12 15:37 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:37 ` [PATCH v8 21/28] sev/i386: add debug encrypt and decrypt commands Brijesh Singh 2018-02-12 15:37 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:37 ` [PATCH v8 22/28] target/i386: clear C-bit when walking SEV guest page table Brijesh Singh 2018-02-12 15:37 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:37 ` [PATCH v8 23/28] include: add psp-sev.h header file Brijesh Singh 2018-02-12 15:37 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:37 ` [PATCH v8 24/28] sev/i386: add support to query PLATFORM_STATUS command Brijesh Singh 2018-02-12 15:37 ` [PATCH v8 25/28] sev/i386: add support to KVM_SEV_GUEST_STATUS Brijesh Singh 2018-02-12 15:37 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:37 ` [PATCH v8 26/28] qmp: add query-sev-launch-measure command Brijesh Singh 2018-02-12 15:37 ` [Qemu-devel] " Brijesh Singh 2018-02-12 15:37 ` [PATCH v8 27/28] tests/qmp-test: blacklist " Brijesh Singh 2018-02-12 15:37 ` [Qemu-devel] " Brijesh Singh 2018-02-13 16:44 ` Dr. David Alan Gilbert 2018-02-13 16:44 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-02-12 15:37 ` Brijesh Singh [this message] 2018-02-12 15:37 ` [Qemu-devel] [PATCH v8 28/28] sev/i386: add migration blocker Brijesh Singh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180212153715.87555-29-brijesh.singh@amd.com \ --to=brijesh.singh@amd.com \ --cc=Thomas.Lendacky@amd.com \ --cc=alistair.francis@xilinx.com \ --cc=armbru@redhat.com \ --cc=berrange@redhat.com \ --cc=borntraeger@de.ibm.com \ --cc=cornelia.huck@de.ibm.com \ --cc=crosthwaite.peter@gmail.com \ --cc=dgilbert@redhat.com \ --cc=eblake@redhat.com \ --cc=edgar.iglesias@xilinx.com \ --cc=ehabkost@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=marcel@redhat.com \ --cc=mst@redhat.com \ --cc=pbonzini@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=qemu-devel@nongnu.org \ --cc=richard.henderson@linaro.org \ --cc=stefanha@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.