Re: [PATCH v2 1/2] fontconfig: fix upstream version check

Re: [PATCH v2 1/2] fontconfig: fix upstream version check

[Alexander Kanavin]

On 02/12/2018 07:03 PM, Maxin B. John wrote:
> In the case of fontconfig, version x.x.9x are release candidates
> for next version.
> +UPSTREAM_CHECK_REGEX = "fontconfig-(?P<pver>\d+\.\d+\.(?!9\d+)\d+)\.tar\.gz"

Drop the \.gz part. Upstreams can and do switch to anything else at any 
point - bz2, xz, lz, whateverz.

Alex

[PATCH v2 1/2] fontconfig: fix upstream version check

[Maxin B. John]

In the case of fontconfig, version x.x.9x are release candidates
for next version.

Signed-off-by: Maxin B. John <maxin.john@intel.com>
---
 meta/recipes-graphics/fontconfig/fontconfig_2.12.6.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-graphics/fontconfig/fontconfig_2.12.6.bb b/meta/recipes-graphics/fontconfig/fontconfig_2.12.6.bb
index fa5f0ee..1b4f87b 100644
--- a/meta/recipes-graphics/fontconfig/fontconfig_2.12.6.bb
+++ b/meta/recipes-graphics/fontconfig/fontconfig_2.12.6.bb
@@ -28,6 +28,7 @@ SRC_URI = "http://fontconfig.org/release/fontconfig-${PV}.tar.gz \
 SRC_URI[md5sum] = "00e748c67fad11e7057a71ed385e8bdb"
 SRC_URI[sha256sum] = "064b9ebf060c9e77011733ac9dc0e2ce92870b574cca2405e11f5353a683c334"
 
+UPSTREAM_CHECK_REGEX = "fontconfig-(?P<pver>\d+\.\d+\.(?!9\d+)\d+)\.tar\.gz"
 
 do_configure_prepend() {
     # work around https://bugs.freedesktop.org/show_bug.cgi?id=101280
-- 
2.4.0

[PATCH v2 2/2] libinput: fix upstream version check

[Maxin B. John]

Skip RC releases for libinput which follow the pattern: x.x.9xx

Signed-off-by: Maxin B. John <maxin.john@intel.com>
---
 meta/recipes-graphics/wayland/libinput_1.9.4.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-graphics/wayland/libinput_1.9.4.bb b/meta/recipes-graphics/wayland/libinput_1.9.4.bb
index 2843314..3879356 100644
--- a/meta/recipes-graphics/wayland/libinput_1.9.4.bb
+++ b/meta/recipes-graphics/wayland/libinput_1.9.4.bb
@@ -12,6 +12,7 @@ SRC_URI = "http://www.freedesktop.org/software/${BPN}/${BP}.tar.xz \
 SRC_URI[md5sum] = "8b43d07d1698fb207a0492fc67554d4f"
 SRC_URI[sha256sum] = "0bcdbd4c4e3c2a2db322fbdf2ef3284f2e6d6fb7be3af80e6d8de7783f675190"
 
+UPSTREAM_CHECK_REGEX = "libinput-(?P<pver>\d+\.\d+\.(?!9\d+)\d+)\.tar\.xz"
 inherit meson pkgconfig lib_package
 
 PACKAGECONFIG ??= ""
-- 
2.4.0

Re: [PATCH v2 2/2] libinput: fix upstream version check

[Alexander Kanavin]

On 02/12/2018 07:03 PM, Maxin B. John wrote:
> Skip RC releases for libinput which follow the pattern: x.x.9xx
>   
> +UPSTREAM_CHECK_REGEX = "libinput-(?P<pver>\d+\.\d+\.(?!9\d+)\d+)\.tar\.xz"

Same here: dom't hardcode the compression format. Otherwise, seems fine.

Alex

Re: [PATCH v2 2/2] libinput: fix upstream version check

[Maxin B. John]

Hi,
On Mon, Feb 12, 2018 at 07:05:27PM +0200, Alexander Kanavin wrote:
> On 02/12/2018 07:03 PM, Maxin B. John wrote:
> >Skip RC releases for libinput which follow the pattern: x.x.9xx
> >+UPSTREAM_CHECK_REGEX = "libinput-(?P<pver>\d+\.\d+\.(?!9\d+)\d+)\.tar\.xz"
> 
> Same here: dom't hardcode the compression format. Otherwise, seems fine.

Updated and sent v3. Thanks.

> Alex

Best Regards,
Maxin