* [U-Boot] [PATCH] Fix misaligned buffer in env_fat_save
@ 2018-02-07 20:01 Alex Kiernan
2018-02-12 22:32 ` [U-Boot] " Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Alex Kiernan @ 2018-02-07 20:01 UTC (permalink / raw)
To: u-boot
When saving the environment on a platform which has DMA alignment
larger than the natural alignment, env_fat_save triggers a debug
message in file_fat_write:
Saving Environment to FAT... writing uboot.env
FAT: Misaligned buffer address (9df1c8e0)
OK
Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
---
env/fat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/env/fat.c b/env/fat.c
index 35f7ab5..e6bd1f9 100644
--- a/env/fat.c
+++ b/env/fat.c
@@ -36,7 +36,7 @@ DECLARE_GLOBAL_DATA_PTR;
#ifdef CMD_SAVEENV
static int env_fat_save(void)
{
- env_t env_new;
+ env_t __aligned(ARCH_DMA_MINALIGN) env_new;
struct blk_desc *dev_desc = NULL;
disk_partition_t info;
int dev, part;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] Fix misaligned buffer in env_fat_save
2018-02-07 20:01 [U-Boot] [PATCH] Fix misaligned buffer in env_fat_save Alex Kiernan
@ 2018-02-12 22:32 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2018-02-12 22:32 UTC (permalink / raw)
To: u-boot
On Wed, Feb 07, 2018 at 08:01:54PM +0000, Alex Kiernan wrote:
> When saving the environment on a platform which has DMA alignment
> larger than the natural alignment, env_fat_save triggers a debug
> message in file_fat_write:
>
> Saving Environment to FAT... writing uboot.env
> FAT: Misaligned buffer address (9df1c8e0)
> OK
>
> Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180212/eada4f54/attachment.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-12 22:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-07 20:01 [U-Boot] [PATCH] Fix misaligned buffer in env_fat_save Alex Kiernan
2018-02-12 22:32 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.