All of lore.kernel.org
 help / color / mirror / Atom feed
From: shuahkh@osg.samsung.com (Shuah Khan)
Subject: [PATCH v2] selftests: sync: missing CFLAGS while compiling
Date: Tue, 13 Feb 2018 14:25:10 -0700	[thread overview]
Message-ID: <24ab9c58-2f4c-b433-7b36-421e51a2e79b@osg.samsung.com> (raw)
Message-ID: <20180213212510.1WIMb35R1DR1pt3NDpf_V4rqYVNESR6ph0RvxTp18ZM@z> (raw)
In-Reply-To: <1517955821-11511-1-git-send-email-daniel.diaz@linaro.org>

On 02/06/2018 03:23 PM, Daniel Díaz wrote:
> From: Anders Roxell <anders.roxell at linaro.org>
> 
> Based on patch: https://patchwork.kernel.org/patch/10042045/
> 
> arch64-linux-gnu-gcc -c sync.c -o sync/sync.o
> sync.c:42:29: fatal error: linux/sync_file.h: No such file or directory
>  #include <linux/sync_file.h>
>                              ^
> CFLAGS is not used during the compile step, so the system instead of
> kernel headers are used.  Fix this by adding CFLAGS to the OBJS compile
> rule.
> 
> Reported-by: Lei Yang <Lei.Yang at windriver.com>
> Signed-off-by: Anders Roxell <anders.roxell at linaro.org>
> Signed-off-by: Daniel Díaz <daniel.diaz at linaro.org>
> ---
>  tools/testing/selftests/sync/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/sync/Makefile b/tools/testing/selftests/sync/Makefile
> index b3c8ba3..d0121a8 100644
> --- a/tools/testing/selftests/sync/Makefile
> +++ b/tools/testing/selftests/sync/Makefile
> @@ -30,7 +30,7 @@ $(TEST_CUSTOM_PROGS): $(TESTS) $(OBJS)
>  	$(CC) -o $(TEST_CUSTOM_PROGS) $(OBJS) $(TESTS) $(CFLAGS) $(LDFLAGS)
>  
>  $(OBJS): $(OUTPUT)/%.o: %.c
> -	$(CC) -c $^ -o $@
> +	$(CC) -c $^ -o $@ $(CFLAGS)
>  
>  $(TESTS): $(OUTPUT)/%.o: %.c
>  	$(CC) -c $^ -o $@
> 

Thanks for the patch. Applied to linux-kselftest fixes for 4.16-rc3

thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-02-13 21:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06 22:23 [PATCH v2] selftests: sync: missing CFLAGS while compiling Daniel Díaz
2018-02-06 22:23 ` [Linux-kselftest-mirror] " Daniel Díaz
2018-02-06 22:23 ` 
2018-02-13 21:25 ` Shuah Khan [this message]
2018-02-13 21:25   ` Shuah Khan
2018-02-13 21:25   ` shuahkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24ab9c58-2f4c-b433-7b36-421e51a2e79b@osg.samsung.com \
    --to=shuahkh@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.