* [Buildroot] [PATCH 1/1] qt5webengine: fix build issue with alsa
@ 2018-02-09 1:22 Gaël PORTAY
2018-02-09 1:35 ` Gaël PORTAY
0 siblings, 1 reply; 4+ messages in thread
From: Gaël PORTAY @ 2018-02-09 1:22 UTC (permalink / raw)
To: buildroot
Qt WebEngine auto-guesses if it compiles support for alsa. When the
alsa-lib config is enabled but the features mixer, rawmidi, hwdep and
seq are not also enabled, it leads to a build failure.
Lets the developer decide whether or not support for alsa in Qt
WebEngine by adding the new config BR2_PACKAGE_QT5WEBENGINE_ALSA that
selects the features it needs when it is set.
Fixes [1].
[1]: http://autobuild.buildroot.net/results/d81537a8f67bb0a3625057560b2f16daf4828f98/build-end.log
Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>
---
package/qt5/qt5webengine/Config.in | 10 ++++++++++
package/qt5/qt5webengine/qt5webengine.mk | 6 ++++++
2 files changed, 16 insertions(+)
diff --git a/package/qt5/qt5webengine/Config.in b/package/qt5/qt5webengine/Config.in
index d0c8d18210..387ce0a76e 100644
--- a/package/qt5/qt5webengine/Config.in
+++ b/package/qt5/qt5webengine/Config.in
@@ -81,4 +81,14 @@ config BR2_PACKAGE_QT5WEBENGINE_PROPRIETARY_CODECS
which includes required proprietary audio and video codecs,
such as H.264 and MPEG layer-3 (MP3).
+config BR2_PACKAGE_QT5WEBENGINE_ALSA
+ bool "alsa"
+ depends on BR2_PACKAGE_ALSA_LIB
+ select BR2_PACKAGE_ALSA_LIB_MIXER
+ select BR2_PACKAGE_ALSA_LIB_RAWMIDI
+ select BR2_PACKAGE_ALSA_LIB_HWDEP
+ select BR2_PACKAGE_ALSA_LIB_SEQ
+ help
+ Enable ALSA support.
+
endif
diff --git a/package/qt5/qt5webengine/qt5webengine.mk b/package/qt5/qt5webengine/qt5webengine.mk
index 96dd401c6c..344ecc514b 100644
--- a/package/qt5/qt5webengine/qt5webengine.mk
+++ b/package/qt5/qt5webengine/qt5webengine.mk
@@ -28,6 +28,12 @@ ifeq ($(BR2_PACKAGE_QT5WEBENGINE_PROPRIETARY_CODECS),y)
QT5WEBENGINE_QMAKEFLAGS += WEBENGINE_CONFIG+=use_proprietary_codecs
endif
+ifeq ($(BR2_PACKAGE_QT5WEBENGINE_ALSA),y)
+QT5WEBENGINE_DEPENDENCIES += alsa-lib
+else
+QT5WEBENGINE_QMAKEFLAGS += QT_CONFIG-=alsa
+endif
+
# QtWebengine's build system uses python, but only supports python2. We work
# around this by forcing python2 early in the PATH, via a python->python2
# symlink.
--
2.15.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] qt5webengine: fix build issue with alsa
2018-02-09 1:22 [Buildroot] [PATCH 1/1] qt5webengine: fix build issue with alsa Gaël PORTAY
@ 2018-02-09 1:35 ` Gaël PORTAY
2018-02-13 22:22 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Gaël PORTAY @ 2018-02-09 1:35 UTC (permalink / raw)
To: buildroot
On Thu, Feb 08, 2018 at 08:22:36PM -0500, Ga?l PORTAY wrote:
> +config BR2_PACKAGE_QT5WEBENGINE_ALSA
> + bool "alsa"
> + depends on BR2_PACKAGE_ALSA_LIB
Well, I should probably select BR2_PACKAGE_ALSA_LIB instead of depending
on it :/
> + select BR2_PACKAGE_ALSA_LIB_MIXER
> + select BR2_PACKAGE_ALSA_LIB_RAWMIDI
> + select BR2_PACKAGE_ALSA_LIB_HWDEP
> + select BR2_PACKAGE_ALSA_LIB_SEQ
> + help
> + Enable ALSA support.
> +
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] qt5webengine: fix build issue with alsa
2018-02-09 1:35 ` Gaël PORTAY
@ 2018-02-13 22:22 ` Thomas Petazzoni
2018-02-13 22:44 ` Gaël PORTAY
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2018-02-13 22:22 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 8 Feb 2018 20:35:36 -0500, Ga?l PORTAY wrote:
> On Thu, Feb 08, 2018 at 08:22:36PM -0500, Ga?l PORTAY wrote:
> > +config BR2_PACKAGE_QT5WEBENGINE_ALSA
> > + bool "alsa"
> > + depends on BR2_PACKAGE_ALSA_LIB
>
> Well, I should probably select BR2_PACKAGE_ALSA_LIB instead of depending
> on it :/
Are you going to submit an updated version ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] qt5webengine: fix build issue with alsa
2018-02-13 22:22 ` Thomas Petazzoni
@ 2018-02-13 22:44 ` Gaël PORTAY
0 siblings, 0 replies; 4+ messages in thread
From: Gaël PORTAY @ 2018-02-13 22:44 UTC (permalink / raw)
To: buildroot
Thomas,
On Tue, Feb 13, 2018 at 11:22:29PM +0100, Thomas Petazzoni wrote:
> Hello,
>
> On Thu, 8 Feb 2018 20:35:36 -0500, Ga?l PORTAY wrote:
> > On Thu, Feb 08, 2018 at 08:22:36PM -0500, Ga?l PORTAY wrote:
> > > +config BR2_PACKAGE_QT5WEBENGINE_ALSA
> > > + bool "alsa"
> > > + depends on BR2_PACKAGE_ALSA_LIB
> >
> > Well, I should probably select BR2_PACKAGE_ALSA_LIB instead of depending
> > on it :/
>
> Are you going to submit an updated version ?
>
Let me test again the fix with select and I will send a v2 shortly.
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> http://bootlin.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Regards,
Gael
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-13 22:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-09 1:22 [Buildroot] [PATCH 1/1] qt5webengine: fix build issue with alsa Gaël PORTAY
2018-02-09 1:35 ` Gaël PORTAY
2018-02-13 22:22 ` Thomas Petazzoni
2018-02-13 22:44 ` Gaël PORTAY
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.