* [igt-dev] [i-g-t] tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require()
@ 2018-02-14 1:09 Anusha Srivatsa
2018-02-14 2:01 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Anusha Srivatsa @ 2018-02-14 1:09 UTC (permalink / raw)
To: igt-dev; +Cc: Anusha Srivatsa, Rodrigo Vivi, Daniel Vetter
Rework the rotate and reflect subtests by checking the
crtc supported properties against the ones that the
test is testing. Remove the hardcoded platform names in
igt_require()
Cc: Radhakrishna Sripad <radhakrishna.sripada@intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Mika Kahola <mika.kahola@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
tests/kms_rotation_crc.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index 0cd5c6e..49d57a2 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -373,9 +373,6 @@ static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_form
igt_plane_t *plane;
int i, j;
- if (IS_CHERRYVIEW(data->devid) && pipe != PIPE_B)
- continue;
-
igt_output_set_pipe(output, pipe);
plane = igt_output_get_plane_type(output, plane_type);
@@ -558,9 +555,7 @@ igt_main
igt_subtest_f("%s-rotation-%s",
plane_test_str(subtest->plane),
rot_test_str(subtest->rot)) {
- igt_require(!(subtest->rot &
- (IGT_ROTATION_90 | IGT_ROTATION_270)) ||
- gen >= 9);
+ igt_require(igt_plane_get_prop(data.display.pipes->planes, IGT_PLANE_ROTATION) & subtest->rot);
data.rotation = subtest->rot;
test_plane_rotation(&data, subtest->plane, false);
}
@@ -596,9 +591,8 @@ igt_main
igt_subtest_f("primary-%s-reflect-x-%s",
tiling_test_str(reflect_x->tiling),
rot_test_str(reflect_x->rot)) {
- igt_require(gen >= 10 ||
- (IS_CHERRYVIEW(data.devid) && reflect_x->rot == IGT_ROTATION_0
- && reflect_x->tiling == LOCAL_I915_FORMAT_MOD_X_TILED));
+ igt_require((igt_plane_get_prop(data.display.pipes->planes, IGT_PLANE_ROTATION) & subtest->rot) &&
+ (reflect_x->rot == IGT_ROTATION_0 && reflect_x->tiling == LOCAL_I915_FORMAT_MOD_X_TILED));
data.rotation = (IGT_REFLECT_X | reflect_x->rot);
data.override_tiling = reflect_x->tiling;
test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY, false);
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require()
2018-02-14 1:09 [igt-dev] [i-g-t] tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require() Anusha Srivatsa
@ 2018-02-14 2:01 ` Patchwork
2018-02-14 7:40 ` [igt-dev] [i-g-t] " Srivatsa, Anusha
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-02-14 2:01 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: igt-dev
== Series Details ==
Series: tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require()
URL : https://patchwork.freedesktop.org/series/38205/
State : failure
== Summary ==
IGT patchset tested on top of latest successful build
6d51cf112374ba73f7391b5d846bb83e81b060d3 tests/perf_pmu: Give sampling more time
with latest DRM-Tip kernel build CI_DRM_3768
e404d341ffdd drm-tip: 2018y-02m-14d-01h-12m-17s UTC integration manifest
No testlist changes.
Test debugfs_test:
Subgroup read_all_entries:
pass -> INCOMPLETE (fi-snb-2520m) fdo#103713
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
pass -> FAIL (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
dmesg-warn -> PASS (fi-cnl-y3) fdo#105058
Test prime_vgem:
Subgroup basic-fence-flip:
pass -> FAIL (fi-pnv-d510)
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#105058 https://bugs.freedesktop.org/show_bug.cgi?id=105058
fi-bdw-5557u total:288 pass:265 dwarn:0 dfail:0 fail:2 skip:21 time:443s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:428s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:376s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:485s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:289s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:488s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:483s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:475s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:463s
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:566s
fi-cnl-y3 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:589s
fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:419s
fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:286s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:514s
fi-hsw-4770 total:288 pass:259 dwarn:0 dfail:0 fail:2 skip:27 time:414s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:415s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:460s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:419s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:458s
fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:497s
fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:502s
fi-pnv-d510 total:288 pass:221 dwarn:1 dfail:0 fail:1 skip:65 time:588s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:435s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:507s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:527s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:495s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:489s
fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:422s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:433s
fi-snb-2520m total:3 pass:2 dwarn:0 dfail:0 fail:0 skip:0
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:403s
Blacklisted hosts:
fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:470s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:454s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_911/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [i-g-t] tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require()
2018-02-14 1:09 [igt-dev] [i-g-t] tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require() Anusha Srivatsa
2018-02-14 2:01 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2018-02-14 7:40 ` Srivatsa, Anusha
2018-02-14 9:08 ` Maarten Lankhorst
2018-02-14 9:15 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-02-14 11:16 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 1 reply; 8+ messages in thread
From: Srivatsa, Anusha @ 2018-02-14 7:40 UTC (permalink / raw)
To: igt-dev
>-----Original Message-----
>From: Srivatsa, Anusha
>Sent: Tuesday, February 13, 2018 5:09 PM
>To: igt-dev@lists.freedesktop.org
>Cc: Srivatsa, Anusha <anusha.srivatsa@intel.com>; Sripada, Radhakrishna
><radhakrishna.sripada@intel.com>; Vetter, Daniel <daniel.vetter@intel.com>;
>Vivi, Rodrigo <rodrigo.vivi@intel.com>; Maarten Lankhorst
><maarten.lankhorst@linux.intel.com>; Kahola, Mika <mika.kahola@intel.com>
>Subject: [i-g-t] tests/kms_rotation_crc: Remove hardcoding of platforms in
>igt_require()
>
>Rework the rotate and reflect subtests by checking the crtc supported properties
>against the ones that the test is testing. Remove the hardcoded platform names
>in
>igt_require()
>
>Cc: Radhakrishna Sripad <radhakrishna.sripada@intel.com>
>Cc: Daniel Vetter <daniel.vetter@intel.com>
>Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>Cc: Mika Kahola <mika.kahola@intel.com>
>Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>---
> tests/kms_rotation_crc.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
>diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c index
>0cd5c6e..49d57a2 100644
>--- a/tests/kms_rotation_crc.c
>+++ b/tests/kms_rotation_crc.c
>@@ -373,9 +373,6 @@ static void test_plane_rotation(data_t *data, int
>plane_type, bool test_bad_form
> igt_plane_t *plane;
> int i, j;
>
>- if (IS_CHERRYVIEW(data->devid) && pipe != PIPE_B)
>- continue;
>-
> igt_output_set_pipe(output, pipe);
>
> plane = igt_output_get_plane_type(output, plane_type); @@ -
>558,9 +555,7 @@ igt_main
> igt_subtest_f("%s-rotation-%s",
> plane_test_str(subtest->plane),
> rot_test_str(subtest->rot)) {
>- igt_require(!(subtest->rot &
>- (IGT_ROTATION_90 | IGT_ROTATION_270)) ||
>- gen >= 9);
>+ igt_require(igt_plane_get_prop(data.display.pipes-
>>planes,
>+IGT_PLANE_ROTATION) & subtest->rot);
Mika, Maarten,
Any comments?
Anusha
> data.rotation = subtest->rot;
> test_plane_rotation(&data, subtest->plane, false);
> }
>@@ -596,9 +591,8 @@ igt_main
> igt_subtest_f("primary-%s-reflect-x-%s",
> tiling_test_str(reflect_x->tiling),
> rot_test_str(reflect_x->rot)) {
>- igt_require(gen >= 10 ||
>- (IS_CHERRYVIEW(data.devid) && reflect_x-
>>rot == IGT_ROTATION_0
>- && reflect_x->tiling ==
>LOCAL_I915_FORMAT_MOD_X_TILED));
>+ igt_require((igt_plane_get_prop(data.display.pipes-
>>planes, IGT_PLANE_ROTATION) & subtest->rot) &&
>+ (reflect_x->rot == IGT_ROTATION_0 &&
>reflect_x->tiling ==
>+LOCAL_I915_FORMAT_MOD_X_TILED));
> data.rotation = (IGT_REFLECT_X | reflect_x->rot);
> data.override_tiling = reflect_x->tiling;
> test_plane_rotation(&data,
>DRM_PLANE_TYPE_PRIMARY, false);
>--
>2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [i-g-t] tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require()
2018-02-14 7:40 ` [igt-dev] [i-g-t] " Srivatsa, Anusha
@ 2018-02-14 9:08 ` Maarten Lankhorst
2018-02-14 11:39 ` Mika Kahola
0 siblings, 1 reply; 8+ messages in thread
From: Maarten Lankhorst @ 2018-02-14 9:08 UTC (permalink / raw)
To: Srivatsa, Anusha, igt-dev
Op 14-02-18 om 08:40 schreef Srivatsa, Anusha:
>
>> -----Original Message-----
>> From: Srivatsa, Anusha
>> Sent: Tuesday, February 13, 2018 5:09 PM
>> To: igt-dev@lists.freedesktop.org
>> Cc: Srivatsa, Anusha <anusha.srivatsa@intel.com>; Sripada, Radhakrishna
>> <radhakrishna.sripada@intel.com>; Vetter, Daniel <daniel.vetter@intel.com>;
>> Vivi, Rodrigo <rodrigo.vivi@intel.com>; Maarten Lankhorst
>> <maarten.lankhorst@linux.intel.com>; Kahola, Mika <mika.kahola@intel.com>
>> Subject: [i-g-t] tests/kms_rotation_crc: Remove hardcoding of platforms in
>> igt_require()
>>
>> Rework the rotate and reflect subtests by checking the crtc supported properties
>> against the ones that the test is testing. Remove the hardcoded platform names
>> in
>> igt_require()
>>
>> Cc: Radhakrishna Sripad <radhakrishna.sripada@intel.com>
>> Cc: Daniel Vetter <daniel.vetter@intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Cc: Mika Kahola <mika.kahola@intel.com>
>> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> ---
>> tests/kms_rotation_crc.c | 12 +++---------
>> 1 file changed, 3 insertions(+), 9 deletions(-)
>>
>> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c index
>> 0cd5c6e..49d57a2 100644
>> --- a/tests/kms_rotation_crc.c
>> +++ b/tests/kms_rotation_crc.c
>> @@ -373,9 +373,6 @@ static void test_plane_rotation(data_t *data, int
>> plane_type, bool test_bad_form
>> igt_plane_t *plane;
>> int i, j;
>>
>> - if (IS_CHERRYVIEW(data->devid) && pipe != PIPE_B)
>> - continue;
>> -
>> igt_output_set_pipe(output, pipe);
>>
>> plane = igt_output_get_plane_type(output, plane_type); @@ -
>> 558,9 +555,7 @@ igt_main
>> igt_subtest_f("%s-rotation-%s",
>> plane_test_str(subtest->plane),
>> rot_test_str(subtest->rot)) {
>> - igt_require(!(subtest->rot &
>> - (IGT_ROTATION_90 | IGT_ROTATION_270)) ||
>> - gen >= 9);
>> + igt_require(igt_plane_get_prop(data.display.pipes-
>>> planes,
>> +IGT_PLANE_ROTATION) & subtest->rot);
> Mika, Maarten,
> Any comments?
igt_plane_get_prop returns the current value, not all supported rotations. I've retried the patch series, but if it still doesn't run you'll see a lot of PASS change to SKIP.
~Maarten
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require()
2018-02-14 1:09 [igt-dev] [i-g-t] tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require() Anusha Srivatsa
2018-02-14 2:01 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2018-02-14 7:40 ` [igt-dev] [i-g-t] " Srivatsa, Anusha
@ 2018-02-14 9:15 ` Patchwork
2018-02-14 11:16 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-02-14 9:15 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: igt-dev
== Series Details ==
Series: tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require()
URL : https://patchwork.freedesktop.org/series/38205/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
6d51cf112374ba73f7391b5d846bb83e81b060d3 tests/perf_pmu: Give sampling more time
with latest DRM-Tip kernel build CI_DRM_3768
e404d341ffdd drm-tip: 2018y-02m-14d-01h-12m-17s UTC integration manifest
No testlist changes.
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
pass -> FAIL (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
dmesg-warn -> PASS (fi-cnl-y3) fdo#105058
Subgroup suspend-read-crc-pipe-b:
incomplete -> PASS (fi-snb-2520m) fdo#103713
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#105058 https://bugs.freedesktop.org/show_bug.cgi?id=105058
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fi-bdw-5557u total:288 pass:265 dwarn:0 dfail:0 fail:2 skip:21 time:437s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:428s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:375s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:497s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:289s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:481s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:489s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:474s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:462s
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:575s
fi-cnl-y3 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:587s
fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:416s
fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:285s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:513s
fi-hsw-4770 total:288 pass:259 dwarn:0 dfail:0 fail:2 skip:27 time:417s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:420s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:453s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:457s
fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:505s
fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:498s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:595s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:432s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:510s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:536s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:496s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:475s
fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:415s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:432s
fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:524s
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:401s
Blacklisted hosts:
fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:473s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:455s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_912/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require()
2018-02-14 1:09 [igt-dev] [i-g-t] tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require() Anusha Srivatsa
` (2 preceding siblings ...)
2018-02-14 9:15 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-02-14 11:16 ` Patchwork
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-02-14 11:16 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: igt-dev
== Series Details ==
Series: tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require()
URL : https://patchwork.freedesktop.org/series/38205/
State : failure
== Summary ==
Test kms_flip:
Subgroup 2x-modeset-vs-vblank-race-interruptible:
pass -> DMESG-WARN (shard-hsw)
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-primscrn-pri-shrfb-draw-blt:
dmesg-fail -> PASS (shard-apl) fdo#101623
Subgroup fbc-1p-shrfb-fliptrack:
fail -> PASS (shard-apl) fdo#103167
Test perf:
Subgroup polling:
fail -> PASS (shard-hsw) fdo#102252
Test kms_cursor_legacy:
Subgroup cursor-vs-flip-atomic-transitions-varying-size:
pass -> FAIL (shard-apl)
Test kms_cursor_crc:
Subgroup cursor-64x64-suspend:
skip -> PASS (shard-snb) fdo#102365
Subgroup cursor-256x256-suspend:
pass -> INCOMPLETE (shard-hsw) fdo#103375
Test kms_rotation_crc:
Subgroup sprite-rotation-270:
pass -> SKIP (shard-apl) fdo#103356 +1
Subgroup primary-rotation-180:
pass -> SKIP (shard-snb) fdo#103925 +2
pass -> SKIP (shard-hsw)
Subgroup sprite-rotation-180:
pass -> SKIP (shard-snb)
pass -> SKIP (shard-hsw)
pass -> SKIP (shard-apl)
Subgroup cursor-rotation-180:
pass -> SKIP (shard-snb)
pass -> SKIP (shard-hsw) fdo#102614
pass -> SKIP (shard-apl)
Subgroup primary-rotation-270:
pass -> SKIP (shard-apl)
Test pm_rpm:
Subgroup universal-planes:
pass -> FAIL (shard-hsw) fdo#105069 +5
Test gem_eio:
Subgroup in-flight-external:
pass -> FAIL (shard-hsw) fdo#104676
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103356 https://bugs.freedesktop.org/show_bug.cgi?id=103356
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#105069 https://bugs.freedesktop.org/show_bug.cgi?id=105069
fdo#104676 https://bugs.freedesktop.org/show_bug.cgi?id=104676
shard-apl total:3352 pass:1733 dwarn:1 dfail:0 fail:22 skip:1595 time:13769s
shard-hsw total:3406 pass:1706 dwarn:2 dfail:0 fail:53 skip:1643 time:13929s
shard-snb total:3427 pass:1346 dwarn:1 dfail:0 fail:10 skip:2070 time:7603s
Blacklisted hosts:
shard-kbl total:3382 pass:1876 dwarn:1 dfail:0 fail:20 skip:1484 time:10745s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_912/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [i-g-t] tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require()
2018-02-14 9:08 ` Maarten Lankhorst
@ 2018-02-14 11:39 ` Mika Kahola
2018-02-14 17:57 ` Srivatsa, Anusha
0 siblings, 1 reply; 8+ messages in thread
From: Mika Kahola @ 2018-02-14 11:39 UTC (permalink / raw)
To: Maarten Lankhorst, Srivatsa, Anusha, igt-dev
On Wed, 2018-02-14 at 10:08 +0100, Maarten Lankhorst wrote:
> Op 14-02-18 om 08:40 schreef Srivatsa, Anusha:
> >
> >
> > >
> > > -----Original Message-----
> > > From: Srivatsa, Anusha
> > > Sent: Tuesday, February 13, 2018 5:09 PM
> > > To: igt-dev@lists.freedesktop.org
> > > Cc: Srivatsa, Anusha <anusha.srivatsa@intel.com>; Sripada,
> > > Radhakrishna
> > > <radhakrishna.sripada@intel.com>; Vetter, Daniel <daniel.vetter@i
> > > ntel.com>;
> > > Vivi, Rodrigo <rodrigo.vivi@intel.com>; Maarten Lankhorst
> > > <maarten.lankhorst@linux.intel.com>; Kahola, Mika <mika.kahola@in
> > > tel.com>
> > > Subject: [i-g-t] tests/kms_rotation_crc: Remove hardcoding of
> > > platforms in
> > > igt_require()
> > >
> > > Rework the rotate and reflect subtests by checking the crtc
> > > supported properties
> > > against the ones that the test is testing. Remove the hardcoded
> > > platform names
> > > in
> > > igt_require()
> > >
> > > Cc: Radhakrishna Sripad <radhakrishna.sripada@intel.com>
> > > Cc: Daniel Vetter <daniel.vetter@intel.com>
> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > > Cc: Mika Kahola <mika.kahola@intel.com>
> > > Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > > ---
> > > tests/kms_rotation_crc.c | 12 +++---------
> > > 1 file changed, 3 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> > > index
> > > 0cd5c6e..49d57a2 100644
> > > --- a/tests/kms_rotation_crc.c
> > > +++ b/tests/kms_rotation_crc.c
> > > @@ -373,9 +373,6 @@ static void test_plane_rotation(data_t *data,
> > > int
> > > plane_type, bool test_bad_form
> > > igt_plane_t *plane;
> > > int i, j;
> > >
> > > - if (IS_CHERRYVIEW(data->devid) && pipe !=
> > > PIPE_B)
> > > - continue;
> > > -
> > > igt_output_set_pipe(output, pipe);
> > >
> > > plane = igt_output_get_plane_type(output, plane_type);
> > > @@ -
> > > 558,9 +555,7 @@ igt_main
> > > igt_subtest_f("%s-rotation-%s",
> > > plane_test_str(subtest->plane),
> > > rot_test_str(subtest->rot)) {
> > > - igt_require(!(subtest->rot &
> > > - (IGT_ROTATION_90 |
> > > IGT_ROTATION_270)) ||
> > > - gen >= 9);
> > > + igt_require(igt_plane_get_prop(data.disp
> > > lay.pipes-
> > > >
> > > > planes,
> > > +IGT_PLANE_ROTATION) & subtest->rot);
> > Mika, Maarten,
> > Any comments?
> igt_plane_get_prop returns the current value, not all supported
> rotations. I've retried the patch series, but if it still doesn't run
> you'll see a lot of PASS change to SKIP.
What if we loop through all rotations and check this that way? Perhaps
use just igt_plane_has_prop() to do this and keep a list of supported
rotations.
-Mika-
>
> ~Maarten
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [i-g-t] tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require()
2018-02-14 11:39 ` Mika Kahola
@ 2018-02-14 17:57 ` Srivatsa, Anusha
0 siblings, 0 replies; 8+ messages in thread
From: Srivatsa, Anusha @ 2018-02-14 17:57 UTC (permalink / raw)
To: Kahola, Mika, Maarten Lankhorst, igt-dev
>-----Original Message-----
>From: Kahola, Mika
>Sent: Wednesday, February 14, 2018 3:40 AM
>To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>; Srivatsa, Anusha
><anusha.srivatsa@intel.com>; igt-dev@lists.freedesktop.org
>Subject: Re: [i-g-t] tests/kms_rotation_crc: Remove hardcoding of platforms in
>igt_require()
>
>On Wed, 2018-02-14 at 10:08 +0100, Maarten Lankhorst wrote:
>> Op 14-02-18 om 08:40 schreef Srivatsa, Anusha:
>> >
>> >
>> > >
>> > > -----Original Message-----
>> > > From: Srivatsa, Anusha
>> > > Sent: Tuesday, February 13, 2018 5:09 PM
>> > > To: igt-dev@lists.freedesktop.org
>> > > Cc: Srivatsa, Anusha <anusha.srivatsa@intel.com>; Sripada,
>> > > Radhakrishna <radhakrishna.sripada@intel.com>; Vetter, Daniel
>> > > <daniel.vetter@i ntel.com>; Vivi, Rodrigo
>> > > <rodrigo.vivi@intel.com>; Maarten Lankhorst
>> > > <maarten.lankhorst@linux.intel.com>; Kahola, Mika <mika.kahola@in
>> > > tel.com>
>> > > Subject: [i-g-t] tests/kms_rotation_crc: Remove hardcoding of
>> > > platforms in
>> > > igt_require()
>> > >
>> > > Rework the rotate and reflect subtests by checking the crtc
>> > > supported properties against the ones that the test is testing.
>> > > Remove the hardcoded platform names in
>> > > igt_require()
>> > >
>> > > Cc: Radhakrishna Sripad <radhakrishna.sripada@intel.com>
>> > > Cc: Daniel Vetter <daniel.vetter@intel.com>
>> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> > > Cc: Mika Kahola <mika.kahola@intel.com>
>> > > Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> > > ---
>> > > tests/kms_rotation_crc.c | 12 +++---------
>> > > 1 file changed, 3 insertions(+), 9 deletions(-)
>> > >
>> > > diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
>> > > index
>> > > 0cd5c6e..49d57a2 100644
>> > > --- a/tests/kms_rotation_crc.c
>> > > +++ b/tests/kms_rotation_crc.c
>> > > @@ -373,9 +373,6 @@ static void test_plane_rotation(data_t *data,
>> > > int plane_type, bool test_bad_form
>> > > igt_plane_t *plane;
>> > > int i, j;
>> > >
>> > > - if (IS_CHERRYVIEW(data->devid) && pipe !=
>> > > PIPE_B)
>> > > - continue;
>> > > -
>> > > igt_output_set_pipe(output, pipe);
>> > >
>> > > plane = igt_output_get_plane_type(output, plane_type); @@ -
>> > > 558,9 +555,7 @@ igt_main
>> > > igt_subtest_f("%s-rotation-%s",
>> > > plane_test_str(subtest->plane),
>> > > rot_test_str(subtest->rot)) {
>> > > - igt_require(!(subtest->rot &
>> > > - (IGT_ROTATION_90 |
>> > > IGT_ROTATION_270)) ||
>> > > - gen >= 9);
>> > > + igt_require(igt_plane_get_prop(data.disp
>> > > lay.pipes-
>> > > >
>> > > > planes,
>> > > +IGT_PLANE_ROTATION) & subtest->rot);
>> > Mika, Maarten,
>> > Any comments?
>> igt_plane_get_prop returns the current value, not all supported
>> rotations. I've retried the patch series, but if it still doesn't run
>> you'll see a lot of PASS change to SKIP.
>What if we loop through all rotations and check this that way? Perhaps use just
>igt_plane_has_prop() to do this and keep a list of supported rotations.
>
Igt_plane_has_prop() will just tell if property exists...but what we need Is the value/metadata of the property so igt_plane_has_prop() will not be enough..
Anusha
>-Mika-
>
>>
>> ~Maarten
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-02-14 17:57 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-14 1:09 [igt-dev] [i-g-t] tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require() Anusha Srivatsa
2018-02-14 2:01 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2018-02-14 7:40 ` [igt-dev] [i-g-t] " Srivatsa, Anusha
2018-02-14 9:08 ` Maarten Lankhorst
2018-02-14 11:39 ` Mika Kahola
2018-02-14 17:57 ` Srivatsa, Anusha
2018-02-14 9:15 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-02-14 11:16 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.