From: Sakari Ailus <sakari.ailus@iki.fi> To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Hans Verkuil <hans.verkuil@cisco.com>, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v2] videodev2.h: add helper to validate colorspace Date: Wed, 14 Feb 2018 12:49:19 +0200 [thread overview] Message-ID: <20180214104919.v74e7yprumsnh3cu@valkosipuli.retiisi.org.uk> (raw) In-Reply-To: <20180214103643.8245-1-niklas.soderlund+renesas@ragnatech.se> On Wed, Feb 14, 2018 at 11:36:43AM +0100, Niklas Söderlund wrote: > There is no way for drivers to validate a colorspace value, which could > be provided by user-space by VIDIOC_S_FMT for example. Add a helper to > validate that the colorspace value is part of enum v4l2_colorspace. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> > --- > include/uapi/linux/videodev2.h | 4 ++++ > 1 file changed, 4 insertions(+) > > Hi, > > I hope this is the correct header to add this helper to. I think it's > since if it's in uapi not only can v4l2 drivers use it but tools like > v4l-compliance gets access to it and can be updated to use this instead > of the hard-coded check of just < 0xff as it was last time I checked. > > * Changes since v1 > - Cast colorspace to u32 as suggested by Sakari and only check the upper > boundary to address a potential issue brought up by Laurent if the > data type tested is u32 which is not uncommon: > > enum.c:30:16: warning: comparison of unsigned expression >= 0 is always true > [-Wtype-limits] > return V4L2_COLORSPACE_IS_VALID(colorspace); > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index 9827189651801e12..1f27c0f4187cbded 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -238,6 +238,10 @@ enum v4l2_colorspace { > V4L2_COLORSPACE_DCI_P3 = 12, > }; > > +/* Determine if a colorspace is defined in enum v4l2_colorspace */ > +#define V4L2_COLORSPACE_IS_VALID(colorspace) \ > + ((u32)(colorspace) <= V4L2_COLORSPACE_DCI_P3) > + > /* > * Determine how COLORSPACE_DEFAULT should map to a proper colorspace. > * This depends on whether this is a SDTV image (use SMPTE 170M), an > -- > 2.16.1 > -- Sakari Ailus e-mail: sakari.ailus@iki.fi
WARNING: multiple messages have this Message-ID (diff)
From: Sakari Ailus <sakari.ailus@iki.fi> To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Hans Verkuil <hans.verkuil@cisco.com>, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v2] videodev2.h: add helper to validate colorspace Date: Wed, 14 Feb 2018 12:49:19 +0200 [thread overview] Message-ID: <20180214104919.v74e7yprumsnh3cu@valkosipuli.retiisi.org.uk> (raw) In-Reply-To: <20180214103643.8245-1-niklas.soderlund+renesas@ragnatech.se> On Wed, Feb 14, 2018 at 11:36:43AM +0100, Niklas S�derlund wrote: > There is no way for drivers to validate a colorspace value, which could > be provided by user-space by VIDIOC_S_FMT for example. Add a helper to > validate that the colorspace value is part of enum v4l2_colorspace. > > Signed-off-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> > --- > include/uapi/linux/videodev2.h | 4 ++++ > 1 file changed, 4 insertions(+) > > Hi, > > I hope this is the correct header to add this helper to. I think it's > since if it's in uapi not only can v4l2 drivers use it but tools like > v4l-compliance gets access to it and can be updated to use this instead > of the hard-coded check of just < 0xff as it was last time I checked. > > * Changes since v1 > - Cast colorspace to u32 as suggested by Sakari and only check the upper > boundary to address a potential issue brought up by Laurent if the > data type tested is u32 which is not uncommon: > > enum.c:30:16: warning: comparison of unsigned expression >= 0 is always true > [-Wtype-limits] > return V4L2_COLORSPACE_IS_VALID(colorspace); > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index 9827189651801e12..1f27c0f4187cbded 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -238,6 +238,10 @@ enum v4l2_colorspace { > V4L2_COLORSPACE_DCI_P3 = 12, > }; > > +/* Determine if a colorspace is defined in enum v4l2_colorspace */ > +#define V4L2_COLORSPACE_IS_VALID(colorspace) \ > + ((u32)(colorspace) <= V4L2_COLORSPACE_DCI_P3) > + > /* > * Determine how COLORSPACE_DEFAULT should map to a proper colorspace. > * This depends on whether this is a SDTV image (use SMPTE 170M), an > -- > 2.16.1 > -- Sakari Ailus e-mail: sakari.ailus@iki.fi
next prev parent reply other threads:[~2018-02-14 10:49 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-14 10:36 [PATCH v2] videodev2.h: add helper to validate colorspace Niklas Söderlund 2018-02-14 10:49 ` Sakari Ailus [this message] 2018-02-14 10:49 ` Sakari Ailus 2018-02-14 15:16 ` Laurent Pinchart 2018-02-15 10:57 ` Hans Verkuil 2018-02-15 11:08 ` Laurent Pinchart 2018-02-15 11:56 ` Hans Verkuil 2018-02-15 12:06 ` Laurent Pinchart 2018-02-15 12:32 ` Hans Verkuil 2018-02-15 12:48 ` Hans Verkuil 2018-02-15 13:06 ` Laurent Pinchart 2018-02-19 22:28 ` Niklas Söderlund 2018-02-19 22:28 ` Niklas Söderlund 2018-02-20 8:37 ` Hans Verkuil 2018-02-21 20:16 ` Laurent Pinchart 2018-02-21 21:01 ` Sakari Ailus 2018-02-22 8:01 ` Hans Verkuil 2018-02-22 12:41 ` Laurent Pinchart 2018-02-22 7:38 ` Hans Verkuil 2018-02-22 12:43 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180214104919.v74e7yprumsnh3cu@valkosipuli.retiisi.org.uk \ --to=sakari.ailus@iki.fi \ --cc=hans.verkuil@cisco.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-media@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=niklas.soderlund+renesas@ragnatech.se \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.