* [PATCH] PCI: xgene: Fix the error return code
@ 2017-12-20 0:38 Fabio Estevam
2017-12-20 12:14 ` Lorenzo Pieralisi
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2017-12-20 0:38 UTC (permalink / raw)
To: bhelgaas; +Cc: dhdang, linux-pci, Fabio Estevam
In the case of IS_ERR() error, we should return PTR_ERR().
Fix the error return code.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
drivers/pci/host/pci-xgene-msi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/pci-xgene-msi.c b/drivers/pci/host/pci-xgene-msi.c
index 1f42a20..4a1fb01 100644
--- a/drivers/pci/host/pci-xgene-msi.c
+++ b/drivers/pci/host/pci-xgene-msi.c
@@ -465,7 +465,7 @@ static int xgene_msi_probe(struct platform_device *pdev)
xgene_msi->msi_regs = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(xgene_msi->msi_regs)) {
dev_err(&pdev->dev, "no reg space\n");
- rc = -EINVAL;
+ rc = PTR_ERR(xgene_msi->msi_regs);
goto error;
}
xgene_msi->msi_addr = res->start;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: xgene: Fix the error return code
2017-12-20 0:38 [PATCH] PCI: xgene: Fix the error return code Fabio Estevam
@ 2017-12-20 12:14 ` Lorenzo Pieralisi
2018-02-14 1:45 ` Fabio Estevam
0 siblings, 1 reply; 4+ messages in thread
From: Lorenzo Pieralisi @ 2017-12-20 12:14 UTC (permalink / raw)
To: Fabio Estevam, kdinh; +Cc: bhelgaas, dhdang, linux-pci
[+ Khuong Dinh]
On Tue, Dec 19, 2017 at 10:38:29PM -0200, Fabio Estevam wrote:
> In the case of IS_ERR() error, we should return PTR_ERR().
>
> Fix the error return code.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> drivers/pci/host/pci-xgene-msi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I am about to apply this patch, please let me know if you see
any issue with that.
Thanks,
Lorenzo
> diff --git a/drivers/pci/host/pci-xgene-msi.c b/drivers/pci/host/pci-xgene-msi.c
> index 1f42a20..4a1fb01 100644
> --- a/drivers/pci/host/pci-xgene-msi.c
> +++ b/drivers/pci/host/pci-xgene-msi.c
> @@ -465,7 +465,7 @@ static int xgene_msi_probe(struct platform_device *pdev)
> xgene_msi->msi_regs = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(xgene_msi->msi_regs)) {
> dev_err(&pdev->dev, "no reg space\n");
> - rc = -EINVAL;
> + rc = PTR_ERR(xgene_msi->msi_regs);
> goto error;
> }
> xgene_msi->msi_addr = res->start;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: xgene: Fix the error return code
2017-12-20 12:14 ` Lorenzo Pieralisi
@ 2018-02-14 1:45 ` Fabio Estevam
2018-02-14 15:32 ` Lorenzo Pieralisi
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2018-02-14 1:45 UTC (permalink / raw)
To: Lorenzo Pieralisi; +Cc: kdinh, Bjorn Helgaas, dhdang, linux-pci
Khuong Dinh, Lorenzo,
On Wed, Dec 20, 2017 at 10:14 AM, Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
> [+ Khuong Dinh]
>
> On Tue, Dec 19, 2017 at 10:38:29PM -0200, Fabio Estevam wrote:
>> In the case of IS_ERR() error, we should return PTR_ERR().
>>
>> Fix the error return code.
>>
>> Signed-off-by: Fabio Estevam <festevam@gmail.com>
>> ---
>> drivers/pci/host/pci-xgene-msi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I am about to apply this patch, please let me know if you see
> any issue with that.
A gente ping.
>
> Thanks,
> Lorenzo
>
>> diff --git a/drivers/pci/host/pci-xgene-msi.c b/drivers/pci/host/pci-xgene-msi.c
>> index 1f42a20..4a1fb01 100644
>> --- a/drivers/pci/host/pci-xgene-msi.c
>> +++ b/drivers/pci/host/pci-xgene-msi.c
>> @@ -465,7 +465,7 @@ static int xgene_msi_probe(struct platform_device *pdev)
>> xgene_msi->msi_regs = devm_ioremap_resource(&pdev->dev, res);
>> if (IS_ERR(xgene_msi->msi_regs)) {
>> dev_err(&pdev->dev, "no reg space\n");
>> - rc = -EINVAL;
>> + rc = PTR_ERR(xgene_msi->msi_regs);
>> goto error;
>> }
>> xgene_msi->msi_addr = res->start;
>> --
>> 2.7.4
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: xgene: Fix the error return code
2018-02-14 1:45 ` Fabio Estevam
@ 2018-02-14 15:32 ` Lorenzo Pieralisi
0 siblings, 0 replies; 4+ messages in thread
From: Lorenzo Pieralisi @ 2018-02-14 15:32 UTC (permalink / raw)
To: Fabio Estevam; +Cc: kdinh, Bjorn Helgaas, dhdang, linux-pci
On Tue, Feb 13, 2018 at 11:45:15PM -0200, Fabio Estevam wrote:
> Khuong Dinh, Lorenzo,
>
> On Wed, Dec 20, 2017 at 10:14 AM, Lorenzo Pieralisi
> <lorenzo.pieralisi@arm.com> wrote:
> > [+ Khuong Dinh]
> >
> > On Tue, Dec 19, 2017 at 10:38:29PM -0200, Fabio Estevam wrote:
> >> In the case of IS_ERR() error, we should return PTR_ERR().
> >>
> >> Fix the error return code.
> >>
> >> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> >> ---
> >> drivers/pci/host/pci-xgene-msi.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > I am about to apply this patch, please let me know if you see
> > any issue with that.
>
> A gente ping.
Applied to pci/xgene for v4.17, sorry for the delay.
Lorenzo
> > Thanks,
> > Lorenzo
> >
> >> diff --git a/drivers/pci/host/pci-xgene-msi.c b/drivers/pci/host/pci-xgene-msi.c
> >> index 1f42a20..4a1fb01 100644
> >> --- a/drivers/pci/host/pci-xgene-msi.c
> >> +++ b/drivers/pci/host/pci-xgene-msi.c
> >> @@ -465,7 +465,7 @@ static int xgene_msi_probe(struct platform_device *pdev)
> >> xgene_msi->msi_regs = devm_ioremap_resource(&pdev->dev, res);
> >> if (IS_ERR(xgene_msi->msi_regs)) {
> >> dev_err(&pdev->dev, "no reg space\n");
> >> - rc = -EINVAL;
> >> + rc = PTR_ERR(xgene_msi->msi_regs);
> >> goto error;
> >> }
> >> xgene_msi->msi_addr = res->start;
> >> --
> >> 2.7.4
> >>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-14 15:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-20 0:38 [PATCH] PCI: xgene: Fix the error return code Fabio Estevam
2017-12-20 12:14 ` Lorenzo Pieralisi
2018-02-14 1:45 ` Fabio Estevam
2018-02-14 15:32 ` Lorenzo Pieralisi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.