* [PATCH xf86-video-amdgpu] Revert "Guard against pAMDGPUEnt == NULL in AMDGPUFreeRec"
@ 2018-02-14 18:08 Michel Dänzer
[not found] ` <20180214180849.6069-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Michel Dänzer @ 2018-02-14 18:08 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
From: Michel Dänzer <michel.daenzer@amd.com>
This reverts commit a23d1ff700d486138c624c2023d8d251c73709af.
pAMDGPUEnt cannot be NULL anymore here now that we no longer call
AMDGPUFreeRec directly from AMDGPUPreInit_KMS.
Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
---
src/amdgpu_kms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amdgpu_kms.c b/src/amdgpu_kms.c
index f5874d3af..15adb2938 100644
--- a/src/amdgpu_kms.c
+++ b/src/amdgpu_kms.c
@@ -137,7 +137,7 @@ static void AMDGPUFreeRec(ScrnInfoPtr pScrn)
pPriv = xf86GetEntityPrivate(pEnt->index, gAMDGPUEntityIndex);
pAMDGPUEnt = pPriv->ptr;
- if (pAMDGPUEnt && pAMDGPUEnt->fd > 0) {
+ if (pAMDGPUEnt->fd > 0) {
DevUnion *pPriv;
AMDGPUEntPtr pAMDGPUEnt;
pPriv = xf86GetEntityPrivate(pScrn->entityList[0],
--
2.16.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH xf86-video-amdgpu] Revert "Guard against pAMDGPUEnt == NULL in AMDGPUFreeRec"
[not found] ` <20180214180849.6069-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org>
@ 2018-02-14 18:22 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2018-02-14 18:22 UTC (permalink / raw)
To: Michel Dänzer; +Cc: amd-gfx list
On Wed, Feb 14, 2018 at 1:08 PM, Michel Dänzer <michel@daenzer.net> wrote:
> From: Michel Dänzer <michel.daenzer@amd.com>
>
> This reverts commit a23d1ff700d486138c624c2023d8d251c73709af.
>
> pAMDGPUEnt cannot be NULL anymore here now that we no longer call
> AMDGPUFreeRec directly from AMDGPUPreInit_KMS.
>
> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> src/amdgpu_kms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amdgpu_kms.c b/src/amdgpu_kms.c
> index f5874d3af..15adb2938 100644
> --- a/src/amdgpu_kms.c
> +++ b/src/amdgpu_kms.c
> @@ -137,7 +137,7 @@ static void AMDGPUFreeRec(ScrnInfoPtr pScrn)
>
> pPriv = xf86GetEntityPrivate(pEnt->index, gAMDGPUEntityIndex);
> pAMDGPUEnt = pPriv->ptr;
> - if (pAMDGPUEnt && pAMDGPUEnt->fd > 0) {
> + if (pAMDGPUEnt->fd > 0) {
> DevUnion *pPriv;
> AMDGPUEntPtr pAMDGPUEnt;
> pPriv = xf86GetEntityPrivate(pScrn->entityList[0],
> --
> 2.16.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-14 18:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-14 18:08 [PATCH xf86-video-amdgpu] Revert "Guard against pAMDGPUEnt == NULL in AMDGPUFreeRec" Michel Dänzer
[not found] ` <20180214180849.6069-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org>
2018-02-14 18:22 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.