All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH] drm/i915: fix rsvd2 mask when out-fence is returned
Date: Wed, 14 Feb 2018 11:18:25 -0800	[thread overview]
Message-ID: <20180214191827.8465-1-daniele.ceraolospurio@intel.com> (raw)

GENMASK_ULL wants the high bit of the mask first. The current value
cancels the in-fence when an out-fence is returned

Fixes: fec0445caa273 ("drm/i915: Support explicit fencing for execbuf")
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
---
 drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
index b15305f2fb76..ed6e9db51e67 100644
--- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
@@ -2410,7 +2410,7 @@ i915_gem_do_execbuffer(struct drm_device *dev,
 	if (out_fence) {
 		if (err == 0) {
 			fd_install(out_fence_fd, out_fence->file);
-			args->rsvd2 &= GENMASK_ULL(0, 31); /* keep in-fence */
+			args->rsvd2 &= GENMASK_ULL(31, 0); /* keep in-fence */
 			args->rsvd2 |= (u64)out_fence_fd << 32;
 			out_fence_fd = -1;
 		} else {
-- 
2.16.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2018-02-14 19:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14 19:18 Daniele Ceraolo Spurio [this message]
2018-02-14 19:18 ` [PATCH i-g-t] tests/gem_exec_fence: test that in-fence is not overwritten Daniele Ceraolo Spurio
2018-02-14 19:29   ` Chris Wilson
2018-02-14 19:34     ` Chris Wilson
2018-02-14 19:24 ` [PATCH] drm/i915: fix rsvd2 mask when out-fence is returned Chris Wilson
2018-02-14 20:49 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-02-14 21:45 ` [PATCH] " Chris Wilson
2018-02-14 23:00 ` ✗ Fi.CI.BAT: failure for tests/gem_exec_fence: test that in-fence is not overwritten Patchwork
2018-02-15  4:55 ` ✓ Fi.CI.IGT: success for drm/i915: fix rsvd2 mask when out-fence is returned Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180214191827.8465-1-daniele.ceraolospurio@intel.com \
    --to=daniele.ceraolospurio@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.