From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH i-g-t] tests/gem_exec_fence: test that in-fence is not overwritten
Date: Wed, 14 Feb 2018 11:18:26 -0800 [thread overview]
Message-ID: <20180214191827.8465-2-daniele.ceraolospurio@intel.com> (raw)
In-Reply-To: <20180214191827.8465-1-daniele.ceraolospurio@intel.com>
When an out-fence is returned we expect that the in-fence is not
overwritten. Add a test to check for that.
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
---
tests/gem_exec_fence.c | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/tests/gem_exec_fence.c b/tests/gem_exec_fence.c
index bd7b1263..f7478c55 100644
--- a/tests/gem_exec_fence.c
+++ b/tests/gem_exec_fence.c
@@ -586,6 +586,42 @@ static void test_parallel(int fd, unsigned int master)
gem_close(fd, handle[0]);
}
+/* check that a fence in doesn't get clobbered when a fence out is returned */
+static void test_keep_fence_in(int fd, unsigned int engine)
+{
+ struct drm_i915_gem_execbuffer2 execbuf;
+ struct drm_i915_gem_exec_object2 obj;
+ const uint32_t bbe = MI_BATCH_BUFFER_END;
+ int fence;
+
+ memset(&obj, 0, sizeof(obj));
+ memset(&execbuf, 0, sizeof(execbuf));
+
+ obj.handle = gem_create(fd, 4096);
+ gem_write(fd, obj.handle, 0, &bbe, sizeof(bbe));
+
+ execbuf.buffers_ptr = to_user_pointer(&obj);
+ execbuf.buffer_count = 1;
+ execbuf.flags = engine | LOCAL_EXEC_FENCE_OUT;
+
+ gem_execbuf_wr(fd, &execbuf);
+ fence = execbuf.rsvd2 >> 32;
+
+ gem_close(fd, obj.handle);
+ obj.handle = gem_create(fd, 4096);
+ gem_write(fd, obj.handle, 0, &bbe, sizeof(bbe));
+
+ execbuf.flags |= LOCAL_EXEC_FENCE_IN;
+ execbuf.rsvd2 = fence;
+
+ gem_execbuf_wr(fd, &execbuf);
+ igt_assert_eq(fence, execbuf.rsvd2 & 0xFFFFFFFF);
+
+ gem_close(fd, obj.handle);
+ close(fence);
+ close(execbuf.rsvd2 >> 32);
+}
+
#define EXPIRED 0x10000
static void test_long_history(int fd, long ring_size, unsigned flags)
{
@@ -1499,6 +1535,9 @@ igt_main
}
}
+ igt_subtest_f("keep-fence-in-%s", e->name)
+ test_keep_fence_in(i915, e->exec_id | e->flags);
+
igt_fixture {
igt_stop_hang_detector();
}
--
2.16.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-02-14 19:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 19:18 [PATCH] drm/i915: fix rsvd2 mask when out-fence is returned Daniele Ceraolo Spurio
2018-02-14 19:18 ` Daniele Ceraolo Spurio [this message]
2018-02-14 19:29 ` [PATCH i-g-t] tests/gem_exec_fence: test that in-fence is not overwritten Chris Wilson
2018-02-14 19:34 ` Chris Wilson
2018-02-14 19:24 ` [PATCH] drm/i915: fix rsvd2 mask when out-fence is returned Chris Wilson
2018-02-14 20:49 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-02-14 21:45 ` [PATCH] " Chris Wilson
2018-02-14 23:00 ` ✗ Fi.CI.BAT: failure for tests/gem_exec_fence: test that in-fence is not overwritten Patchwork
2018-02-15 4:55 ` ✓ Fi.CI.IGT: success for drm/i915: fix rsvd2 mask when out-fence is returned Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214191827.8465-2-daniele.ceraolospurio@intel.com \
--to=daniele.ceraolospurio@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.