* [ulf.hansson-mmc:next 6/19] drivers/mmc/host/sdhci-omap.c:466:8: error: implicit declaration of function 'pinctrl_select_state'; did you mean 'node_set_state'?
@ 2018-02-14 12:22 kbuild test robot
2018-02-15 6:46 ` Ulf Hansson
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2018-02-14 12:22 UTC (permalink / raw)
To: Kishon Vijay Abraham I; +Cc: kbuild-all, linux-mmc, Ulf Hansson
[-- Attachment #1: Type: text/plain, Size: 3477 bytes --]
tree: git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git next
head: 779e209cefc2ef7da86f79894bc1988bc38b048a
commit: 713190bb14aaa6113fd54416fa909028e550fb08 [6/19] mmc: sdhci_omap: Add support to set IODELAY values
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 713190bb14aaa6113fd54416fa909028e550fb08
# save the attached .config to linux build tree
make.cross ARCH=sh
All error/warnings (new ones prefixed by >>):
drivers/mmc/host/sdhci-omap.c: In function 'sdhci_omap_set_timing':
>> drivers/mmc/host/sdhci-omap.c:466:8: error: implicit declaration of function 'pinctrl_select_state'; did you mean 'node_set_state'? [-Werror=implicit-function-declaration]
ret = pinctrl_select_state(omap_host->pinctrl, pinctrl_state);
^~~~~~~~~~~~~~~~~~~~
node_set_state
drivers/mmc/host/sdhci-omap.c: In function 'sdhci_omap_iodelay_pinctrl_state':
>> drivers/mmc/host/sdhci-omap.c:740:18: error: implicit declaration of function 'pinctrl_lookup_state'; did you mean 'inc_zone_state'? [-Werror=implicit-function-declaration]
pinctrl_state = pinctrl_lookup_state(omap_host->pinctrl, mode);
^~~~~~~~~~~~~~~~~~~~
inc_zone_state
>> drivers/mmc/host/sdhci-omap.c:740:16: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
pinctrl_state = pinctrl_lookup_state(omap_host->pinctrl, mode);
^
drivers/mmc/host/sdhci-omap.c: In function 'sdhci_omap_config_iodelay_pinctrl_state':
>> drivers/mmc/host/sdhci-omap.c:769:23: error: implicit declaration of function 'devm_pinctrl_get'; did you mean 'devm_clk_get'? [-Werror=implicit-function-declaration]
omap_host->pinctrl = devm_pinctrl_get(omap_host->dev);
^~~~~~~~~~~~~~~~
devm_clk_get
drivers/mmc/host/sdhci-omap.c:769:21: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
omap_host->pinctrl = devm_pinctrl_get(omap_host->dev);
^
drivers/mmc/host/sdhci-omap.c:775:8: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
state = pinctrl_lookup_state(omap_host->pinctrl, "default");
^
cc1: some warnings being treated as errors
vim +466 drivers/mmc/host/sdhci-omap.c
450
451 static void sdhci_omap_set_timing(struct sdhci_omap_host *omap_host, u8 timing)
452 {
453 int ret;
454 struct pinctrl_state *pinctrl_state;
455 struct device *dev = omap_host->dev;
456
457 if (!(omap_host->flags & SDHCI_OMAP_REQUIRE_IODELAY))
458 return;
459
460 if (omap_host->timing == timing)
461 return;
462
463 sdhci_omap_stop_clock(omap_host);
464
465 pinctrl_state = omap_host->pinctrl_state[timing];
> 466 ret = pinctrl_select_state(omap_host->pinctrl, pinctrl_state);
467 if (ret) {
468 dev_err(dev, "failed to select pinctrl state\n");
469 return;
470 }
471
472 sdhci_omap_start_clock(omap_host);
473 omap_host->timing = timing;
474 }
475
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 48089 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [ulf.hansson-mmc:next 6/19] drivers/mmc/host/sdhci-omap.c:466:8: error: implicit declaration of function 'pinctrl_select_state'; did you mean 'node_set_state'?
2018-02-14 12:22 [ulf.hansson-mmc:next 6/19] drivers/mmc/host/sdhci-omap.c:466:8: error: implicit declaration of function 'pinctrl_select_state'; did you mean 'node_set_state'? kbuild test robot
@ 2018-02-15 6:46 ` Ulf Hansson
2018-02-15 7:41 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 3+ messages in thread
From: Ulf Hansson @ 2018-02-15 6:46 UTC (permalink / raw)
To: Kishon Vijay Abraham I; +Cc: linux-mmc
On 14 February 2018 at 13:22, kbuild test robot <fengguang.wu@intel.com> wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git next
> head: 779e209cefc2ef7da86f79894bc1988bc38b048a
> commit: 713190bb14aaa6113fd54416fa909028e550fb08 [6/19] mmc: sdhci_omap: Add support to set IODELAY values
> config: sh-allmodconfig (attached as .config)
> compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout 713190bb14aaa6113fd54416fa909028e550fb08
> # save the attached .config to linux build tree
> make.cross ARCH=sh
>
> All error/warnings (new ones prefixed by >>):
>
> drivers/mmc/host/sdhci-omap.c: In function 'sdhci_omap_set_timing':
>>> drivers/mmc/host/sdhci-omap.c:466:8: error: implicit declaration of function 'pinctrl_select_state'; did you mean 'node_set_state'? [-Werror=implicit-function-declaration]
> ret = pinctrl_select_state(omap_host->pinctrl, pinctrl_state);
> ^~~~~~~~~~~~~~~~~~~~
> node_set_state
> drivers/mmc/host/sdhci-omap.c: In function 'sdhci_omap_iodelay_pinctrl_state':
>>> drivers/mmc/host/sdhci-omap.c:740:18: error: implicit declaration of function 'pinctrl_lookup_state'; did you mean 'inc_zone_state'? [-Werror=implicit-function-declaration]
> pinctrl_state = pinctrl_lookup_state(omap_host->pinctrl, mode);
> ^~~~~~~~~~~~~~~~~~~~
> inc_zone_state
>>> drivers/mmc/host/sdhci-omap.c:740:16: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> pinctrl_state = pinctrl_lookup_state(omap_host->pinctrl, mode);
> ^
> drivers/mmc/host/sdhci-omap.c: In function 'sdhci_omap_config_iodelay_pinctrl_state':
>>> drivers/mmc/host/sdhci-omap.c:769:23: error: implicit declaration of function 'devm_pinctrl_get'; did you mean 'devm_clk_get'? [-Werror=implicit-function-declaration]
> omap_host->pinctrl = devm_pinctrl_get(omap_host->dev);
> ^~~~~~~~~~~~~~~~
> devm_clk_get
> drivers/mmc/host/sdhci-omap.c:769:21: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> omap_host->pinctrl = devm_pinctrl_get(omap_host->dev);
> ^
> drivers/mmc/host/sdhci-omap.c:775:8: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> state = pinctrl_lookup_state(omap_host->pinctrl, "default");
> ^
> cc1: some warnings being treated as errors
>
> vim +466 drivers/mmc/host/sdhci-omap.c
>
> 450
> 451 static void sdhci_omap_set_timing(struct sdhci_omap_host *omap_host, u8 timing)
> 452 {
> 453 int ret;
> 454 struct pinctrl_state *pinctrl_state;
> 455 struct device *dev = omap_host->dev;
> 456
> 457 if (!(omap_host->flags & SDHCI_OMAP_REQUIRE_IODELAY))
> 458 return;
> 459
> 460 if (omap_host->timing == timing)
> 461 return;
> 462
> 463 sdhci_omap_stop_clock(omap_host);
> 464
> 465 pinctrl_state = omap_host->pinctrl_state[timing];
> > 466 ret = pinctrl_select_state(omap_host->pinctrl, pinctrl_state);
> 467 if (ret) {
> 468 dev_err(dev, "failed to select pinctrl state\n");
> 469 return;
> 470 }
> 471
> 472 sdhci_omap_start_clock(omap_host);
> 473 omap_host->timing = timing;
> 474 }
> 475
Kishon, no actions needed. I amended to offending commit by adding the
missing include file.
Kind regards
Uffe
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [ulf.hansson-mmc:next 6/19] drivers/mmc/host/sdhci-omap.c:466:8: error: implicit declaration of function 'pinctrl_select_state'; did you mean 'node_set_state'?
2018-02-15 6:46 ` Ulf Hansson
@ 2018-02-15 7:41 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 3+ messages in thread
From: Kishon Vijay Abraham I @ 2018-02-15 7:41 UTC (permalink / raw)
To: Ulf Hansson; +Cc: linux-mmc
On Thursday 15 February 2018 12:16 PM, Ulf Hansson wrote:
> On 14 February 2018 at 13:22, kbuild test robot <fengguang.wu@intel.com> wrote:
>> tree: git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git next
>> head: 779e209cefc2ef7da86f79894bc1988bc38b048a
>> commit: 713190bb14aaa6113fd54416fa909028e550fb08 [6/19] mmc: sdhci_omap: Add support to set IODELAY values
>> config: sh-allmodconfig (attached as .config)
>> compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
>> reproduce:
>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> git checkout 713190bb14aaa6113fd54416fa909028e550fb08
>> # save the attached .config to linux build tree
>> make.cross ARCH=sh
>>
>> All error/warnings (new ones prefixed by >>):
>>
>> drivers/mmc/host/sdhci-omap.c: In function 'sdhci_omap_set_timing':
>>>> drivers/mmc/host/sdhci-omap.c:466:8: error: implicit declaration of function 'pinctrl_select_state'; did you mean 'node_set_state'? [-Werror=implicit-function-declaration]
>> ret = pinctrl_select_state(omap_host->pinctrl, pinctrl_state);
>> ^~~~~~~~~~~~~~~~~~~~
>> node_set_state
>> drivers/mmc/host/sdhci-omap.c: In function 'sdhci_omap_iodelay_pinctrl_state':
>>>> drivers/mmc/host/sdhci-omap.c:740:18: error: implicit declaration of function 'pinctrl_lookup_state'; did you mean 'inc_zone_state'? [-Werror=implicit-function-declaration]
>> pinctrl_state = pinctrl_lookup_state(omap_host->pinctrl, mode);
>> ^~~~~~~~~~~~~~~~~~~~
>> inc_zone_state
>>>> drivers/mmc/host/sdhci-omap.c:740:16: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>> pinctrl_state = pinctrl_lookup_state(omap_host->pinctrl, mode);
>> ^
>> drivers/mmc/host/sdhci-omap.c: In function 'sdhci_omap_config_iodelay_pinctrl_state':
>>>> drivers/mmc/host/sdhci-omap.c:769:23: error: implicit declaration of function 'devm_pinctrl_get'; did you mean 'devm_clk_get'? [-Werror=implicit-function-declaration]
>> omap_host->pinctrl = devm_pinctrl_get(omap_host->dev);
>> ^~~~~~~~~~~~~~~~
>> devm_clk_get
>> drivers/mmc/host/sdhci-omap.c:769:21: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>> omap_host->pinctrl = devm_pinctrl_get(omap_host->dev);
>> ^
>> drivers/mmc/host/sdhci-omap.c:775:8: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>> state = pinctrl_lookup_state(omap_host->pinctrl, "default");
>> ^
>> cc1: some warnings being treated as errors
>>
>> vim +466 drivers/mmc/host/sdhci-omap.c
>>
>> 450
>> 451 static void sdhci_omap_set_timing(struct sdhci_omap_host *omap_host, u8 timing)
>> 452 {
>> 453 int ret;
>> 454 struct pinctrl_state *pinctrl_state;
>> 455 struct device *dev = omap_host->dev;
>> 456
>> 457 if (!(omap_host->flags & SDHCI_OMAP_REQUIRE_IODELAY))
>> 458 return;
>> 459
>> 460 if (omap_host->timing == timing)
>> 461 return;
>> 462
>> 463 sdhci_omap_stop_clock(omap_host);
>> 464
>> 465 pinctrl_state = omap_host->pinctrl_state[timing];
>> > 466 ret = pinctrl_select_state(omap_host->pinctrl, pinctrl_state);
>> 467 if (ret) {
>> 468 dev_err(dev, "failed to select pinctrl state\n");
>> 469 return;
>> 470 }
>> 471
>> 472 sdhci_omap_start_clock(omap_host);
>> 473 omap_host->timing = timing;
>> 474 }
>> 475
>
> Kishon, no actions needed. I amended to offending commit by adding the
> missing include file.
All right. Thanks!
Regards
Kishon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-15 7:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-14 12:22 [ulf.hansson-mmc:next 6/19] drivers/mmc/host/sdhci-omap.c:466:8: error: implicit declaration of function 'pinctrl_select_state'; did you mean 'node_set_state'? kbuild test robot
2018-02-15 6:46 ` Ulf Hansson
2018-02-15 7:41 ` Kishon Vijay Abraham I
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.