* [PATCH] Staging: comedi: fix camelcase issue in range.c
@ 2018-02-14 20:06 Yash Omer
2018-02-15 5:53 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Yash Omer @ 2018-02-14 20:06 UTC (permalink / raw)
To: gregkh; +Cc: driverdev-devel, Larry.Finger
This is a patch to the range.c file that fixes up a camelcase warning found by the checkpatch.pl tool.
Signed-off-by: Yash Omer <yashomer0007@gmail.com>
---
drivers/staging/comedi/range.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c
index 087bbde7bf12..ec128a6a70bb 100644
--- a/drivers/staging/comedi/range.c
+++ b/drivers/staging/comedi/range.c
@@ -24,7 +24,7 @@ EXPORT_SYMBOL_GPL(range_unipolar5);
const struct comedi_lrange range_unipolar2_5 = { 1, {UNI_RANGE(2.5)} };
EXPORT_SYMBOL_GPL(range_unipolar2_5);
const struct comedi_lrange RANGE_0_20m_A = { 1, {RANGE_m_A(0, 20)} };
-EXPORT_SYMBOL_GPL(range_0_20mA);
+EXPORT_SYMBOL_GPL(range_0_20m_A);
const struct comedi_lrange range_4_20mA = { 1, {RANGE_mA(4, 20)} };
EXPORT_SYMBOL_GPL(range_4_20mA);
const struct comedi_lrange RANGE_0_32m_A = { 1, {RANGE_mA(0, 32)} };
--
2.14.3
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: comedi: fix camelcase issue in range.c
2018-02-14 20:06 [PATCH] Staging: comedi: fix camelcase issue in range.c Yash Omer
@ 2018-02-15 5:53 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2018-02-15 5:53 UTC (permalink / raw)
To: Yash Omer; +Cc: driverdev-devel, Larry.Finger
On Thu, Feb 15, 2018 at 01:36:43AM +0530, Yash Omer wrote:
> This is a patch to the range.c file that fixes up a camelcase warning found by the checkpatch.pl tool.
>
> Signed-off-by: Yash Omer <yashomer0007@gmail.com>
> ---
> drivers/staging/comedi/range.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c
> index 087bbde7bf12..ec128a6a70bb 100644
> --- a/drivers/staging/comedi/range.c
> +++ b/drivers/staging/comedi/range.c
> @@ -24,7 +24,7 @@ EXPORT_SYMBOL_GPL(range_unipolar5);
> const struct comedi_lrange range_unipolar2_5 = { 1, {UNI_RANGE(2.5)} };
> EXPORT_SYMBOL_GPL(range_unipolar2_5);
> const struct comedi_lrange RANGE_0_20m_A = { 1, {RANGE_m_A(0, 20)} };
> -EXPORT_SYMBOL_GPL(range_0_20mA);
> +EXPORT_SYMBOL_GPL(range_0_20m_A);
That change really does not make that much sense, does it? Checkpatch
is a hint, you don't want to change wyat "mA" means, right?
And did you test-build this change? It should not work as-is :(
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-15 5:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-14 20:06 [PATCH] Staging: comedi: fix camelcase issue in range.c Yash Omer
2018-02-15 5:53 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.