* [PATCH] debian: add build-depends on pkg-config
@ 2018-02-15 6:51 Darrick J. Wong
2018-02-15 17:02 ` Eric Sandeen
0 siblings, 1 reply; 4+ messages in thread
From: Darrick J. Wong @ 2018-02-15 6:51 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs
From: Darrick J. Wong <darrick.wong@oracle.com>
Since the configure scripts now depend on pkg-config to autodetect where
systemd service files go, we need to list pkg-config as a build
dependency.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
debian/control | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/control b/debian/control
index 60fcc46..78720bd 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: admin
Priority: optional
Maintainer: XFS Development Team <linux-xfs@vger.kernel.org>
Uploaders: Nathan Scott <nathans@debian.org>, Anibal Monsalve Salazar <anibal@debian.org>
-Build-Depends: uuid-dev, dh-autoreconf, debhelper (>= 5), gettext, libtool, libreadline-gplv2-dev, libblkid-dev (>= 2.17), linux-libc-dev, libdevmapper-dev, libattr1-dev, libunistring-dev, dh-python
+Build-Depends: uuid-dev, dh-autoreconf, debhelper (>= 5), gettext, libtool, libreadline-gplv2-dev, libblkid-dev (>= 2.17), linux-libc-dev, libdevmapper-dev, libattr1-dev, libunistring-dev, dh-python, pkg-config
Standards-Version: 3.9.1
Homepage: https://xfs.wiki.kernel.org/
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] debian: add build-depends on pkg-config
2018-02-15 6:51 [PATCH] debian: add build-depends on pkg-config Darrick J. Wong
@ 2018-02-15 17:02 ` Eric Sandeen
[not found] ` <CAFMei7PkvECcgsuj610O=PsrbqYD3mw0Wnc-Z71n5PZFtRkLYg@mail.gmail.com>
2018-02-15 21:33 ` Dave Chinner
0 siblings, 2 replies; 4+ messages in thread
From: Eric Sandeen @ 2018-02-15 17:02 UTC (permalink / raw)
To: Darrick J. Wong, Eric Sandeen; +Cc: xfs, Nathan Scott
On 2/15/18 12:51 AM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Since the configure scripts now depend on pkg-config to autodetect where
> systemd service files go, we need to list pkg-config as a build
> dependency.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
I'd love to have a Debian-savvy person look over these things.
Nathan maybe? :)
Thanks,
-Eric
> ---
> debian/control | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/debian/control b/debian/control
> index 60fcc46..78720bd 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -3,7 +3,7 @@ Section: admin
> Priority: optional
> Maintainer: XFS Development Team <linux-xfs@vger.kernel.org>
> Uploaders: Nathan Scott <nathans@debian.org>, Anibal Monsalve Salazar <anibal@debian.org>
> -Build-Depends: uuid-dev, dh-autoreconf, debhelper (>= 5), gettext, libtool, libreadline-gplv2-dev, libblkid-dev (>= 2.17), linux-libc-dev, libdevmapper-dev, libattr1-dev, libunistring-dev, dh-python
> +Build-Depends: uuid-dev, dh-autoreconf, debhelper (>= 5), gettext, libtool, libreadline-gplv2-dev, libblkid-dev (>= 2.17), linux-libc-dev, libdevmapper-dev, libattr1-dev, libunistring-dev, dh-python, pkg-config
> Standards-Version: 3.9.1
> Homepage: https://xfs.wiki.kernel.org/
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] debian: add build-depends on pkg-config
[not found] ` <CAFMei7PkvECcgsuj610O=PsrbqYD3mw0Wnc-Z71n5PZFtRkLYg@mail.gmail.com>
@ 2018-02-15 21:11 ` Eric Sandeen
0 siblings, 0 replies; 4+ messages in thread
From: Eric Sandeen @ 2018-02-15 21:11 UTC (permalink / raw)
To: Nathan Scott; +Cc: Darrick J. Wong, Eric Sandeen, xfs
On 2/15/18 3:10 PM, Nathan Scott wrote:
>
>
> On Fri, Feb 16, 2018 at 4:02 AM, Eric Sandeen <sandeen@sandeen.net <mailto:sandeen@sandeen.net>> wrote:
>
> On 2/15/18 12:51 AM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com <mailto:darrick.wong@oracle.com>>
> >
> > Since the configure scripts now depend on pkg-config to autodetect where
> > systemd service files go, we need to list pkg-config as a build
> > dependency.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com <mailto:darrick.wong@oracle.com>>
>
> I'd love to have a Debian-savvy person look over these things.
>
> Nathan maybe? :)
>
>
> LGTM. Feel free to add
>
> Reviewed-by: Nathan Scott <nathans@debian.org <mailto:nathans@debian.org>>
>
> I also have a couple of other debian packaging tweaks I'd like to make, but
> no time this week - is the release pending immediately or is there any time
> early next week Eric? (else it can wait for next time of course)
Not immediately, if you'd like to fix some things next week I'll try to remember
to wait. :)
Thanks,
-Eric
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] debian: add build-depends on pkg-config
2018-02-15 17:02 ` Eric Sandeen
[not found] ` <CAFMei7PkvECcgsuj610O=PsrbqYD3mw0Wnc-Z71n5PZFtRkLYg@mail.gmail.com>
@ 2018-02-15 21:33 ` Dave Chinner
1 sibling, 0 replies; 4+ messages in thread
From: Dave Chinner @ 2018-02-15 21:33 UTC (permalink / raw)
To: Eric Sandeen; +Cc: Darrick J. Wong, Eric Sandeen, xfs, Nathan Scott
On Thu, Feb 15, 2018 at 11:02:12AM -0600, Eric Sandeen wrote:
> On 2/15/18 12:51 AM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Since the configure scripts now depend on pkg-config to autodetect where
> > systemd service files go, we need to list pkg-config as a build
> > dependency.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> I'd love to have a Debian-savvy person look over these things.
I hit this a couple of days ago doing a normal build and having
config fail due to a missing pkg-config package. The build-dep
update looks fine.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-15 21:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-15 6:51 [PATCH] debian: add build-depends on pkg-config Darrick J. Wong
2018-02-15 17:02 ` Eric Sandeen
[not found] ` <CAFMei7PkvECcgsuj610O=PsrbqYD3mw0Wnc-Z71n5PZFtRkLYg@mail.gmail.com>
2018-02-15 21:11 ` Eric Sandeen
2018-02-15 21:33 ` Dave Chinner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.