* [PATCH] gpu: ipu-v3: prg: fix device node leak in ipu_prg_lookup_by_phandle
@ 2018-02-15 14:35 Tobias Jordan
2018-02-19 14:15 ` Philipp Zabel
0 siblings, 1 reply; 3+ messages in thread
From: Tobias Jordan @ 2018-02-15 14:35 UTC (permalink / raw)
To: Philipp Zabel, dri-devel, linux-kernel; +Cc: sil2review
Before returning, call of_node_put() for the device node returned by
of_parse_phandle().
Fixes: ea9c260514c1 ("gpu: ipu-v3: add driver for Prefetch Resolve Gasket")
Signed-off-by: Tobias Jordan <Tobias.Jordan@elektrobit.com>
---
drivers/gpu/ipu-v3/ipu-prg.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/ipu-v3/ipu-prg.c b/drivers/gpu/ipu-v3/ipu-prg.c
index 067365c733c6..97b99500153d 100644
--- a/drivers/gpu/ipu-v3/ipu-prg.c
+++ b/drivers/gpu/ipu-v3/ipu-prg.c
@@ -102,11 +102,14 @@ ipu_prg_lookup_by_phandle(struct device *dev, const char *name, int ipu_id)
mutex_unlock(&ipu_prg_list_mutex);
device_link_add(dev, prg->dev, DL_FLAG_AUTOREMOVE);
prg->id = ipu_id;
+ of_node_put(prg_node);
return prg;
}
}
mutex_unlock(&ipu_prg_list_mutex);
+ of_node_put(prg_node);
+
return NULL;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpu: ipu-v3: prg: fix device node leak in ipu_prg_lookup_by_phandle
2018-02-15 14:35 [PATCH] gpu: ipu-v3: prg: fix device node leak in ipu_prg_lookup_by_phandle Tobias Jordan
@ 2018-02-19 14:15 ` Philipp Zabel
0 siblings, 0 replies; 3+ messages in thread
From: Philipp Zabel @ 2018-02-19 14:15 UTC (permalink / raw)
To: Tobias Jordan, dri-devel, linux-kernel; +Cc: sil2review
Hi Tobias,
On Thu, 2018-02-15 at 15:35 +0100, Tobias Jordan wrote:
> Before returning, call of_node_put() for the device node returned by
> of_parse_phandle().
>
> Fixes: ea9c260514c1 ("gpu: ipu-v3: add driver for Prefetch Resolve Gasket")
> Signed-off-by: Tobias Jordan <Tobias.Jordan@elektrobit.com>
> ---
> drivers/gpu/ipu-v3/ipu-prg.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/ipu-v3/ipu-prg.c b/drivers/gpu/ipu-v3/ipu-prg.c
> index 067365c733c6..97b99500153d 100644
> --- a/drivers/gpu/ipu-v3/ipu-prg.c
> +++ b/drivers/gpu/ipu-v3/ipu-prg.c
> @@ -102,11 +102,14 @@ ipu_prg_lookup_by_phandle(struct device *dev, const char *name, int ipu_id)
> mutex_unlock(&ipu_prg_list_mutex);
> device_link_add(dev, prg->dev, DL_FLAG_AUTOREMOVE);
> prg->id = ipu_id;
> + of_node_put(prg_node);
> return prg;
> }
> }
> mutex_unlock(&ipu_prg_list_mutex);
>
> + of_node_put(prg_node);
> +
> return NULL;
> }
>
Applied both to imx-drm/next, thank you.
regards
Philipp
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpu: ipu-v3: prg: fix device node leak in ipu_prg_lookup_by_phandle
@ 2018-02-19 14:15 ` Philipp Zabel
0 siblings, 0 replies; 3+ messages in thread
From: Philipp Zabel @ 2018-02-19 14:15 UTC (permalink / raw)
To: Tobias Jordan, dri-devel, linux-kernel; +Cc: sil2review
Hi Tobias,
On Thu, 2018-02-15 at 15:35 +0100, Tobias Jordan wrote:
> Before returning, call of_node_put() for the device node returned by
> of_parse_phandle().
>
> Fixes: ea9c260514c1 ("gpu: ipu-v3: add driver for Prefetch Resolve Gasket")
> Signed-off-by: Tobias Jordan <Tobias.Jordan@elektrobit.com>
> ---
> drivers/gpu/ipu-v3/ipu-prg.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/ipu-v3/ipu-prg.c b/drivers/gpu/ipu-v3/ipu-prg.c
> index 067365c733c6..97b99500153d 100644
> --- a/drivers/gpu/ipu-v3/ipu-prg.c
> +++ b/drivers/gpu/ipu-v3/ipu-prg.c
> @@ -102,11 +102,14 @@ ipu_prg_lookup_by_phandle(struct device *dev, const char *name, int ipu_id)
> mutex_unlock(&ipu_prg_list_mutex);
> device_link_add(dev, prg->dev, DL_FLAG_AUTOREMOVE);
> prg->id = ipu_id;
> + of_node_put(prg_node);
> return prg;
> }
> }
> mutex_unlock(&ipu_prg_list_mutex);
>
> + of_node_put(prg_node);
> +
> return NULL;
> }
>
Applied both to imx-drm/next, thank you.
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-19 14:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-15 14:35 [PATCH] gpu: ipu-v3: prg: fix device node leak in ipu_prg_lookup_by_phandle Tobias Jordan
2018-02-19 14:15 ` Philipp Zabel
2018-02-19 14:15 ` Philipp Zabel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.