* [PATCH] Makefile: remove *.spec from clean target
@ 2018-02-17 3:06 Todd Zullinger
2018-02-17 21:27 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Todd Zullinger @ 2018-02-17 3:06 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
Support for generating an rpm was dropped in ab214331cf ("Makefile: stop
pretending to support rpmbuild", 2016-04-04). We don't generate any
*.spec files so there is no need to clean them up.
Signed-off-by: Todd Zullinger <tmz@pobox.com>
---
I noticed this minor cruft today. Since we don't generate a
spec file, this is at best unneeded. At worst we could
wrongly delete a users spec file if they happened to be
working on it in their git clone and called make clean.
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index c56fdc14ca..d135f8baa1 100644
--- a/Makefile
+++ b/Makefile
@@ -2734,7 +2734,7 @@ clean: profile-clean coverage-clean
$(RM) $(TEST_PROGRAMS) $(NO_INSTALL)
$(RM) -r bin-wrappers $(dep_dirs)
$(RM) -r po/build/
- $(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo common-cmds.h $(ETAGS_TARGET) tags cscope*
+ $(RM) *.pyc *.pyo */*.pyc */*.pyo common-cmds.h $(ETAGS_TARGET) tags cscope*
$(RM) -r $(GIT_TARNAME) .doc-tmp-dir
$(RM) $(GIT_TARNAME).tar.gz git-core_$(GIT_VERSION)-*.tar.gz
$(RM) $(htmldocs).tar.gz $(manpages).tar.gz
--
2.16.2
--
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
A thing worth having is a thing worth cheating for.
-- W. C. Fields
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Makefile: remove *.spec from clean target
2018-02-17 3:06 [PATCH] Makefile: remove *.spec from clean target Todd Zullinger
@ 2018-02-17 21:27 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2018-02-17 21:27 UTC (permalink / raw)
To: Todd Zullinger; +Cc: git
Todd Zullinger <tmz@pobox.com> writes:
> Support for generating an rpm was dropped in ab214331cf ("Makefile: stop
> pretending to support rpmbuild", 2016-04-04). We don't generate any
> *.spec files so there is no need to clean them up.
>
> Signed-off-by: Todd Zullinger <tmz@pobox.com>
> ---
>
> I noticed this minor cruft today. Since we don't generate a
> spec file, this is at best unneeded. At worst we could
> wrongly delete a users spec file if they happened to be
> working on it in their git clone and called make clean.
Makes perfect sense. Thanks.
>
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index c56fdc14ca..d135f8baa1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2734,7 +2734,7 @@ clean: profile-clean coverage-clean
> $(RM) $(TEST_PROGRAMS) $(NO_INSTALL)
> $(RM) -r bin-wrappers $(dep_dirs)
> $(RM) -r po/build/
> - $(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo common-cmds.h $(ETAGS_TARGET) tags cscope*
> + $(RM) *.pyc *.pyo */*.pyc */*.pyo common-cmds.h $(ETAGS_TARGET) tags cscope*
> $(RM) -r $(GIT_TARNAME) .doc-tmp-dir
> $(RM) $(GIT_TARNAME).tar.gz git-core_$(GIT_VERSION)-*.tar.gz
> $(RM) $(htmldocs).tar.gz $(manpages).tar.gz
> --
> 2.16.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-17 21:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-17 3:06 [PATCH] Makefile: remove *.spec from clean target Todd Zullinger
2018-02-17 21:27 ` Junio C Hamano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.