All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dwmw@amazon.co.uk
Cc: sparclinux@vger.kernel.org, bhelgaas@google.com,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] sparc: Use generic pci_mmap_resource_range()
Date: Mon, 19 Feb 2018 09:49:51 -0500 (EST)	[thread overview]
Message-ID: <20180219.094951.2098243214524004486.davem@davemloft.net> (raw)
In-Reply-To: <1519045452-22645-1-git-send-email-dwmw@amazon.co.uk>

From: David Woodhouse <dwmw@amazon.co.uk>
Date: Mon, 19 Feb 2018 13:04:12 +0000

> Commit f719582435 ("PCI: Add pci_mmap_resource_range() and use it for
> ARM64") added this generic function with the intent of using it
> everywhere and ultimately killing the old arch-specific implementations.
> 
> Let's get on with that eradication...
> 
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>

David, the generic code is definitely doing different things.

For one, the sparc specific code allows mmap'ing any address range
within a PCI bus device.  The generic code does not allow that.

I know this was used by the X server and that's why the logic is
there.

So we can't just use the generic code without breaking things, sorry.

WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: dwmw@amazon.co.uk
Cc: sparclinux@vger.kernel.org, bhelgaas@google.com,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] sparc: Use generic pci_mmap_resource_range()
Date: Mon, 19 Feb 2018 14:49:51 +0000	[thread overview]
Message-ID: <20180219.094951.2098243214524004486.davem@davemloft.net> (raw)
In-Reply-To: <1519045452-22645-1-git-send-email-dwmw@amazon.co.uk>

From: David Woodhouse <dwmw@amazon.co.uk>
Date: Mon, 19 Feb 2018 13:04:12 +0000

> Commit f719582435 ("PCI: Add pci_mmap_resource_range() and use it for
> ARM64") added this generic function with the intent of using it
> everywhere and ultimately killing the old arch-specific implementations.
> 
> Let's get on with that eradication...
> 
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>

David, the generic code is definitely doing different things.

For one, the sparc specific code allows mmap'ing any address range
within a PCI bus device.  The generic code does not allow that.

I know this was used by the X server and that's why the logic is
there.

So we can't just use the generic code without breaking things, sorry.

  reply	other threads:[~2018-02-19 14:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-19 13:04 [PATCH] sparc: Use generic pci_mmap_resource_range() David Woodhouse
2018-02-19 13:04 ` David Woodhouse
2018-02-19 14:49 ` David Miller [this message]
2018-02-19 14:49   ` David Miller
2018-02-19 15:24   ` David Woodhouse
2018-02-19 15:30     ` David Miller
2018-02-19 15:30       ` David Miller
2018-02-28 23:08       ` Bjorn Helgaas
2018-02-28 23:08         ` Bjorn Helgaas
2018-03-01  3:28         ` David Miller
2018-03-01  3:28           ` David Miller
2018-03-01  3:28           ` David Miller
2018-03-01  6:53         ` David Woodhouse
2018-03-01  6:53           ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180219.094951.2098243214524004486.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bhelgaas@google.com \
    --cc=dwmw@amazon.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.