All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] wcn36xx: reduce verbosity of drivers messages
@ 2018-02-17 20:25 Ramon Fried
  2018-02-19  3:27 ` Bjorn Andersson
  2018-02-27  8:26 ` Kalle Valo
  0 siblings, 2 replies; 4+ messages in thread
From: Ramon Fried @ 2018-02-17 20:25 UTC (permalink / raw)
  To: kvalo, wcn36xx, linux-wireless; +Cc: Ramon Fried

Whenever the WLAN interface is started the FW
version and caps are printed, this info should appear as
debug info.

Signed-off-by: Ramon Fried <rfried@codeaurora.org>
---
 drivers/net/wireless/ath/wcn36xx/main.c | 2 +-
 drivers/net/wireless/ath/wcn36xx/smd.c  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
index ab5be6d2c691..8c2654075eb8 100644
--- a/drivers/net/wireless/ath/wcn36xx/main.c
+++ b/drivers/net/wireless/ath/wcn36xx/main.c
@@ -261,7 +261,7 @@ static void wcn36xx_feat_caps_info(struct wcn36xx *wcn)
 
 	for (i = 0; i < MAX_FEATURE_SUPPORTED; i++) {
 		if (get_feat_caps(wcn->fw_feat_caps, i))
-			wcn36xx_info("FW Cap %s\n", wcn36xx_get_cap_name(i));
+			wcn36xx_dbg(WCN36XX_DBG_MAC, "FW Cap %s\n", wcn36xx_get_cap_name(i));
 	}
 }
 
diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index 2a4871ca9c72..7c4d19b041bc 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -409,10 +409,10 @@ static int wcn36xx_smd_start_rsp(struct wcn36xx *wcn, void *buf, size_t len)
 	wcn->fw_minor = rsp->start_rsp_params.version.minor;
 	wcn->fw_major = rsp->start_rsp_params.version.major;
 
-	wcn36xx_info("firmware WLAN version '%s' and CRM version '%s'\n",
+	wcn36xx_dbg(WCN36XX_DBG_HAL, "firmware WLAN version '%s' and CRM version '%s'\n",
 		     wcn->wlan_version, wcn->crm_version);
 
-	wcn36xx_info("firmware API %u.%u.%u.%u, %u stations, %u bssids\n",
+	wcn36xx_dbg(WCN36XX_DBG_HAL, "firmware API %u.%u.%u.%u, %u stations, %u bssids\n",
 		     wcn->fw_major, wcn->fw_minor,
 		     wcn->fw_version, wcn->fw_revision,
 		     rsp->start_rsp_params.stations,
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] wcn36xx: reduce verbosity of drivers messages
  2018-02-17 20:25 [PATCH] wcn36xx: reduce verbosity of drivers messages Ramon Fried
@ 2018-02-19  3:27 ` Bjorn Andersson
  2018-02-27  8:26 ` Kalle Valo
  1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2018-02-19  3:27 UTC (permalink / raw)
  To: Ramon Fried; +Cc: kvalo, wcn36xx, linux-wireless

On Sat 17 Feb 12:25 PST 2018, Ramon Fried wrote:

> Whenever the WLAN interface is started the FW
> version and caps are printed, this info should appear as
> debug info.
> 
> Signed-off-by: Ramon Fried <rfried@codeaurora.org>

Looks reasonable,

Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] wcn36xx: reduce verbosity of drivers messages
  2018-02-17 20:25 [PATCH] wcn36xx: reduce verbosity of drivers messages Ramon Fried
  2018-02-19  3:27 ` Bjorn Andersson
@ 2018-02-27  8:26 ` Kalle Valo
       [not found]   ` <d2614854-478c-80d5-a3e0-b75442bb862c@codeaurora.org>
  1 sibling, 1 reply; 4+ messages in thread
From: Kalle Valo @ 2018-02-27  8:26 UTC (permalink / raw)
  To: Ramon Fried; +Cc: wcn36xx, linux-wireless

Ramon Fried <rfried@codeaurora.org> writes:

> Whenever the WLAN interface is started the FW
> version and caps are printed, this info should appear as
> debug info.
>
> Signed-off-by: Ramon Fried <rfried@codeaurora.org>
> ---
>  drivers/net/wireless/ath/wcn36xx/main.c | 2 +-
>  drivers/net/wireless/ath/wcn36xx/smd.c  | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
> index ab5be6d2c691..8c2654075eb8 100644
> --- a/drivers/net/wireless/ath/wcn36xx/main.c
> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> @@ -261,7 +261,7 @@ static void wcn36xx_feat_caps_info(struct wcn36xx *wcn)
>  
>  	for (i = 0; i < MAX_FEATURE_SUPPORTED; i++) {
>  		if (get_feat_caps(wcn->fw_feat_caps, i))
> -			wcn36xx_info("FW Cap %s\n", wcn36xx_get_cap_name(i));
> +			wcn36xx_dbg(WCN36XX_DBG_MAC, "FW Cap %s\n", wcn36xx_get_cap_name(i));
>  	}
>  }
>  
> diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
> index 2a4871ca9c72..7c4d19b041bc 100644
> --- a/drivers/net/wireless/ath/wcn36xx/smd.c
> +++ b/drivers/net/wireless/ath/wcn36xx/smd.c
> @@ -409,10 +409,10 @@ static int wcn36xx_smd_start_rsp(struct wcn36xx *wcn, void *buf, size_t len)
>  	wcn->fw_minor = rsp->start_rsp_params.version.minor;
>  	wcn->fw_major = rsp->start_rsp_params.version.major;
>  
> -	wcn36xx_info("firmware WLAN version '%s' and CRM version '%s'\n",
> +	wcn36xx_dbg(WCN36XX_DBG_HAL, "firmware WLAN version '%s' and CRM version '%s'\n",
>  		     wcn->wlan_version, wcn->crm_version);
>  
> -	wcn36xx_info("firmware API %u.%u.%u.%u, %u stations, %u bssids\n",
> +	wcn36xx_dbg(WCN36XX_DBG_HAL, "firmware API %u.%u.%u.%u, %u stations, %u bssids\n",
>  		     wcn->fw_major, wcn->fw_minor,
>  		     wcn->fw_version, wcn->fw_revision,
>  		     rsp->start_rsp_params.stations,

I think that printing this information, especially the firmware version,
is useful. Isn't there a better way to solve this, like print this only
once during the driver is loaded or during the first start() call?

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] wcn36xx: reduce verbosity of drivers messages
       [not found]   ` <d2614854-478c-80d5-a3e0-b75442bb862c@codeaurora.org>
@ 2018-02-27 13:20     ` Kalle Valo
  0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2018-02-27 13:20 UTC (permalink / raw)
  To: Ramon Fried; +Cc: linux-wireless, wcn36xx

Hi Ramon,

you dropped the mailing lists from CC, I'll add them back.

Ramon Fried <rfried@codeaurora.org> writes:

> On 2/27/2018 10:26 AM, Kalle Valo wrote:
>> Ramon Fried <rfried@codeaurora.org> writes:
>>
>>> --- a/drivers/net/wireless/ath/wcn36xx/main.c
>>> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
>>> @@ -261,7 +261,7 @@ static void wcn36xx_feat_caps_info(struct wcn36xx *wcn)
>>>  
>>>  	for (i = 0; i < MAX_FEATURE_SUPPORTED; i++) {
>>>  		if (get_feat_caps(wcn->fw_feat_caps, i))
>>> -			wcn36xx_info("FW Cap %s\n", wcn36xx_get_cap_name(i));
>>> +			wcn36xx_dbg(WCN36XX_DBG_MAC, "FW Cap %s\n", wcn36xx_get_cap_name(i));
>>>  	}
>>>  }
>>>  
>>> diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
>>> index 2a4871ca9c72..7c4d19b041bc 100644
>>> --- a/drivers/net/wireless/ath/wcn36xx/smd.c
>>> +++ b/drivers/net/wireless/ath/wcn36xx/smd.c
>>> @@ -409,10 +409,10 @@ static int wcn36xx_smd_start_rsp(struct wcn36xx *wcn, void *buf, size_t len)
>>>  	wcn->fw_minor = rsp->start_rsp_params.version.minor;
>>>  	wcn->fw_major = rsp->start_rsp_params.version.major;
>>>  
>>> -	wcn36xx_info("firmware WLAN version '%s' and CRM version '%s'\n",
>>> +	wcn36xx_dbg(WCN36XX_DBG_HAL, "firmware WLAN version '%s' and CRM version '%s'\n",
>>>  		     wcn->wlan_version, wcn->crm_version);
>>>  
>>> -	wcn36xx_info("firmware API %u.%u.%u.%u, %u stations, %u bssids\n",
>>> +	wcn36xx_dbg(WCN36XX_DBG_HAL, "firmware API %u.%u.%u.%u, %u stations, %u bssids\n",
>>>  		     wcn->fw_major, wcn->fw_minor,
>>>  		     wcn->fw_version, wcn->fw_revision,
>>>  		     rsp->start_rsp_params.stations,
>>
>> I think that printing this information, especially the firmware version,
>> is useful. Isn't there a better way to solve this, like print this only
>> once during the driver is loaded or during the first start() call?
>
> I agree regarding the firmware version. I can fix it.

Good, thanks.

> the capabilities IMHO is really only relevant for debug and hackers
> who can turn debug on.

Yeah, makes sense.

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-27 13:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-17 20:25 [PATCH] wcn36xx: reduce verbosity of drivers messages Ramon Fried
2018-02-19  3:27 ` Bjorn Andersson
2018-02-27  8:26 ` Kalle Valo
     [not found]   ` <d2614854-478c-80d5-a3e0-b75442bb862c@codeaurora.org>
2018-02-27 13:20     ` Kalle Valo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.