All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: linux-renesas-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Marek Vasut <marek.vasut+renesas@gmail.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH 1/2] ARM: shmobile: Factor out complex condition
Date: Mon, 19 Feb 2018 09:58:37 +0100	[thread overview]
Message-ID: <20180219085837.tsza3xakwxodrwko@verge.net.au> (raw)
In-Reply-To: <20180217020642.21375-1-marek.vasut+renesas@gmail.com>

On Sat, Feb 17, 2018 at 03:06:41AM +0100, Marek Vasut wrote:
> Pull the complex condition in regulator_quirk_notify() into
> regulator_quirk_check(). Moreover, do not hard-code the I2C
> address, but rather use the one in da9xxx_msgs[].
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Cc: Simon Horman <horms+renesas@verge.net.au>
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>

There appears to be some review of this series that needs addressing,
I have marked it as "Changes Requested".

WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: shmobile: Factor out complex condition
Date: Mon, 19 Feb 2018 09:58:37 +0100	[thread overview]
Message-ID: <20180219085837.tsza3xakwxodrwko@verge.net.au> (raw)
In-Reply-To: <20180217020642.21375-1-marek.vasut+renesas@gmail.com>

On Sat, Feb 17, 2018 at 03:06:41AM +0100, Marek Vasut wrote:
> Pull the complex condition in regulator_quirk_notify() into
> regulator_quirk_check(). Moreover, do not hard-code the I2C
> address, but rather use the one in da9xxx_msgs[].
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Cc: Simon Horman <horms+renesas@verge.net.au>
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>

There appears to be some review of this series that needs addressing,
I have marked it as "Changes Requested".

  parent reply	other threads:[~2018-02-19  8:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-17  2:06 [PATCH 1/2] ARM: shmobile: Factor out complex condition Marek Vasut
2018-02-17  2:06 ` Marek Vasut
2018-02-17  2:06 ` [PATCH 2/2] ARM: shmobile: porter: enable R-Car Gen2 regulator quirk Marek Vasut
2018-02-17  2:06   ` Marek Vasut
2018-02-19  8:42   ` Geert Uytterhoeven
2018-02-19  8:42     ` Geert Uytterhoeven
2018-02-19  8:51     ` Marek Vasut
2018-02-19  8:51       ` Marek Vasut
2018-02-17  8:18 ` [PATCH 1/2] ARM: shmobile: Factor out complex condition Wolfram Sang
2018-02-17  8:18   ` Wolfram Sang
2018-02-17 11:46   ` Marek Vasut
2018-02-17 11:46     ` Marek Vasut
2018-02-19  8:53     ` Geert Uytterhoeven
2018-02-19  8:53       ` Geert Uytterhoeven
2018-02-19  8:58 ` Simon Horman [this message]
2018-02-19  8:58   ` Simon Horman
2018-02-21 19:59   ` Marek Vasut
2018-02-21 19:59     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180219085837.tsza3xakwxodrwko@verge.net.au \
    --to=horms@verge.net.au \
    --cc=geert+renesas@glider.be \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=marek.vasut+renesas@gmail.com \
    --cc=marek.vasut@gmail.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.