All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: Otavio Salvador <otavio.salvador@ossystems.com.br>
Cc: Denys Dmytriyenko <denys@ti.com>,
	Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] kernel.bbclass: explicitly depend on bison-native for deterministic builds
Date: Mon, 19 Feb 2018 20:20:01 -0500	[thread overview]
Message-ID: <20180220012001.GZ2786@denix.org> (raw)
In-Reply-To: <CAP9ODKq7YyqaapLxxOrPo6WoNf6dTFpxkvQh1pF+yqJQxGA7jQ@mail.gmail.com>

On Mon, Feb 19, 2018 at 09:36:22PM -0300, Otavio Salvador wrote:
> On Mon, Feb 19, 2018 at 8:54 PM, Denys Dmytriyenko <denis@denix.org> wrote:
> > From: Denys Dmytriyenko <denys@ti.com>
> >
> > Explicitly depend on bison-native for deterministic builds, as it is required
> > for the build:
> >
> > |   HOSTCC  scripts/basic/fixdep
> > |   GEN     ./Makefile
> > |   HOSTCC  scripts/kconfig/conf.o
> > |   YACC    scripts/kconfig/zconf.tab.c
> > | /bin/sh: bison: command not found
> > | scripts/Makefile.lib:217: recipe for target 'scripts/kconfig/zconf.tab.c' failed
> >
> > In most cases, this dependency comes indirectly via toolchain dependencies,
> > specifically binutils-cross, which pulls bison-native. Different setups,
> > such as with external toolchain, would expose this problem, since correct
> > dependency is not marked explicitly.
> >
> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > ---
> > I'm seeing this now on 4.16-rc2 with external toolchain.
> 
> I am not against the addition but in fact, it is because 4.16 stopped
> of using pre-generated files and now requires bison to be available.

Ok, good, I was wondering why I didn't see it before 4.16...


> I am unsure it ought to be on kernel.bbclass at this moment.

Why not? Because it's 4.16+ specific?

By default bison-native dependency gets added implicitly when built with the 
toolchain from oe-core, so this doesn't add any extra dependencies, only makes 
it explicit.

-- 
Denys


  reply	other threads:[~2018-02-20  1:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-19 23:54 [PATCH] kernel.bbclass: explicitly depend on bison-native for deterministic builds Denys Dmytriyenko
2018-02-20  0:36 ` Otavio Salvador
2018-02-20  1:20   ` Denys Dmytriyenko [this message]
2018-02-20 10:10     ` Khem Raj
2018-02-20 14:53       ` Otavio Salvador
2018-02-20 15:41         ` Martin Jansa
2018-02-20 16:08           ` Khem Raj
2018-02-20 16:17             ` Denys Dmytriyenko
2018-02-20 18:28               ` Khem Raj
2018-02-20 19:33                 ` Denys Dmytriyenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180220012001.GZ2786@denix.org \
    --to=denis@denix.org \
    --cc=denys@ti.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=otavio.salvador@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.