All of lore.kernel.org
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: Denys Dmytriyenko <denis@denix.org>
Cc: Denys Dmytriyenko <denys@ti.com>,
	Otavio Salvador <otavio.salvador@ossystems.com.br>,
	Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] kernel.bbclass: explicitly depend on bison-native for deterministic builds
Date: Tue, 20 Feb 2018 10:28:47 -0800	[thread overview]
Message-ID: <CAMKF1soq1h+EgCz0C4HeRpggTctGiL=0OqQwD9tK0eTZ7K=HQg@mail.gmail.com> (raw)
In-Reply-To: <20180220161752.GA2786@denix.org>

On Tue, Feb 20, 2018 at 8:17 AM, Denys Dmytriyenko <denis@denix.org> wrote:
> On Tue, Feb 20, 2018 at 04:08:06PM +0000, Khem Raj wrote:
>> On Tue, Feb 20, 2018 at 7:41 AM Martin Jansa <martin.jansa@gmail.com> wrote:
>>
>> > I'm OK with adding bison-native for all versions.
>>
>> As long we know that there are no side effects of this dep in kernel builds
>
> You do realize that when you build with oe-core toolchain, every package gets
> bison-native dependency automatically? Regardless whether it was requested or
> not. If there were side effects, we would have seen it long time ago...

Yes I see it seems to be pulled in by toolchain regardless, so for this
patch we might just be adding to determinism. but I think it raises question
on why toolchain is adding this everywhere, I think we should remove it
from toolchain default deps. It will make metadata more consistent
across internal/external toolchains


  reply	other threads:[~2018-02-20 18:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-19 23:54 [PATCH] kernel.bbclass: explicitly depend on bison-native for deterministic builds Denys Dmytriyenko
2018-02-20  0:36 ` Otavio Salvador
2018-02-20  1:20   ` Denys Dmytriyenko
2018-02-20 10:10     ` Khem Raj
2018-02-20 14:53       ` Otavio Salvador
2018-02-20 15:41         ` Martin Jansa
2018-02-20 16:08           ` Khem Raj
2018-02-20 16:17             ` Denys Dmytriyenko
2018-02-20 18:28               ` Khem Raj [this message]
2018-02-20 19:33                 ` Denys Dmytriyenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMKF1soq1h+EgCz0C4HeRpggTctGiL=0OqQwD9tK0eTZ7K=HQg@mail.gmail.com' \
    --to=raj.khem@gmail.com \
    --cc=denis@denix.org \
    --cc=denys@ti.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=otavio.salvador@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.