* [PATCH] drm/i915: fix the issue DP-1 not working in guest
@ 2017-06-14 5:47 Mustamin B Mustaffa
2017-06-14 6:11 ` ✓ Fi.CI.BAT: success for " Patchwork
` (4 more replies)
0 siblings, 5 replies; 10+ messages in thread
From: Mustamin B Mustaffa @ 2017-06-14 5:47 UTC (permalink / raw)
To: intel-gfx; +Cc: Anuar, Nuhairi
From: "Anuar, Nuhairi" <nuhairi.anuar@intel.com>
In GVT guest, when port A is DP, i915 will force it as an EDP panel,
which
will cause DP-1 not working in GVT guest.
This patch fixed this issue by check intel_vgpu_active() in
intel_ddi_compute_config().
Signed-off-by: Min He <min.he@intel.com>
Signed-off-by: Nuhairi Anuar <nuhairi.anuar@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 66b367d..1110cbc 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -2069,7 +2069,7 @@ static bool intel_ddi_compute_config(struct intel_encoder *encoder,
WARN(type == INTEL_OUTPUT_UNKNOWN, "compute_config() on unknown output!\n");
- if (port == PORT_A)
+ if (port == PORT_A && !intel_vgpu_active(dev_priv))
pipe_config->cpu_transcoder = TRANSCODER_EDP;
if (type == INTEL_OUTPUT_HDMI)
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: fix the issue DP-1 not working in guest
2017-06-14 5:47 [PATCH] drm/i915: fix the issue DP-1 not working in guest Mustamin B Mustaffa
@ 2017-06-14 6:11 ` Patchwork
2017-06-14 13:38 ` [PATCH] " Ville Syrjälä
` (3 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2017-06-14 6:11 UTC (permalink / raw)
To: Mustamin B Mustaffa; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: fix the issue DP-1 not working in guest
URL : https://patchwork.freedesktop.org/series/25753/
State : success
== Summary ==
Series 25753v1 drm/i915: fix the issue DP-1 not working in guest
https://patchwork.freedesktop.org/api/1.0/series/25753/revisions/1/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
fail -> PASS (fi-snb-2600) fdo#100007
Test gem_exec_suspend:
Subgroup basic-s4-devices:
dmesg-warn -> PASS (fi-kbl-7560u) fdo#100125 +1
fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time:448s
fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time:430s
fi-bsw-n3050 total:278 pass:242 dwarn:0 dfail:0 fail:0 skip:36 time:583s
fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:503s
fi-byt-j1900 total:278 pass:254 dwarn:0 dfail:0 fail:0 skip:24 time:490s
fi-byt-n2820 total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:482s
fi-glk-2a total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:591s
fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:434s
fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:417s
fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time:425s
fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:503s
fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:467s
fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:474s
fi-kbl-7560u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:566s
fi-kbl-r total:278 pass:259 dwarn:1 dfail:0 fail:0 skip:18 time:577s
fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:463s
fi-skl-6700hq total:278 pass:228 dwarn:1 dfail:0 fail:27 skip:22 time:406s
fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time:465s
fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:478s
fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time:437s
fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:536s
fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29 time:402s
d4bedb8b0f9ba91df2e8cb136a489145a83e96a7 drm-tip: 2017y-06m-13d-14h-22m-46s UTC integration manifest
cea18ba drm/i915: fix the issue DP-1 not working in guest
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4948/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915: fix the issue DP-1 not working in guest
2017-06-14 5:47 [PATCH] drm/i915: fix the issue DP-1 not working in guest Mustamin B Mustaffa
2017-06-14 6:11 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-06-14 13:38 ` Ville Syrjälä
2018-02-20 6:40 ` Mustamin B Mustaffa
` (2 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Ville Syrjälä @ 2017-06-14 13:38 UTC (permalink / raw)
To: Mustamin B Mustaffa; +Cc: intel-gfx, Anuar, Nuhairi
On Wed, Jun 14, 2017 at 01:47:30PM +0800, Mustamin B Mustaffa wrote:
> From: "Anuar, Nuhairi" <nuhairi.anuar@intel.com>
>
> In GVT guest, when port A is DP, i915 will force it as an EDP panel,
> which
> will cause DP-1 not working in GVT guest.
> This patch fixed this issue by check intel_vgpu_active() in
> intel_ddi_compute_config().
>
> Signed-off-by: Min He <min.he@intel.com>
> Signed-off-by: Nuhairi Anuar <nuhairi.anuar@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 66b367d..1110cbc 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -2069,7 +2069,7 @@ static bool intel_ddi_compute_config(struct intel_encoder *encoder,
>
> WARN(type == INTEL_OUTPUT_UNKNOWN, "compute_config() on unknown output!\n");
>
> - if (port == PORT_A)
> + if (port == PORT_A && !intel_vgpu_active(dev_priv))
> pipe_config->cpu_transcoder = TRANSCODER_EDP;
And why exactly are you trying to register DP on port A?
>
> if (type == INTEL_OUTPUT_HDMI)
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] drm/i915: fix the issue DP-1 not working in guest
2017-06-14 5:47 [PATCH] drm/i915: fix the issue DP-1 not working in guest Mustamin B Mustaffa
2017-06-14 6:11 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-06-14 13:38 ` [PATCH] " Ville Syrjälä
@ 2018-02-20 6:40 ` Mustamin B Mustaffa
2018-02-20 11:35 ` Jani Nikula
2018-02-20 7:13 ` ✓ Fi.CI.BAT: success for drm/i915: fix the issue DP-1 not working in guest (rev2) Patchwork
2018-02-20 7:57 ` ✗ Fi.CI.IGT: failure " Patchwork
4 siblings, 1 reply; 10+ messages in thread
From: Mustamin B Mustaffa @ 2018-02-20 6:40 UTC (permalink / raw)
To: intel-gfx; +Cc: Mustamin B Mustaffa, Nuhairi Anuar
In GVT guest, when port A is DP, i915 will force it as an EDP panel,
which
will cause DP-1 not working in GVT guest.
This patch fixed this issue by check intel_vgpu_active() in
intel_ddi_compute_config().
Signed-off-by: Min He <min.he@intel.com>
Signed-off-by: Nuhairi Anuar <nuhairi.anuar@intel.com>
Signed-off-by: Mustamin B Mustaffa <mustamin.b.mustaffa@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index db92a26..9f5e85c 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -2720,7 +2720,7 @@ static bool intel_ddi_compute_config(struct intel_encoder *encoder,
enum port port = encoder->port;
int ret;
- if (port == PORT_A)
+ if (port == PORT_A && !intel_vgpu_active(dev_priv))
pipe_config->cpu_transcoder = TRANSCODER_EDP;
if (intel_crtc_has_type(pipe_config, INTEL_OUTPUT_HDMI))
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: fix the issue DP-1 not working in guest (rev2)
2017-06-14 5:47 [PATCH] drm/i915: fix the issue DP-1 not working in guest Mustamin B Mustaffa
` (2 preceding siblings ...)
2018-02-20 6:40 ` Mustamin B Mustaffa
@ 2018-02-20 7:13 ` Patchwork
2018-02-20 7:57 ` ✗ Fi.CI.IGT: failure " Patchwork
4 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2018-02-20 7:13 UTC (permalink / raw)
To: Mustamin B Mustaffa; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: fix the issue DP-1 not working in guest (rev2)
URL : https://patchwork.freedesktop.org/series/25753/
State : success
== Summary ==
Series 25753v2 drm/i915: fix the issue DP-1 not working in guest
https://patchwork.freedesktop.org/api/1.0/series/25753/revisions/2/mbox/
Test gem_exec_suspend:
Subgroup basic-s3:
pass -> INCOMPLETE (fi-hsw-4770) fdo#103375
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-c:
pass -> INCOMPLETE (fi-bxt-dsi) fdo#103927
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:420s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:432s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:372s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:481s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:288s
fi-bxt-dsi total:246 pass:219 dwarn:0 dfail:0 fail:0 skip:26
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:487s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:467s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:457s
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:577s
fi-cnl-y3 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:574s
fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:417s
fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:284s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:509s
fi-hsw-4770 total:108 pass:99 dwarn:0 dfail:0 fail:0 skip:8
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:409s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:459s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:458s
fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:500s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:450s
fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:501s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:597s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:432s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:508s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:526s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:492s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:494s
fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:415s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:428s
fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:527s
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:396s
2ca2a369fc68ac59f42f359b62a978273425e531 drm-tip: 2018y-02m-19d-20h-39m-49s UTC integration manifest
01ca257b7e1a drm/i915: fix the issue DP-1 not working in guest
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8073/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915: fix the issue DP-1 not working in guest (rev2)
2017-06-14 5:47 [PATCH] drm/i915: fix the issue DP-1 not working in guest Mustamin B Mustaffa
` (3 preceding siblings ...)
2018-02-20 7:13 ` ✓ Fi.CI.BAT: success for drm/i915: fix the issue DP-1 not working in guest (rev2) Patchwork
@ 2018-02-20 7:57 ` Patchwork
4 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2018-02-20 7:57 UTC (permalink / raw)
To: Mustamin B Mustaffa; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: fix the issue DP-1 not working in guest (rev2)
URL : https://patchwork.freedesktop.org/series/25753/
State : failure
== Summary ==
Test perf:
Subgroup buffer-fill:
fail -> PASS (shard-apl) fdo#103755
Test kms_flip:
Subgroup 2x-modeset-vs-vblank-race-interruptible:
pass -> FAIL (shard-hsw) fdo#103060
Test kms_cursor_crc:
Subgroup cursor-128x128-suspend:
pass -> INCOMPLETE (shard-apl)
Test kms_setmode:
Subgroup basic:
pass -> FAIL (shard-hsw) fdo#99912
Test kms_sysfs_edid_timing:
pass -> WARN (shard-apl) fdo#100047
Test gem_eio:
Subgroup in-flight:
pass -> FAIL (shard-hsw) fdo#104676
Test gem_exec_suspend:
Subgroup basic-s4:
fail -> SKIP (shard-snb) fdo#103375
fdo#103755 https://bugs.freedesktop.org/show_bug.cgi?id=103755
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#104676 https://bugs.freedesktop.org/show_bug.cgi?id=104676
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
shard-apl total:3338 pass:1749 dwarn:1 dfail:0 fail:11 skip:1574 time:11706s
shard-hsw total:3434 pass:1760 dwarn:1 dfail:0 fail:4 skip:1668 time:11801s
shard-snb total:3434 pass:1352 dwarn:1 dfail:0 fail:1 skip:2080 time:6611s
Blacklisted hosts:
shard-kbl total:3410 pass:1918 dwarn:1 dfail:0 fail:13 skip:1476 time:8983s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8073/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915: fix the issue DP-1 not working in guest
2018-02-20 6:40 ` Mustamin B Mustaffa
@ 2018-02-20 11:35 ` Jani Nikula
2018-02-21 0:01 ` Mustaffa, Mustamin B
0 siblings, 1 reply; 10+ messages in thread
From: Jani Nikula @ 2018-02-20 11:35 UTC (permalink / raw)
To: intel-gfx; +Cc: Mustamin B Mustaffa, Nuhairi Anuar
On Tue, 20 Feb 2018, Mustamin B Mustaffa <mustamin.b.mustaffa@intel.com> wrote:
> In GVT guest, when port A is DP, i915 will force it as an EDP panel,
> which
> will cause DP-1 not working in GVT guest.
> This patch fixed this issue by check intel_vgpu_active() in
> intel_ddi_compute_config().
Just repeating Ville's question from last June that went unanswered [1],
"And why exactly are you trying to register DP on port A?"
BR,
Jani.
[1] http://mid.mail-archive.com/20170614133842.GM12629@intel.com
>
> Signed-off-by: Min He <min.he@intel.com>
> Signed-off-by: Nuhairi Anuar <nuhairi.anuar@intel.com>
> Signed-off-by: Mustamin B Mustaffa <mustamin.b.mustaffa@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index db92a26..9f5e85c 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -2720,7 +2720,7 @@ static bool intel_ddi_compute_config(struct intel_encoder *encoder,
> enum port port = encoder->port;
> int ret;
>
> - if (port == PORT_A)
> + if (port == PORT_A && !intel_vgpu_active(dev_priv))
> pipe_config->cpu_transcoder = TRANSCODER_EDP;
>
> if (intel_crtc_has_type(pipe_config, INTEL_OUTPUT_HDMI))
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915: fix the issue DP-1 not working in guest
2018-02-20 11:35 ` Jani Nikula
@ 2018-02-21 0:01 ` Mustaffa, Mustamin B
2018-02-21 8:03 ` Jani Nikula
0 siblings, 1 reply; 10+ messages in thread
From: Mustaffa, Mustamin B @ 2018-02-21 0:01 UTC (permalink / raw)
To: Jani Nikula, intel-gfx; +Cc: Anuar, Nuhairi
Hi Jani,
In GVT (virtualization) environment, it only can use DP. Therefore, we want to enable Port A as DP so that display panel on Port A can be used by GVT.
Best regard
Mustamin
-----Original Message-----
From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
Sent: Tuesday, February 20, 2018 7:35 PM
To: Mustaffa, Mustamin B <mustamin.b.mustaffa@intel.com>; intel-gfx@lists.freedesktop.org
Cc: Mustaffa, Mustamin B <mustamin.b.mustaffa@intel.com>; Anuar, Nuhairi <nuhairi.anuar@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix the issue DP-1 not working in guest
On Tue, 20 Feb 2018, Mustamin B Mustaffa <mustamin.b.mustaffa@intel.com> wrote:
> In GVT guest, when port A is DP, i915 will force it as an EDP panel,
> which will cause DP-1 not working in GVT guest.
> This patch fixed this issue by check intel_vgpu_active() in
> intel_ddi_compute_config().
Just repeating Ville's question from last June that went unanswered [1], "And why exactly are you trying to register DP on port A?"
BR,
Jani.
[1] http://mid.mail-archive.com/20170614133842.GM12629@intel.com
>
> Signed-off-by: Min He <min.he@intel.com>
> Signed-off-by: Nuhairi Anuar <nuhairi.anuar@intel.com>
> Signed-off-by: Mustamin B Mustaffa <mustamin.b.mustaffa@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> b/drivers/gpu/drm/i915/intel_ddi.c
> index db92a26..9f5e85c 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -2720,7 +2720,7 @@ static bool intel_ddi_compute_config(struct intel_encoder *encoder,
> enum port port = encoder->port;
> int ret;
>
> - if (port == PORT_A)
> + if (port == PORT_A && !intel_vgpu_active(dev_priv))
> pipe_config->cpu_transcoder = TRANSCODER_EDP;
>
> if (intel_crtc_has_type(pipe_config, INTEL_OUTPUT_HDMI))
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915: fix the issue DP-1 not working in guest
2018-02-21 0:01 ` Mustaffa, Mustamin B
@ 2018-02-21 8:03 ` Jani Nikula
2018-02-21 8:21 ` Mustaffa, Mustamin B
0 siblings, 1 reply; 10+ messages in thread
From: Jani Nikula @ 2018-02-21 8:03 UTC (permalink / raw)
To: Mustaffa, Mustamin B, intel-gfx; +Cc: Anuar, Nuhairi
On Wed, 21 Feb 2018, "Mustaffa, Mustamin B" <mustamin.b.mustaffa@intel.com> wrote:
> Hi Jani,
>
> In GVT (virtualization) environment, it only can use DP. Therefore,
> we want to enable Port A as DP so that display panel on Port A can be
> used by GVT.
Why not just disable port A in the guest VBT?
Or are you saying that host eDP can't be used by guest unless we fake
the same port as DP? Or what are you trying to say?
BR,
Jani.
>
> Best regard
>
> Mustamin
>
>
> -----Original Message-----
> From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
> Sent: Tuesday, February 20, 2018 7:35 PM
> To: Mustaffa, Mustamin B <mustamin.b.mustaffa@intel.com>; intel-gfx@lists.freedesktop.org
> Cc: Mustaffa, Mustamin B <mustamin.b.mustaffa@intel.com>; Anuar, Nuhairi <nuhairi.anuar@intel.com>
> Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix the issue DP-1 not working in guest
>
> On Tue, 20 Feb 2018, Mustamin B Mustaffa <mustamin.b.mustaffa@intel.com> wrote:
>> In GVT guest, when port A is DP, i915 will force it as an EDP panel,
>> which will cause DP-1 not working in GVT guest.
>> This patch fixed this issue by check intel_vgpu_active() in
>> intel_ddi_compute_config().
>
> Just repeating Ville's question from last June that went unanswered [1], "And why exactly are you trying to register DP on port A?"
>
> BR,
> Jani.
>
> [1] http://mid.mail-archive.com/20170614133842.GM12629@intel.com
>
>>
>> Signed-off-by: Min He <min.he@intel.com>
>> Signed-off-by: Nuhairi Anuar <nuhairi.anuar@intel.com>
>> Signed-off-by: Mustamin B Mustaffa <mustamin.b.mustaffa@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_ddi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_ddi.c
>> b/drivers/gpu/drm/i915/intel_ddi.c
>> index db92a26..9f5e85c 100644
>> --- a/drivers/gpu/drm/i915/intel_ddi.c
>> +++ b/drivers/gpu/drm/i915/intel_ddi.c
>> @@ -2720,7 +2720,7 @@ static bool intel_ddi_compute_config(struct intel_encoder *encoder,
>> enum port port = encoder->port;
>> int ret;
>>
>> - if (port == PORT_A)
>> + if (port == PORT_A && !intel_vgpu_active(dev_priv))
>> pipe_config->cpu_transcoder = TRANSCODER_EDP;
>>
>> if (intel_crtc_has_type(pipe_config, INTEL_OUTPUT_HDMI))
>
> --
> Jani Nikula, Intel Open Source Technology Center
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915: fix the issue DP-1 not working in guest
2018-02-21 8:03 ` Jani Nikula
@ 2018-02-21 8:21 ` Mustaffa, Mustamin B
0 siblings, 0 replies; 10+ messages in thread
From: Mustaffa, Mustamin B @ 2018-02-21 8:21 UTC (permalink / raw)
To: Jani Nikula, intel-gfx; +Cc: Anuar, Nuhairi
Hi Jani,
We cannot disable any port as we might use all the ports for display.
And yes, we fake the DP to use EDP panel.
Hi Nuhairi, please correct me if I'm wrong.
Best regard
Mustamin
-----Original Message-----
From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
Sent: Wednesday, February 21, 2018 4:03 PM
To: Mustaffa, Mustamin B <mustamin.b.mustaffa@intel.com>; intel-gfx@lists.freedesktop.org
Cc: Anuar, Nuhairi <nuhairi.anuar@intel.com>; Ville Syrjälä <ville.syrjala@linux.intel.com>
Subject: RE: [Intel-gfx] [PATCH] drm/i915: fix the issue DP-1 not working in guest
On Wed, 21 Feb 2018, "Mustaffa, Mustamin B" <mustamin.b.mustaffa@intel.com> wrote:
> Hi Jani,
>
> In GVT (virtualization) environment, it only can use DP. Therefore,
> we want to enable Port A as DP so that display panel on Port A can be
> used by GVT.
Why not just disable port A in the guest VBT?
Or are you saying that host eDP can't be used by guest unless we fake the same port as DP? Or what are you trying to say?
BR,
Jani.
>
> Best regard
>
> Mustamin
>
>
> -----Original Message-----
> From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
> Sent: Tuesday, February 20, 2018 7:35 PM
> To: Mustaffa, Mustamin B <mustamin.b.mustaffa@intel.com>;
> intel-gfx@lists.freedesktop.org
> Cc: Mustaffa, Mustamin B <mustamin.b.mustaffa@intel.com>; Anuar,
> Nuhairi <nuhairi.anuar@intel.com>
> Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix the issue DP-1 not
> working in guest
>
> On Tue, 20 Feb 2018, Mustamin B Mustaffa <mustamin.b.mustaffa@intel.com> wrote:
>> In GVT guest, when port A is DP, i915 will force it as an EDP panel,
>> which will cause DP-1 not working in GVT guest.
>> This patch fixed this issue by check intel_vgpu_active() in
>> intel_ddi_compute_config().
>
> Just repeating Ville's question from last June that went unanswered [1], "And why exactly are you trying to register DP on port A?"
>
> BR,
> Jani.
>
> [1] http://mid.mail-archive.com/20170614133842.GM12629@intel.com
>
>>
>> Signed-off-by: Min He <min.he@intel.com>
>> Signed-off-by: Nuhairi Anuar <nuhairi.anuar@intel.com>
>> Signed-off-by: Mustamin B Mustaffa <mustamin.b.mustaffa@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_ddi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_ddi.c
>> b/drivers/gpu/drm/i915/intel_ddi.c
>> index db92a26..9f5e85c 100644
>> --- a/drivers/gpu/drm/i915/intel_ddi.c
>> +++ b/drivers/gpu/drm/i915/intel_ddi.c
>> @@ -2720,7 +2720,7 @@ static bool intel_ddi_compute_config(struct intel_encoder *encoder,
>> enum port port = encoder->port;
>> int ret;
>>
>> - if (port == PORT_A)
>> + if (port == PORT_A && !intel_vgpu_active(dev_priv))
>> pipe_config->cpu_transcoder = TRANSCODER_EDP;
>>
>> if (intel_crtc_has_type(pipe_config, INTEL_OUTPUT_HDMI))
>
> --
> Jani Nikula, Intel Open Source Technology Center
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-02-21 8:21 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-14 5:47 [PATCH] drm/i915: fix the issue DP-1 not working in guest Mustamin B Mustaffa
2017-06-14 6:11 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-06-14 13:38 ` [PATCH] " Ville Syrjälä
2018-02-20 6:40 ` Mustamin B Mustaffa
2018-02-20 11:35 ` Jani Nikula
2018-02-21 0:01 ` Mustaffa, Mustamin B
2018-02-21 8:03 ` Jani Nikula
2018-02-21 8:21 ` Mustaffa, Mustamin B
2018-02-20 7:13 ` ✓ Fi.CI.BAT: success for drm/i915: fix the issue DP-1 not working in guest (rev2) Patchwork
2018-02-20 7:57 ` ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.