* Re: [Qemu-devel] [PATCH] Document --rtc-td-hack, --localtime and --startdate as deprecated
[not found] <1519138892-12836-1-git-send-email-thuth@redhat.com>
@ 2018-02-20 15:05 ` Paolo Bonzini
2018-02-20 15:07 ` Paolo Bonzini
2018-02-20 15:06 ` Daniel P. Berrangé
1 sibling, 1 reply; 3+ messages in thread
From: Paolo Bonzini @ 2018-02-20 15:05 UTC (permalink / raw)
To: Thomas Huth, qemu-devel; +Cc: Daniel P Berrange, Jan Kiszka
On 20/02/2018 16:01, Thomas Huth wrote:
> These options have been marked in a comment in qemu-options.hx as
> deprecated in 2009 already (see commit 1ed2fc1fa35fadc0d6), but we
> never informed the users about these deprecations. Let's catch up
> on that omission now.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> qemu-doc.texi | 13 +++++++++++++
> vl.c | 5 +++++
> 2 files changed, 18 insertions(+)
>
> diff --git a/qemu-doc.texi b/qemu-doc.texi
> index 2f19980..7494042 100644
> --- a/qemu-doc.texi
> +++ b/qemu-doc.texi
> @@ -2736,6 +2736,19 @@ filesystem test suite. Also it requires the CAP_DAC_READ_SEARCH capability,
> which is not the recommended way to run QEMU. This backend should not be
> used and it will be removed with no replacement.
>
> +@subsection -rtc-td-hack (since 2.12.0)
> +
> +The @code{--rtc-td-hack} option has been replaced by
> +@code{--rtc driftfix=slew}.
> +
> +@subsection -localtime (since 2.12.0)
> +
> +The @code{--localtime} option has been replaced by @code{--rtc localtime}.
> +
> +@subsection -startdate (since 2.12.0)
> +
> +The @code{--startdate} option has been replaced by @code{--rtc @var{date}}.
> +
> @section qemu-img command line arguments
>
> @subsection convert -s (since 2.0.0)
> diff --git a/vl.c b/vl.c
> index 0feaca7..84121bf 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3417,6 +3417,8 @@ int main(int argc, char **argv, char **envp)
> break;
> case QEMU_OPTION_localtime:
> rtc_utc = 0;
> + warn_report("This option is deprecated, "
> + "use '--rtc localtime' instead.");
> break;
> case QEMU_OPTION_vga:
> vga_model = optarg;
> @@ -3672,6 +3674,8 @@ int main(int argc, char **argv, char **envp)
> };
>
> qdev_prop_register_global(&slew_lost_ticks);
> + warn_report("This option is deprecated, "
> + "use '--rtc driftfix=slew' instead.");
> break;
> }
> case QEMU_OPTION_acpitable:
> @@ -3876,6 +3880,7 @@ int main(int argc, char **argv, char **envp)
> */
> break;
> case QEMU_OPTION_startdate:
> + warn_report("This option is deprecated, use '--rtc' instead.");
> configure_rtc_date_offset(optarg, 1);
> break;
> case QEMU_OPTION_rtc:
>
Queued, thanks.
paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] Document --rtc-td-hack, --localtime and --startdate as deprecated
[not found] <1519138892-12836-1-git-send-email-thuth@redhat.com>
2018-02-20 15:05 ` [Qemu-devel] [PATCH] Document --rtc-td-hack, --localtime and --startdate as deprecated Paolo Bonzini
@ 2018-02-20 15:06 ` Daniel P. Berrangé
1 sibling, 0 replies; 3+ messages in thread
From: Daniel P. Berrangé @ 2018-02-20 15:06 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-devel
On Tue, Feb 20, 2018 at 04:01:32PM +0100, Thomas Huth wrote:
> These options have been marked in a comment in qemu-options.hx as
> deprecated in 2009 already (see commit 1ed2fc1fa35fadc0d6), but we
> never informed the users about these deprecations. Let's catch up
> on that omission now.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> qemu-doc.texi | 13 +++++++++++++
> vl.c | 5 +++++
> 2 files changed, 18 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] Document --rtc-td-hack, --localtime and --startdate as deprecated
2018-02-20 15:05 ` [Qemu-devel] [PATCH] Document --rtc-td-hack, --localtime and --startdate as deprecated Paolo Bonzini
@ 2018-02-20 15:07 ` Paolo Bonzini
0 siblings, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2018-02-20 15:07 UTC (permalink / raw)
To: Thomas Huth, qemu-devel; +Cc: Jan Kiszka
On 20/02/2018 16:05, Paolo Bonzini wrote:
> On 20/02/2018 16:01, Thomas Huth wrote:
>> These options have been marked in a comment in qemu-options.hx as
>> deprecated in 2009 already (see commit 1ed2fc1fa35fadc0d6), but we
>> never informed the users about these deprecations. Let's catch up
>> on that omission now.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> qemu-doc.texi | 13 +++++++++++++
>> vl.c | 5 +++++
>> 2 files changed, 18 insertions(+)
>>
>> diff --git a/qemu-doc.texi b/qemu-doc.texi
>> index 2f19980..7494042 100644
>> --- a/qemu-doc.texi
>> +++ b/qemu-doc.texi
>> @@ -2736,6 +2736,19 @@ filesystem test suite. Also it requires the CAP_DAC_READ_SEARCH capability,
>> which is not the recommended way to run QEMU. This backend should not be
>> used and it will be removed with no replacement.
>>
>> +@subsection -rtc-td-hack (since 2.12.0)
>> +
>> +The @code{--rtc-td-hack} option has been replaced by
>> +@code{--rtc driftfix=slew}.
>> +
>> +@subsection -localtime (since 2.12.0)
>> +
>> +The @code{--localtime} option has been replaced by @code{--rtc localtime}.
>> +
>> +@subsection -startdate (since 2.12.0)
>> +
>> +The @code{--startdate} option has been replaced by @code{--rtc @var{date}}.
>> +
>> @section qemu-img command line arguments
>>
>> @subsection convert -s (since 2.0.0)
>> diff --git a/vl.c b/vl.c
>> index 0feaca7..84121bf 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -3417,6 +3417,8 @@ int main(int argc, char **argv, char **envp)
>> break;
>> case QEMU_OPTION_localtime:
>> rtc_utc = 0;
>> + warn_report("This option is deprecated, "
>> + "use '--rtc localtime' instead.");
>> break;
>> case QEMU_OPTION_vga:
>> vga_model = optarg;
>> @@ -3672,6 +3674,8 @@ int main(int argc, char **argv, char **envp)
>> };
>>
>> qdev_prop_register_global(&slew_lost_ticks);
>> + warn_report("This option is deprecated, "
>> + "use '--rtc driftfix=slew' instead.");
>> break;
>> }
>> case QEMU_OPTION_acpitable:
>> @@ -3876,6 +3880,7 @@ int main(int argc, char **argv, char **envp)
>> */
>> break;
>> case QEMU_OPTION_startdate:
>> + warn_report("This option is deprecated, use '--rtc' instead.");
>> configure_rtc_date_offset(optarg, 1);
>> break;
>> case QEMU_OPTION_rtc:
>
> Queued, thanks.
... except qemu_rtc_opts has no implied_opt_name, soo it's "-rtc base".
I fixed that up.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-20 15:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1519138892-12836-1-git-send-email-thuth@redhat.com>
2018-02-20 15:05 ` [Qemu-devel] [PATCH] Document --rtc-td-hack, --localtime and --startdate as deprecated Paolo Bonzini
2018-02-20 15:07 ` Paolo Bonzini
2018-02-20 15:06 ` Daniel P. Berrangé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.