From: Dan Rue <dan.rue@linaro.org> To: Michal Hocko <mhocko@kernel.org> Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org, Mike Kravetz <mike.kravetz@oracle.com>, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API Date: Wed, 21 Feb 2018 13:05:00 -0600 [thread overview] Message-ID: <20180221190500.oa2osuf3kwxpizz4@xps> (raw) In-Reply-To: <20180221185252.GJ2231@dhcp22.suse.cz> On Wed, Feb 21, 2018 at 07:52:52PM +0100, Michal Hocko wrote: > On Wed 21-02-18 10:19:14, Dan Rue wrote: > > On Wed, Feb 21, 2018 at 11:01:07AM +0100, Michal Hocko wrote: > > > On Wed 21-02-18 10:55:26, Michal Hocko wrote: > > > > On Tue 20-02-18 22:24:57, Dan Rue wrote: > > > [...] > > > > > I bisected the failure to this commit. The problem is seen on multiple > > > > > architectures (tested x86-64 and arm64). > > > > > > > > The patch shouldn't have introduced any functional changes IIRC. But let > > > > me have a look > > > > > > Hmm, I guess I can see it. Does the following help? > > > --- > > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > > > index 7c204e3d132b..a963f2034dfc 100644 > > > --- a/mm/hugetlb.c > > > +++ b/mm/hugetlb.c > > > @@ -1583,7 +1583,7 @@ static struct page *alloc_surplus_huge_page(struct hstate *h, gfp_t gfp_mask, > > > page = NULL; > > > } else { > > > h->surplus_huge_pages++; > > > - h->nr_huge_pages_node[page_to_nid(page)]++; > > > + h->surplus_huge_pages_node[page_to_nid(page)]++; > > > } > > > > > > out_unlock: > > > > That did the trick. Confirmed fixed on v4.15-3389-g0c397daea1d4 and > > v4.16-rc2 with the above patch. > > Thanks a lot for re-testing! Can I assume your Tested-by? Tested-by: Dan Rue <dan.rue@linaro.org> > > -- > Michal Hocko > SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Dan Rue <dan.rue@linaro.org> To: Michal Hocko <mhocko@kernel.org> Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org, Mike Kravetz <mike.kravetz@oracle.com>, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API Date: Wed, 21 Feb 2018 13:05:00 -0600 [thread overview] Message-ID: <20180221190500.oa2osuf3kwxpizz4@xps> (raw) In-Reply-To: <20180221185252.GJ2231@dhcp22.suse.cz> On Wed, Feb 21, 2018 at 07:52:52PM +0100, Michal Hocko wrote: > On Wed 21-02-18 10:19:14, Dan Rue wrote: > > On Wed, Feb 21, 2018 at 11:01:07AM +0100, Michal Hocko wrote: > > > On Wed 21-02-18 10:55:26, Michal Hocko wrote: > > > > On Tue 20-02-18 22:24:57, Dan Rue wrote: > > > [...] > > > > > I bisected the failure to this commit. The problem is seen on multiple > > > > > architectures (tested x86-64 and arm64). > > > > > > > > The patch shouldn't have introduced any functional changes IIRC. But let > > > > me have a look > > > > > > Hmm, I guess I can see it. Does the following help? > > > --- > > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > > > index 7c204e3d132b..a963f2034dfc 100644 > > > --- a/mm/hugetlb.c > > > +++ b/mm/hugetlb.c > > > @@ -1583,7 +1583,7 @@ static struct page *alloc_surplus_huge_page(struct hstate *h, gfp_t gfp_mask, > > > page = NULL; > > > } else { > > > h->surplus_huge_pages++; > > > - h->nr_huge_pages_node[page_to_nid(page)]++; > > > + h->surplus_huge_pages_node[page_to_nid(page)]++; > > > } > > > > > > out_unlock: > > > > That did the trick. Confirmed fixed on v4.15-3389-g0c397daea1d4 and > > v4.16-rc2 with the above patch. > > Thanks a lot for re-testing! Can I assume your Tested-by? Tested-by: Dan Rue <dan.rue@linaro.org> > > -- > Michal Hocko > SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-02-21 19:05 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-03 9:32 [PATCH 0/6] mm, hugetlb: allocation API and migration improvements Michal Hocko 2018-01-03 9:32 ` Michal Hocko 2018-01-03 9:32 ` [PATCH 1/6] mm, hugetlb: unify core page allocation accounting and initialization Michal Hocko 2018-01-03 9:32 ` Michal Hocko 2018-01-03 9:32 ` [PATCH 2/6] mm, hugetlb: integrate giga hugetlb more naturally to the allocation path Michal Hocko 2018-01-03 9:32 ` Michal Hocko 2018-01-03 9:32 ` [PATCH 3/6] mm, hugetlb: do not rely on overcommit limit during migration Michal Hocko 2018-01-03 9:32 ` Michal Hocko 2018-01-03 9:32 ` [PATCH 4/6] mm, hugetlb: get rid of surplus page accounting tricks Michal Hocko 2018-01-03 9:32 ` Michal Hocko 2018-01-03 9:32 ` [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API Michal Hocko 2018-01-03 9:32 ` Michal Hocko 2018-02-21 4:24 ` Dan Rue 2018-02-21 4:24 ` Dan Rue 2018-02-21 9:55 ` Michal Hocko 2018-02-21 9:55 ` Michal Hocko 2018-02-21 10:01 ` Michal Hocko 2018-02-21 10:01 ` Michal Hocko 2018-02-21 16:19 ` Dan Rue 2018-02-21 16:19 ` Dan Rue 2018-02-21 18:52 ` Michal Hocko 2018-02-21 18:52 ` Michal Hocko 2018-02-21 19:05 ` Dan Rue [this message] 2018-02-21 19:05 ` Dan Rue 2018-02-21 17:59 ` Mike Kravetz 2018-02-21 17:59 ` Mike Kravetz 2018-02-21 18:54 ` Michal Hocko 2018-02-21 18:54 ` Michal Hocko 2018-02-21 19:14 ` [PATCH] hugetlb: fix surplus pages accounting Michal Hocko 2018-02-21 19:14 ` Michal Hocko 2018-01-03 9:32 ` [PATCH 6/6] hugetlb, mempolicy: fix the mbind hugetlb migration Michal Hocko 2018-01-03 9:32 ` Michal Hocko 2018-01-04 0:05 ` [PATCH 0/6] mm, hugetlb: allocation API and migration improvements Andrew Morton 2018-01-04 0:05 ` Andrew Morton 2018-01-04 7:32 ` Michal Hocko 2018-01-04 7:32 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180221190500.oa2osuf3kwxpizz4@xps \ --to=dan.rue@linaro.org \ --cc=akpm@linux-foundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@kernel.org \ --cc=mike.kravetz@oracle.com \ --cc=n-horiguchi@ah.jp.nec.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.