* [PATCH net-next] ibmvnic: Fix TX descriptor tracking
@ 2018-02-22 0:21 Thomas Falcon
2018-02-22 19:46 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Falcon @ 2018-02-22 0:21 UTC (permalink / raw)
To: netdev; +Cc: jallen, nfont, Thomas Falcon
With the recent change, transmissions that only needed
one descriptor were being missed. The result is that such
packets were tracked as outstanding transmissions but never
removed when its completion notification was received.
Fixes: ffc385b95adb ("ibmvnic: Keep track of supplementary TX descriptors")
Signed-off-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
---
drivers/net/ethernet/ibm/ibmvnic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 340e1ab..b3a34d9 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -1478,7 +1478,6 @@ static int ibmvnic_xmit(struct sk_buff *skb, struct net_device *netdev)
if ((*hdrs >> 7) & 1) {
build_hdr_descs_arr(tx_buff, &num_entries, *hdrs);
tx_crq.v1.n_crq_elem = num_entries;
- tx_buff->num_entries = num_entries;
tx_buff->indir_arr[0] = tx_crq;
tx_buff->indir_dma = dma_map_single(dev, tx_buff->indir_arr,
sizeof(tx_buff->indir_arr),
@@ -1533,6 +1532,7 @@ static int ibmvnic_xmit(struct sk_buff *skb, struct net_device *netdev)
netif_stop_subqueue(netdev, queue_num);
}
+ tx_buff->num_entries = num_entries;
tx_packets++;
tx_bytes += skb->len;
txq->trans_start = jiffies;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] ibmvnic: Fix TX descriptor tracking
2018-02-22 0:21 [PATCH net-next] ibmvnic: Fix TX descriptor tracking Thomas Falcon
@ 2018-02-22 19:46 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-02-22 19:46 UTC (permalink / raw)
To: tlfalcon; +Cc: netdev, jallen, nfont
From: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Date: Wed, 21 Feb 2018 18:21:10 -0600
> With the recent change, transmissions that only needed
> one descriptor were being missed. The result is that such
> packets were tracked as outstanding transmissions but never
> removed when its completion notification was received.
>
> Fixes: ffc385b95adb ("ibmvnic: Keep track of supplementary TX descriptors")
> Signed-off-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-22 19:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-22 0:21 [PATCH net-next] ibmvnic: Fix TX descriptor tracking Thomas Falcon
2018-02-22 19:46 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.