All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: matthew.auld@intel.com
Subject: [igt-dev] [PATCH i-g-t] test/perf: fixup inverted condition
Date: Thu, 22 Feb 2018 01:41:52 +0000	[thread overview]
Message-ID: <20180222014152.17941-1-lionel.g.landwerlin@intel.com> (raw)

The previous patch said :

"verify that the time is always longer or equal to the period we've
 asked for"

This is an obvious error, it only worked on my machine and the CI
because only one longer period was observed. But another CI run caught
the issue :

  https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4280/shard-glkb6/igt@perf@oa-exponents.html

Fixes: c3d11ca104fa ("tests/perf: make oa-exponents subtest more reliable")
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
 tests/perf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/perf.c b/tests/perf.c
index 05108f5a..c302a355 100644
--- a/tests/perf.c
+++ b/tests/perf.c
@@ -1795,7 +1795,7 @@ test_oa_exponents(void)
 				  oa_report_get_ctx_id(timer_reports[i].report),
 				  delta, delta == expected_timestamp_delta ? "" : "******");
 
-			matches += expected_timestamp_delta >= delta;
+			matches += expected_timestamp_delta <= delta;
 		}
 
 		igt_debug("matches=%u/%u\n", matches, n_timer_reports - 1);
-- 
2.16.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2018-02-22  1:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22  1:41 Lionel Landwerlin [this message]
2018-02-22  2:19 ` [igt-dev] ✓ Fi.CI.BAT: success for test/perf: fixup inverted condition Patchwork
2018-02-22  6:36 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-02-22 10:10 ` [igt-dev] [PATCH i-g-t] " Matthew Auld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180222014152.17941-1-lionel.g.landwerlin@intel.com \
    --to=lionel.g.landwerlin@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.