* [igt-dev] [PATCH i-g-t] test/perf: fixup inverted condition
@ 2018-02-22 1:41 Lionel Landwerlin
2018-02-22 2:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Lionel Landwerlin @ 2018-02-22 1:41 UTC (permalink / raw)
To: igt-dev; +Cc: matthew.auld
The previous patch said :
"verify that the time is always longer or equal to the period we've
asked for"
This is an obvious error, it only worked on my machine and the CI
because only one longer period was observed. But another CI run caught
the issue :
https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4280/shard-glkb6/igt@perf@oa-exponents.html
Fixes: c3d11ca104fa ("tests/perf: make oa-exponents subtest more reliable")
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
tests/perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/perf.c b/tests/perf.c
index 05108f5a..c302a355 100644
--- a/tests/perf.c
+++ b/tests/perf.c
@@ -1795,7 +1795,7 @@ test_oa_exponents(void)
oa_report_get_ctx_id(timer_reports[i].report),
delta, delta == expected_timestamp_delta ? "" : "******");
- matches += expected_timestamp_delta >= delta;
+ matches += expected_timestamp_delta <= delta;
}
igt_debug("matches=%u/%u\n", matches, n_timer_reports - 1);
--
2.16.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for test/perf: fixup inverted condition 2018-02-22 1:41 [igt-dev] [PATCH i-g-t] test/perf: fixup inverted condition Lionel Landwerlin @ 2018-02-22 2:19 ` Patchwork 2018-02-22 6:36 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 2018-02-22 10:10 ` [igt-dev] [PATCH i-g-t] " Matthew Auld 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2018-02-22 2:19 UTC (permalink / raw) To: Lionel Landwerlin; +Cc: igt-dev == Series Details == Series: test/perf: fixup inverted condition URL : https://patchwork.freedesktop.org/series/38735/ State : success == Summary == IGT patchset tested on top of latest successful build 1ecc978a69a531858ba799425770062ebeb13888 igt/perf_pmu: Use a self-correcting busy pwm with latest DRM-Tip kernel build CI_DRM_3819 42016703e66b drm-tip: 2018y-02m-21d-21h-26m-53s UTC integration manifest No testlist changes. Test kms_pipe_crc_basic: Subgroup suspend-read-crc-pipe-c: incomplete -> PASS (fi-bxt-dsi) fdo#103927 fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927 fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:417s fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:427s fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:374s fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:489s fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:286s fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:483s fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:484s fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:473s fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:458s fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:560s fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:415s fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:286s fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:508s fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:386s fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:415s fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:453s fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:409s fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:453s fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:491s fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:456s fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:495s fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:586s fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:428s fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:503s fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:519s fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:490s fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:470s fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:408s fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:431s fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:527s fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:397s == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_982/issues.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for test/perf: fixup inverted condition 2018-02-22 1:41 [igt-dev] [PATCH i-g-t] test/perf: fixup inverted condition Lionel Landwerlin 2018-02-22 2:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork @ 2018-02-22 6:36 ` Patchwork 2018-02-22 10:10 ` [igt-dev] [PATCH i-g-t] " Matthew Auld 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2018-02-22 6:36 UTC (permalink / raw) To: Lionel Landwerlin; +Cc: igt-dev == Series Details == Series: test/perf: fixup inverted condition URL : https://patchwork.freedesktop.org/series/38735/ State : failure == Summary == Test kms_flip: Subgroup 2x-plain-flip-ts-check-interruptible: pass -> FAIL (shard-hsw) fdo#100368 Subgroup modeset-vs-vblank-race-interruptible: fail -> PASS (shard-apl) fdo#103060 +1 Test perf: Subgroup oa-exponents: incomplete -> FAIL (shard-apl) fdo#102254 Subgroup polling: pass -> FAIL (shard-hsw) fdo#102252 Test gem_eio: Subgroup in-flight: pass -> INCOMPLETE (shard-apl) Test kms_rotation_crc: Subgroup sprite-rotation-180: fail -> PASS (shard-snb) fdo#103925 Test kms_chv_cursor_fail: Subgroup pipe-b-128x128-top-edge: dmesg-warn -> PASS (shard-snb) fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368 fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060 fdo#102254 https://bugs.freedesktop.org/show_bug.cgi?id=102254 fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252 fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925 shard-apl total:3365 pass:1764 dwarn:1 dfail:0 fail:12 skip:1586 time:11943s shard-hsw total:3465 pass:1766 dwarn:1 dfail:0 fail:4 skip:1693 time:11501s shard-snb total:3465 pass:1358 dwarn:1 dfail:0 fail:2 skip:2104 time:6626s Blacklisted hosts: shard-kbl total:3407 pass:1925 dwarn:1 dfail:0 fail:14 skip:1465 time:9209s == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_982/shards.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] test/perf: fixup inverted condition 2018-02-22 1:41 [igt-dev] [PATCH i-g-t] test/perf: fixup inverted condition Lionel Landwerlin 2018-02-22 2:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2018-02-22 6:36 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork @ 2018-02-22 10:10 ` Matthew Auld 2 siblings, 0 replies; 4+ messages in thread From: Matthew Auld @ 2018-02-22 10:10 UTC (permalink / raw) To: Lionel Landwerlin; +Cc: igt-dev, Matthew Auld On 22 February 2018 at 01:41, Lionel Landwerlin <lionel.g.landwerlin@intel.com> wrote: > The previous patch said : > > "verify that the time is always longer or equal to the period we've > asked for" > > This is an obvious error, it only worked on my machine and the CI > because only one longer period was observed. But another CI run caught > the issue : > > https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4280/shard-glkb6/igt@perf@oa-exponents.html > > Fixes: c3d11ca104fa ("tests/perf: make oa-exponents subtest more reliable") > Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Matthew Auld <matthew.auld@intel.com> _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-22 10:10 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-02-22 1:41 [igt-dev] [PATCH i-g-t] test/perf: fixup inverted condition Lionel Landwerlin 2018-02-22 2:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2018-02-22 6:36 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 2018-02-22 10:10 ` [igt-dev] [PATCH i-g-t] " Matthew Auld
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.