[PATCH v2 ] get_maintainers.pl: Avoid THE_REST when files are added or removed

[PATCH v2 ] get_maintainers.pl: Avoid THE_REST when files are added or removed

[Alan Robinson]

When files are added or removed /dev/null is used as a place
holder name in the patch for the absent file.  Don't try and
find a MAINTAINER for this place holder, it only ever flags
and then spams THE REST, behaviour for a real filename is
unchanged.

Signed-off-by: Alan Robinson <Alan.Robinson@ts.fujitsu.com>
---
v1 - original version
v2 - addresses /dev/null and $lastfile comments from Jan

Tested by pretending to remove xen/common/cpupool.c for
which get_maintainers.pl currently flags 11 addresses, after
this patch only xen-devel and its two maintainers (Juergen and
Dario) get listed. 

Also tested adding a 'dev/null' file which get_maintainer.pl now
accepts and suggests 'THE_REST'.

 scripts/get_maintainer.pl | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 0ce2d367fa..3fb1ad4b69 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -444,10 +444,12 @@ foreach my $file (@ARGV) {
 	    my $patch_line = $_;
 	    if (m/^\+\+\+\s+(\S+)/ or m/^---\s+(\S+)/) {
 		my $filename = $1;
-		$filename =~ s@^[^/]*/@@;
-		$filename =~ s@\n@@;
-		$lastfile = $filename;
-		push(@files, $filename);
+		if ($1 ne "/dev/null") { #Ignore the no-file placeholder
+		    $filename =~ s@^[^/]*/@@;
+		    $filename =~ s@\n@@;
+		    $lastfile = $filename;
+		    push(@files, $filename);
+		}
 		$patch_prefix = "^[+-].*";	#Now parsing the actual patch
 	    } elsif (m/^\@\@ -(\d+),(\d+)/) {
 		if ($email_git_blame) {
-- 
2.14.1

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 ] get_maintainers.pl: Avoid THE_REST when files are added or removed

[Jan Beulich]

>>> On 22.02.18 at 12:12, <Alan.Robinson@ts.fujitsu.com> wrote:
> When files are added or removed /dev/null is used as a place
> holder name in the patch for the absent file.  Don't try and
> find a MAINTAINER for this place holder, it only ever flags
> and then spams THE REST, behaviour for a real filename is
> unchanged.
> 
> Signed-off-by: Alan Robinson <Alan.Robinson@ts.fujitsu.com>

FTR - looks fine to me, but I wouldn't want to put this in without
someone with more Perl knowledge having given their okay.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 ] get_maintainers.pl: Avoid THE_REST when files are added or removed

[Ian Jackson]

Alan Robinson writes ("[PATCH v2 ] get_maintainers.pl: Avoid THE_REST when files are added or removed"):
> When files are added or removed /dev/null is used as a place
> holder name in the patch for the absent file.  Don't try and
> find a MAINTAINER for this place holder, it only ever flags
> and then spams THE REST, behaviour for a real filename is
> unchanged.

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

I have reviewed (but not tested) the Perl and it LGTM.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel