* [PATCH 2/4][v4] driver: mtd: update struct map_info's swap as per map requirement
@ 2018-02-15 11:50 ` Prabhakar Kushwaha
0 siblings, 0 replies; 6+ messages in thread
From: Prabhakar Kushwaha @ 2018-02-15 11:50 UTC (permalink / raw)
To: linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, robh-DgEjT+Ai2ygdnm+yROfE0A,
mark.rutland-5wv7dgnIgG8, shawnguo-DgEjT+Ai2ygdnm+yROfE0A
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
cyrille.pitchen-yU5RGvR974pGWvitb5QawA,
computersforpeace-Re5JQEeQqe8AvxtiuMwx3w,
oss-fOR+EgIDQEHk1uMJSBkQmQ, leoyang.li-3arQi8VN3Tc,
Prabhakar Kushwaha, Jagdish Gediya
It is not necessary for all device's maps to be CFI_HOST_ENDIAN.
Maps device can be Big endian or little endian.
Currently it is being taken care using CONFIG_MTD_CFI_LE_BYTE_SWAP or
CONFIG_MTD_CFI_BE_BYTE_SWAP i.e. compile time.
Now update struct map_info's swap field based on device characteristics
defined in device tree.
Signed-off-by: Jagdish Gediya <jagdish.gediya-3arQi8VN3Tc@public.gmane.org>
Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org>
---
Changes for v2: Incorporated review comments from Boris Brezillon
http://patchwork.ozlabs.org/patch/758381/
Changes for v3: None
Changes for v4: Updated code as per new defined binding of physmap.txt
drivers/mtd/maps/physmap_of_core.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/mtd/maps/physmap_of_core.c b/drivers/mtd/maps/physmap_of_core.c
index b1bd4faecfb2..6eee160dfb3d 100644
--- a/drivers/mtd/maps/physmap_of_core.c
+++ b/drivers/mtd/maps/physmap_of_core.c
@@ -20,6 +20,7 @@
#include <linux/mtd/map.h>
#include <linux/mtd/partitions.h>
#include <linux/mtd/concat.h>
+#include <linux/mtd/cfi_endian.h>
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_platform.h>
@@ -233,6 +234,13 @@ static int of_flash_probe(struct platform_device *dev)
info->list[i].map.bankwidth = be32_to_cpup(width);
info->list[i].map.device_node = dp;
+ if (of_property_read_bool(dp, "big-endian"))
+ info->list[i].map.swap = CFI_BIG_ENDIAN;
+ else if (of_property_read_bool(dp, "little-endian"))
+ info->list[i].map.swap = CFI_LITTLE_ENDIAN;
+ else
+ info->list[i].map.swap = CFI_HOST_ENDIAN;
+
err = of_flash_probe_gemini(dev, dp, &info->list[i].map);
if (err)
goto err_out;
--
2.14.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/4][v4] driver: mtd: update struct map_info's swap as per map requirement
@ 2018-02-15 11:50 ` Prabhakar Kushwaha
0 siblings, 0 replies; 6+ messages in thread
From: Prabhakar Kushwaha @ 2018-02-15 11:50 UTC (permalink / raw)
To: linux-mtd, devicetree, robh, mark.rutland, shawnguo
Cc: linux-arm-kernel, boris.brezillon, cyrille.pitchen,
computersforpeace, oss, leoyang.li, Prabhakar Kushwaha,
Jagdish Gediya
It is not necessary for all device's maps to be CFI_HOST_ENDIAN.
Maps device can be Big endian or little endian.
Currently it is being taken care using CONFIG_MTD_CFI_LE_BYTE_SWAP or
CONFIG_MTD_CFI_BE_BYTE_SWAP i.e. compile time.
Now update struct map_info's swap field based on device characteristics
defined in device tree.
Signed-off-by: Jagdish Gediya <jagdish.gediya@nxp.com>
Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
---
Changes for v2: Incorporated review comments from Boris Brezillon
http://patchwork.ozlabs.org/patch/758381/
Changes for v3: None
Changes for v4: Updated code as per new defined binding of physmap.txt
drivers/mtd/maps/physmap_of_core.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/mtd/maps/physmap_of_core.c b/drivers/mtd/maps/physmap_of_core.c
index b1bd4faecfb2..6eee160dfb3d 100644
--- a/drivers/mtd/maps/physmap_of_core.c
+++ b/drivers/mtd/maps/physmap_of_core.c
@@ -20,6 +20,7 @@
#include <linux/mtd/map.h>
#include <linux/mtd/partitions.h>
#include <linux/mtd/concat.h>
+#include <linux/mtd/cfi_endian.h>
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_platform.h>
@@ -233,6 +234,13 @@ static int of_flash_probe(struct platform_device *dev)
info->list[i].map.bankwidth = be32_to_cpup(width);
info->list[i].map.device_node = dp;
+ if (of_property_read_bool(dp, "big-endian"))
+ info->list[i].map.swap = CFI_BIG_ENDIAN;
+ else if (of_property_read_bool(dp, "little-endian"))
+ info->list[i].map.swap = CFI_LITTLE_ENDIAN;
+ else
+ info->list[i].map.swap = CFI_HOST_ENDIAN;
+
err = of_flash_probe_gemini(dev, dp, &info->list[i].map);
if (err)
goto err_out;
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/4][v4] driver: mtd: update struct map_info's swap as per map requirement
@ 2018-02-15 11:50 ` Prabhakar Kushwaha
0 siblings, 0 replies; 6+ messages in thread
From: Prabhakar Kushwaha @ 2018-02-15 11:50 UTC (permalink / raw)
To: linux-arm-kernel
It is not necessary for all device's maps to be CFI_HOST_ENDIAN.
Maps device can be Big endian or little endian.
Currently it is being taken care using CONFIG_MTD_CFI_LE_BYTE_SWAP or
CONFIG_MTD_CFI_BE_BYTE_SWAP i.e. compile time.
Now update struct map_info's swap field based on device characteristics
defined in device tree.
Signed-off-by: Jagdish Gediya <jagdish.gediya@nxp.com>
Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
---
Changes for v2: Incorporated review comments from Boris Brezillon
http://patchwork.ozlabs.org/patch/758381/
Changes for v3: None
Changes for v4: Updated code as per new defined binding of physmap.txt
drivers/mtd/maps/physmap_of_core.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/mtd/maps/physmap_of_core.c b/drivers/mtd/maps/physmap_of_core.c
index b1bd4faecfb2..6eee160dfb3d 100644
--- a/drivers/mtd/maps/physmap_of_core.c
+++ b/drivers/mtd/maps/physmap_of_core.c
@@ -20,6 +20,7 @@
#include <linux/mtd/map.h>
#include <linux/mtd/partitions.h>
#include <linux/mtd/concat.h>
+#include <linux/mtd/cfi_endian.h>
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_platform.h>
@@ -233,6 +234,13 @@ static int of_flash_probe(struct platform_device *dev)
info->list[i].map.bankwidth = be32_to_cpup(width);
info->list[i].map.device_node = dp;
+ if (of_property_read_bool(dp, "big-endian"))
+ info->list[i].map.swap = CFI_BIG_ENDIAN;
+ else if (of_property_read_bool(dp, "little-endian"))
+ info->list[i].map.swap = CFI_LITTLE_ENDIAN;
+ else
+ info->list[i].map.swap = CFI_HOST_ENDIAN;
+
err = of_flash_probe_gemini(dev, dp, &info->list[i].map);
if (err)
goto err_out;
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/4][v4] driver: mtd: update struct map_info's swap as per map requirement
2018-02-15 11:50 ` Prabhakar Kushwaha
(?)
@ 2018-02-22 10:21 ` Boris Brezillon
-1 siblings, 0 replies; 6+ messages in thread
From: Boris Brezillon @ 2018-02-22 10:21 UTC (permalink / raw)
To: Prabhakar Kushwaha
Cc: mark.rutland, devicetree, boris.brezillon, leoyang.li, oss,
linux-mtd, Jagdish Gediya, cyrille.pitchen, computersforpeace,
shawnguo, robh, linux-arm-kernel
On Thu, 15 Feb 2018 17:20:00 +0530
Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> wrote:
> It is not necessary for all device's maps to be CFI_HOST_ENDIAN.
> Maps device can be Big endian or little endian.
>
> Currently it is being taken care using CONFIG_MTD_CFI_LE_BYTE_SWAP or
> CONFIG_MTD_CFI_BE_BYTE_SWAP i.e. compile time.
>
> Now update struct map_info's swap field based on device characteristics
> defined in device tree.
>
> Signed-off-by: Jagdish Gediya <jagdish.gediya@nxp.com>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> ---
> Changes for v2: Incorporated review comments from Boris Brezillon
> http://patchwork.ozlabs.org/patch/758381/
> Changes for v3: None
> Changes for v4: Updated code as per new defined binding of physmap.txt
>
> drivers/mtd/maps/physmap_of_core.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/mtd/maps/physmap_of_core.c b/drivers/mtd/maps/physmap_of_core.c
> index b1bd4faecfb2..6eee160dfb3d 100644
> --- a/drivers/mtd/maps/physmap_of_core.c
> +++ b/drivers/mtd/maps/physmap_of_core.c
> @@ -20,6 +20,7 @@
> #include <linux/mtd/map.h>
> #include <linux/mtd/partitions.h>
> #include <linux/mtd/concat.h>
> +#include <linux/mtd/cfi_endian.h>
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/of_platform.h>
> @@ -233,6 +234,13 @@ static int of_flash_probe(struct platform_device *dev)
> info->list[i].map.bankwidth = be32_to_cpup(width);
> info->list[i].map.device_node = dp;
>
> + if (of_property_read_bool(dp, "big-endian"))
> + info->list[i].map.swap = CFI_BIG_ENDIAN;
> + else if (of_property_read_bool(dp, "little-endian"))
> + info->list[i].map.swap = CFI_LITTLE_ENDIAN;
> + else
> + info->list[i].map.swap = CFI_HOST_ENDIAN;
> +
Are you sure we want the default to be CFI_HOST_ENDIAN when the
property is not defined? I think we should leave ->swap to 0 and let
the CFI logic use the CFI_DEFAULT_ENDIAN value. What you're doing here
you're likely to break platforms that are not explicitly specifying
endianness in their DT and are instead relying on the Kconfig choice.
I think that was one of Scott's comments on your previous version.
> err = of_flash_probe_gemini(dev, dp, &info->list[i].map);
> if (err)
> goto err_out;
--
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/4][v4] driver: mtd: update struct map_info's swap as per map requirement
@ 2018-02-22 10:21 ` Boris Brezillon
0 siblings, 0 replies; 6+ messages in thread
From: Boris Brezillon @ 2018-02-22 10:21 UTC (permalink / raw)
To: Prabhakar Kushwaha
Cc: linux-mtd, devicetree, robh, mark.rutland, shawnguo,
boris.brezillon, leoyang.li, oss, Jagdish Gediya,
cyrille.pitchen, computersforpeace, linux-arm-kernel
On Thu, 15 Feb 2018 17:20:00 +0530
Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> wrote:
> It is not necessary for all device's maps to be CFI_HOST_ENDIAN.
> Maps device can be Big endian or little endian.
>
> Currently it is being taken care using CONFIG_MTD_CFI_LE_BYTE_SWAP or
> CONFIG_MTD_CFI_BE_BYTE_SWAP i.e. compile time.
>
> Now update struct map_info's swap field based on device characteristics
> defined in device tree.
>
> Signed-off-by: Jagdish Gediya <jagdish.gediya@nxp.com>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> ---
> Changes for v2: Incorporated review comments from Boris Brezillon
> http://patchwork.ozlabs.org/patch/758381/
> Changes for v3: None
> Changes for v4: Updated code as per new defined binding of physmap.txt
>
> drivers/mtd/maps/physmap_of_core.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/mtd/maps/physmap_of_core.c b/drivers/mtd/maps/physmap_of_core.c
> index b1bd4faecfb2..6eee160dfb3d 100644
> --- a/drivers/mtd/maps/physmap_of_core.c
> +++ b/drivers/mtd/maps/physmap_of_core.c
> @@ -20,6 +20,7 @@
> #include <linux/mtd/map.h>
> #include <linux/mtd/partitions.h>
> #include <linux/mtd/concat.h>
> +#include <linux/mtd/cfi_endian.h>
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/of_platform.h>
> @@ -233,6 +234,13 @@ static int of_flash_probe(struct platform_device *dev)
> info->list[i].map.bankwidth = be32_to_cpup(width);
> info->list[i].map.device_node = dp;
>
> + if (of_property_read_bool(dp, "big-endian"))
> + info->list[i].map.swap = CFI_BIG_ENDIAN;
> + else if (of_property_read_bool(dp, "little-endian"))
> + info->list[i].map.swap = CFI_LITTLE_ENDIAN;
> + else
> + info->list[i].map.swap = CFI_HOST_ENDIAN;
> +
Are you sure we want the default to be CFI_HOST_ENDIAN when the
property is not defined? I think we should leave ->swap to 0 and let
the CFI logic use the CFI_DEFAULT_ENDIAN value. What you're doing here
you're likely to break platforms that are not explicitly specifying
endianness in their DT and are instead relying on the Kconfig choice.
I think that was one of Scott's comments on your previous version.
> err = of_flash_probe_gemini(dev, dp, &info->list[i].map);
> if (err)
> goto err_out;
--
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/4][v4] driver: mtd: update struct map_info's swap as per map requirement
@ 2018-02-22 10:21 ` Boris Brezillon
0 siblings, 0 replies; 6+ messages in thread
From: Boris Brezillon @ 2018-02-22 10:21 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 15 Feb 2018 17:20:00 +0530
Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> wrote:
> It is not necessary for all device's maps to be CFI_HOST_ENDIAN.
> Maps device can be Big endian or little endian.
>
> Currently it is being taken care using CONFIG_MTD_CFI_LE_BYTE_SWAP or
> CONFIG_MTD_CFI_BE_BYTE_SWAP i.e. compile time.
>
> Now update struct map_info's swap field based on device characteristics
> defined in device tree.
>
> Signed-off-by: Jagdish Gediya <jagdish.gediya@nxp.com>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> ---
> Changes for v2: Incorporated review comments from Boris Brezillon
> http://patchwork.ozlabs.org/patch/758381/
> Changes for v3: None
> Changes for v4: Updated code as per new defined binding of physmap.txt
>
> drivers/mtd/maps/physmap_of_core.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/mtd/maps/physmap_of_core.c b/drivers/mtd/maps/physmap_of_core.c
> index b1bd4faecfb2..6eee160dfb3d 100644
> --- a/drivers/mtd/maps/physmap_of_core.c
> +++ b/drivers/mtd/maps/physmap_of_core.c
> @@ -20,6 +20,7 @@
> #include <linux/mtd/map.h>
> #include <linux/mtd/partitions.h>
> #include <linux/mtd/concat.h>
> +#include <linux/mtd/cfi_endian.h>
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/of_platform.h>
> @@ -233,6 +234,13 @@ static int of_flash_probe(struct platform_device *dev)
> info->list[i].map.bankwidth = be32_to_cpup(width);
> info->list[i].map.device_node = dp;
>
> + if (of_property_read_bool(dp, "big-endian"))
> + info->list[i].map.swap = CFI_BIG_ENDIAN;
> + else if (of_property_read_bool(dp, "little-endian"))
> + info->list[i].map.swap = CFI_LITTLE_ENDIAN;
> + else
> + info->list[i].map.swap = CFI_HOST_ENDIAN;
> +
Are you sure we want the default to be CFI_HOST_ENDIAN when the
property is not defined? I think we should leave ->swap to 0 and let
the CFI logic use the CFI_DEFAULT_ENDIAN value. What you're doing here
you're likely to break platforms that are not explicitly specifying
endianness in their DT and are instead relying on the Kconfig choice.
I think that was one of Scott's comments on your previous version.
> err = of_flash_probe_gemini(dev, dp, &info->list[i].map);
> if (err)
> goto err_out;
--
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-22 10:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-15 11:50 [PATCH 2/4][v4] driver: mtd: update struct map_info's swap as per map requirement Prabhakar Kushwaha
2018-02-15 11:50 ` Prabhakar Kushwaha
2018-02-15 11:50 ` Prabhakar Kushwaha
2018-02-22 10:21 ` Boris Brezillon
2018-02-22 10:21 ` Boris Brezillon
2018-02-22 10:21 ` Boris Brezillon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.