From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-trace-users@vger.kernel.org,
linux-kselftest@vger.kernel.org, shuah@kernel.org
Subject: Re: [PATCH v2 01/17] tracing: probeevent: Fix to support minus offset from symbol
Date: Thu, 22 Feb 2018 15:35:14 +0900 [thread overview]
Message-ID: <20180222153514.db309d98bbd2b741f7a76dd6@kernel.org> (raw)
In-Reply-To: <20180221205341.3fd69b35@gandalf.local.home>
On Wed, 21 Feb 2018 20:53:41 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Thu, 22 Feb 2018 08:41:53 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > Hi Steve,
> >
> > Could you pick this separately since this is a bugfix?
> >
>
> Yes definitely. I'll have to run my tests on it too, and I'll send it
> as urgent (current -rc release).
>
> Although you didn't mark it for stable. Which commit does it fix?
Wait, it actually fixes the 2fba0c8867af ("tracing/kprobes: Fix
probe offset to be unsigned") but I found that I was doing the
opposite thing...
OK, I'll update this to add a sanity check for kprobe.offset.
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: mhiramat at kernel.org (Masami Hiramatsu)
Subject: [PATCH v2 01/17] tracing: probeevent: Fix to support minus offset from symbol
Date: Thu, 22 Feb 2018 15:35:14 +0900 [thread overview]
Message-ID: <20180222153514.db309d98bbd2b741f7a76dd6@kernel.org> (raw)
In-Reply-To: <20180221205341.3fd69b35@gandalf.local.home>
On Wed, 21 Feb 2018 20:53:41 -0500
Steven Rostedt <rostedt at goodmis.org> wrote:
> On Thu, 22 Feb 2018 08:41:53 +0900
> Masami Hiramatsu <mhiramat at kernel.org> wrote:
>
> > Hi Steve,
> >
> > Could you pick this separately since this is a bugfix?
> >
>
> Yes definitely. I'll have to run my tests on it too, and I'll send it
> as urgent (current -rc release).
>
> Although you didn't mark it for stable. Which commit does it fix?
Wait, it actually fixes the 2fba0c8867af ("tracing/kprobes: Fix
probe offset to be unsigned") but I found that I was doing the
opposite thing...
OK, I'll update this to add a sanity check for kprobe.offset.
Thank you,
--
Masami Hiramatsu <mhiramat at kernel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: mhiramat@kernel.org (Masami Hiramatsu)
Subject: [PATCH v2 01/17] tracing: probeevent: Fix to support minus offset from symbol
Date: Thu, 22 Feb 2018 15:35:14 +0900 [thread overview]
Message-ID: <20180222153514.db309d98bbd2b741f7a76dd6@kernel.org> (raw)
Message-ID: <20180222063514.c4IucSvPlvS8m6hDWQx98b46UlBuINRrolYDg56Gy6Y@z> (raw)
In-Reply-To: <20180221205341.3fd69b35@gandalf.local.home>
On Wed, 21 Feb 2018 20:53:41 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Thu, 22 Feb 2018 08:41:53 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > Hi Steve,
> >
> > Could you pick this separately since this is a bugfix?
> >
>
> Yes definitely. I'll have to run my tests on it too, and I'll send it
> as urgent (current -rc release).
>
> Although you didn't mark it for stable. Which commit does it fix?
Wait, it actually fixes the 2fba0c8867af ("tracing/kprobes: Fix
probe offset to be unsigned") but I found that I was doing the
opposite thing...
OK, I'll update this to add a sanity check for kprobe.offset.
Thank you,
--
Masami Hiramatsu <mhiramat at kernel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-02-22 6:35 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 14:54 [PATCH v2 00/17] tracing: probeevent: Improve fetcharg features Masami Hiramatsu
2018-02-21 14:54 ` Masami Hiramatsu
2018-02-21 14:54 ` mhiramat
2018-02-21 14:54 ` [PATCH v2 01/17] tracing: probeevent: Fix to support minus offset from symbol Masami Hiramatsu
2018-02-21 14:54 ` Masami Hiramatsu
2018-02-21 14:54 ` mhiramat
2018-02-21 23:41 ` Masami Hiramatsu
2018-02-21 23:41 ` Masami Hiramatsu
2018-02-21 23:41 ` mhiramat
2018-02-22 1:53 ` Steven Rostedt
2018-02-22 1:53 ` Steven Rostedt
2018-02-22 1:53 ` rostedt
2018-02-22 6:35 ` Masami Hiramatsu [this message]
2018-02-22 6:35 ` Masami Hiramatsu
2018-02-22 6:35 ` mhiramat
2018-02-22 7:45 ` [BUGFIX PATCH v2.1] " Masami Hiramatsu
2018-02-22 7:45 ` Masami Hiramatsu
2018-02-22 7:45 ` mhiramat
2018-02-23 0:15 ` Namhyung Kim
2018-02-23 0:15 ` Namhyung Kim
2018-02-23 0:15 ` namhyung
2018-02-23 9:44 ` Masami Hiramatsu
2018-02-23 9:44 ` Masami Hiramatsu
2018-02-23 9:44 ` mhiramat
2018-02-21 14:55 ` [PATCH v2 02/17] selftests: ftrace: Add probe event argument syntax testcase Masami Hiramatsu
2018-02-21 14:55 ` Masami Hiramatsu
2018-02-21 14:55 ` mhiramat
2018-02-21 14:55 ` [PATCH v2 03/17] selftests: ftrace: Add a testcase for string type with kprobe_event Masami Hiramatsu
2018-02-21 14:55 ` Masami Hiramatsu
2018-02-21 14:55 ` mhiramat
2018-02-21 14:56 ` [PATCH v2 04/17] tracing: probeevent: Cleanup print argument functions Masami Hiramatsu
2018-02-21 14:56 ` Masami Hiramatsu
2018-02-21 14:56 ` mhiramat
2018-02-21 14:56 ` [PATCH v2 05/17] tracing: probeevent: Cleanup argument field definition Masami Hiramatsu
2018-02-21 14:56 ` Masami Hiramatsu
2018-02-21 14:56 ` mhiramat
2018-02-21 14:57 ` [PATCH v2 06/17] tracing: probeevent: Remove NOKPROBE_SYMBOL from print functions Masami Hiramatsu
2018-02-21 14:57 ` Masami Hiramatsu
2018-02-21 14:57 ` mhiramat
2018-02-21 14:57 ` [PATCH v2 07/17] tracing: probeevent: Introduce new argument fetching code Masami Hiramatsu
2018-02-21 14:57 ` Masami Hiramatsu
2018-02-21 14:57 ` mhiramat
2018-02-23 4:30 ` Namhyung Kim
2018-02-23 4:30 ` Namhyung Kim
2018-02-23 4:30 ` namhyung
2018-02-23 9:43 ` Masami Hiramatsu
2018-02-23 9:43 ` Masami Hiramatsu
2018-02-23 9:43 ` mhiramat
2018-02-21 14:58 ` [PATCH v2 08/17] tracing: probeevent: Return consumed bytes of dynamic area Masami Hiramatsu
2018-02-21 14:58 ` Masami Hiramatsu
2018-02-21 14:58 ` mhiramat
2018-02-21 14:58 ` [PATCH v2 09/17] tracing: probeevent: Append traceprobe_ for exported function Masami Hiramatsu
2018-02-21 14:58 ` Masami Hiramatsu
2018-02-21 14:58 ` mhiramat
2018-02-21 14:59 ` [PATCH v2 10/17] tracing: probeevent: Unify fetch_insn processing common part Masami Hiramatsu
2018-02-21 14:59 ` Masami Hiramatsu
2018-02-21 14:59 ` mhiramat
2018-02-21 14:59 ` [PATCH v2 11/17] tracing: probeevent: Add symbol type Masami Hiramatsu
2018-02-21 14:59 ` Masami Hiramatsu
2018-02-21 14:59 ` mhiramat
2018-02-21 15:00 ` [PATCH v2 12/17] x86: ptrace: Add function argument access API Masami Hiramatsu
2018-02-21 15:00 ` Masami Hiramatsu
2018-02-21 15:00 ` mhiramat
2018-02-21 15:00 ` [PATCH v2 13/17] tracing: probeevent: Add $argN for accessing function args Masami Hiramatsu
2018-02-21 15:00 ` Masami Hiramatsu
2018-02-21 15:00 ` mhiramat
2018-02-22 8:35 ` Masami Hiramatsu
2018-02-22 8:35 ` Masami Hiramatsu
2018-02-22 8:35 ` mhiramat
2018-02-21 15:01 ` [PATCH v2 14/17] tracing: probeevent: Add array type support Masami Hiramatsu
2018-02-21 15:01 ` Masami Hiramatsu
2018-02-21 15:01 ` mhiramat
2018-02-21 15:01 ` [PATCH v2 15/17] selftests: ftrace: Add a testcase for symbol type Masami Hiramatsu
2018-02-21 15:01 ` Masami Hiramatsu
2018-02-21 15:01 ` mhiramat
2018-02-22 11:43 ` Masami Hiramatsu
2018-02-22 11:43 ` Masami Hiramatsu
2018-02-22 11:43 ` mhiramat
2018-02-21 15:01 ` [PATCH v2 16/17] selftests: ftrace: Add a testcase for $argN with kprobe_event Masami Hiramatsu
2018-02-21 15:01 ` Masami Hiramatsu
2018-02-21 15:01 ` mhiramat
2018-02-21 15:02 ` [PATCH v2 17/17] selftests: ftrace: Add a testcase for array type " Masami Hiramatsu
2018-02-21 15:02 ` Masami Hiramatsu
2018-02-21 15:02 ` mhiramat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180222153514.db309d98bbd2b741f7a76dd6@kernel.org \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.