* [PATCH RFC] drm/sun4i: Enable the output on the pins (tcon0)
@ 2018-02-22 16:12 ` megous at megous.com
0 siblings, 0 replies; 6+ messages in thread
From: megous @ 2018-02-22 16:12 UTC (permalink / raw)
To: dev
Cc: Ondrej Jirman, Maxime Ripard, David Airlie, Chen-Yu Tsai,
open list:DRM DRIVERS FOR ALLWINNER A10,
moderated list:ARM/Allwinner sunXi SoC support, open list
From: Ondrej Jirman <megous@megous.com>
I noticed that with 4.16-rc1 LVDS output on A83T based TBS A711 tablet doesn't
work (there's output but it's garbled). I compared some older patches for LVDS
support with the mainlined ones and this change is missing from mainline Linux.
I don't know what the register does exactly and the harcoded register value
doesn't inspire much confidence that it will work in a general case, so I'm
sending this RFC.
This patch fixes the issue on A83T.
Signed-off-by: Ondrej Jirman <megous@megous.com>
---
drivers/gpu/drm/sun4i/sun4i_tcon.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c
index 3c15cf24b503..51740ddb4b32 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
+++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
@@ -335,6 +335,9 @@ static void sun4i_tcon0_mode_set_lvds(struct sun4i_tcon *tcon,
regmap_update_bits(tcon->regs, SUN4I_TCON_GCTL_REG,
SUN4I_TCON_GCTL_IOMAP_MASK,
SUN4I_TCON_GCTL_IOMAP_TCON0);
+
+ /* Enable the output on the pins */
+ regmap_write(tcon->regs, SUN4I_TCON0_IO_TRI_REG, 0xe0000000);
}
static void sun4i_tcon0_mode_set_rgb(struct sun4i_tcon *tcon,
--
2.16.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH RFC] drm/sun4i: Enable the output on the pins (tcon0)
@ 2018-02-22 16:12 ` megous at megous.com
0 siblings, 0 replies; 6+ messages in thread
From: megous at megous.com @ 2018-02-22 16:12 UTC (permalink / raw)
To: linux-arm-kernel
From: Ondrej Jirman <megous@megous.com>
I noticed that with 4.16-rc1 LVDS output on A83T based TBS A711 tablet doesn't
work (there's output but it's garbled). I compared some older patches for LVDS
support with the mainlined ones and this change is missing from mainline Linux.
I don't know what the register does exactly and the harcoded register value
doesn't inspire much confidence that it will work in a general case, so I'm
sending this RFC.
This patch fixes the issue on A83T.
Signed-off-by: Ondrej Jirman <megous@megous.com>
---
drivers/gpu/drm/sun4i/sun4i_tcon.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c
index 3c15cf24b503..51740ddb4b32 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
+++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
@@ -335,6 +335,9 @@ static void sun4i_tcon0_mode_set_lvds(struct sun4i_tcon *tcon,
regmap_update_bits(tcon->regs, SUN4I_TCON_GCTL_REG,
SUN4I_TCON_GCTL_IOMAP_MASK,
SUN4I_TCON_GCTL_IOMAP_TCON0);
+
+ /* Enable the output on the pins */
+ regmap_write(tcon->regs, SUN4I_TCON0_IO_TRI_REG, 0xe0000000);
}
static void sun4i_tcon0_mode_set_rgb(struct sun4i_tcon *tcon,
--
2.16.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH RFC] drm/sun4i: Enable the output on the pins (tcon0)
@ 2018-02-22 16:12 ` megous at megous.com
0 siblings, 0 replies; 6+ messages in thread
From: megous via linux-sunxi @ 2018-02-22 16:12 UTC (permalink / raw)
To: dev-3kdeTeqwOZ9EV1b7eY7vFQ
Cc: Ondrej Jirman, Maxime Ripard, David Airlie, Chen-Yu Tsai,
open list:DRM DRIVERS FOR ALLWINNER A10,
moderated list:ARM/Allwinner sunXi SoC support, open list
From: Ondrej Jirman <megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org>
I noticed that with 4.16-rc1 LVDS output on A83T based TBS A711 tablet doesn't
work (there's output but it's garbled). I compared some older patches for LVDS
support with the mainlined ones and this change is missing from mainline Linux.
I don't know what the register does exactly and the harcoded register value
doesn't inspire much confidence that it will work in a general case, so I'm
sending this RFC.
This patch fixes the issue on A83T.
Signed-off-by: Ondrej Jirman <megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org>
---
drivers/gpu/drm/sun4i/sun4i_tcon.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c
index 3c15cf24b503..51740ddb4b32 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
+++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
@@ -335,6 +335,9 @@ static void sun4i_tcon0_mode_set_lvds(struct sun4i_tcon *tcon,
regmap_update_bits(tcon->regs, SUN4I_TCON_GCTL_REG,
SUN4I_TCON_GCTL_IOMAP_MASK,
SUN4I_TCON_GCTL_IOMAP_TCON0);
+
+ /* Enable the output on the pins */
+ regmap_write(tcon->regs, SUN4I_TCON0_IO_TRI_REG, 0xe0000000);
}
static void sun4i_tcon0_mode_set_rgb(struct sun4i_tcon *tcon,
--
2.16.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH RFC] drm/sun4i: Enable the output on the pins (tcon0)
2018-02-22 16:12 ` megous at megous.com
(?)
@ 2018-02-26 9:13 ` Maxime Ripard
-1 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2018-02-26 9:13 UTC (permalink / raw)
To: megous
Cc: dev, David Airlie, Chen-Yu Tsai,
open list:DRM DRIVERS FOR ALLWINNER A10,
moderated list:ARM/Allwinner sunXi SoC support, open list
[-- Attachment #1: Type: text/plain, Size: 789 bytes --]
On Thu, Feb 22, 2018 at 05:12:17PM +0100, megous@megous.com wrote:
> From: Ondrej Jirman <megous@megous.com>
>
> I noticed that with 4.16-rc1 LVDS output on A83T based TBS A711 tablet doesn't
> work (there's output but it's garbled). I compared some older patches for LVDS
> support with the mainlined ones and this change is missing from mainline Linux.
>
> I don't know what the register does exactly and the harcoded register value
> doesn't inspire much confidence that it will work in a general case, so I'm
> sending this RFC.
>
> This patch fixes the issue on A83T.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
Applied, thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH RFC] drm/sun4i: Enable the output on the pins (tcon0)
@ 2018-02-26 9:13 ` Maxime Ripard
0 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2018-02-26 9:13 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Feb 22, 2018 at 05:12:17PM +0100, megous at megous.com wrote:
> From: Ondrej Jirman <megous@megous.com>
>
> I noticed that with 4.16-rc1 LVDS output on A83T based TBS A711 tablet doesn't
> work (there's output but it's garbled). I compared some older patches for LVDS
> support with the mainlined ones and this change is missing from mainline Linux.
>
> I don't know what the register does exactly and the harcoded register value
> doesn't inspire much confidence that it will work in a general case, so I'm
> sending this RFC.
>
> This patch fixes the issue on A83T.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
Applied, thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180226/342085a6/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RFC] drm/sun4i: Enable the output on the pins (tcon0)
@ 2018-02-26 9:13 ` Maxime Ripard
0 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2018-02-26 9:13 UTC (permalink / raw)
To: megous
Cc: dev, open list, open list:DRM DRIVERS FOR ALLWINNER A10,
David Airlie, Chen-Yu Tsai,
moderated list:ARM/Allwinner sunXi SoC support
[-- Attachment #1.1: Type: text/plain, Size: 789 bytes --]
On Thu, Feb 22, 2018 at 05:12:17PM +0100, megous@megous.com wrote:
> From: Ondrej Jirman <megous@megous.com>
>
> I noticed that with 4.16-rc1 LVDS output on A83T based TBS A711 tablet doesn't
> work (there's output but it's garbled). I compared some older patches for LVDS
> support with the mainlined ones and this change is missing from mainline Linux.
>
> I don't know what the register does exactly and the harcoded register value
> doesn't inspire much confidence that it will work in a general case, so I'm
> sending this RFC.
>
> This patch fixes the issue on A83T.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
Applied, thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-26 9:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-22 16:12 [PATCH RFC] drm/sun4i: Enable the output on the pins (tcon0) megous
2018-02-22 16:12 ` megous via linux-sunxi
2018-02-22 16:12 ` megous at megous.com
2018-02-26 9:13 ` Maxime Ripard
2018-02-26 9:13 ` Maxime Ripard
2018-02-26 9:13 ` Maxime Ripard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.