All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] e1000e : fix PCIe AER error injection
@ 2018-02-23 15:02 Thomas Tai
  0 siblings, 0 replies; only message in thread
From: Thomas Tai @ 2018-02-23 15:02 UTC (permalink / raw)
  To: thomas.tai, qemu-devel, dmitry.fleytman

When using qemu pcie_aer_inject_error command to inject
an error on e1000e, the error is not sent to the guest.
The problem is caused by the e1000e did not initialize
the device error control registers mask. Since the
default mask is 0, any value written to the registers
will be masked off.

Followed pci-bridge/xio3130_downstream.c to use
pcie_cap_deverr_init() to initialize the mask.

Signed-off-by: Thomas Tai <thomas.tai@oracle.com>
---
 hw/net/e1000e.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/net/e1000e.c b/hw/net/e1000e.c
index 191398a3d5..1ebcaa2d19 100644
--- a/hw/net/e1000e.c
+++ b/hw/net/e1000e.c
@@ -478,6 +478,7 @@ static void e1000e_pci_realize(PCIDevice *pci_dev, Error **errp)
         hw_error("Failed to initialize PM capability");
     }
 
+    pcie_cap_deverr_init(pci_dev);
     if (pcie_aer_init(pci_dev, PCI_ERR_VER, e1000e_aer_offset,
                       PCI_ERR_SIZEOF, NULL) < 0) {
         hw_error("Failed to initialize AER capability");
-- 
2.14.1

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2018-02-23 15:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-23 15:02 [Qemu-devel] [PATCH] e1000e : fix PCIe AER error injection Thomas Tai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.