From: Shawn Guo <shawnguo@kernel.org> To: Bai Ping <ping.bai@nxp.com>, Lucas Stach <l.stach@pengutronix.de> Cc: sboyd@kernel.org, robh+dt@kernel.org, kernel@pengutronix.de, aisheng.dong@nxp.com, linux-imx@nxp.com, jacky.baip@gmail.com, fabio.estevam@nxp.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 2/4] driver: clk: imx: add new gate/gate2 wrapper funtion Date: Sat, 24 Feb 2018 11:12:33 +0800 [thread overview] Message-ID: <20180224031232.GW3217@dragon> (raw) In-Reply-To: <1517968819-12869-2-git-send-email-ping.bai@nxp.com> + Lucas On Wed, Feb 07, 2018 at 10:00:17AM +0800, Bai Ping wrote: > Add new gate/gate2 wrapper function to register clocks with optional flags. > > Signed-off-by: Bai Ping <ping.bai@nxp.com> > --- > drivers/clk/imx/clk.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/clk/imx/clk.h b/drivers/clk/imx/clk.h > index d69c4bb..8076ec0 100644 > --- a/drivers/clk/imx/clk.h > +++ b/drivers/clk/imx/clk.h > @@ -123,6 +123,13 @@ static inline struct clk *imx_clk_gate(const char *name, const char *parent, > shift, 0, &imx_ccm_lock); > } > > +static inline struct clk *imx_clk_gate_flags(const char *name, const char *parent, > + void __iomem *reg, u8 shift, unsigned long flags) > +{ > + return clk_register_gate(NULL, name, parent, flags | CLK_SET_RATE_PARENT, reg, > + shift, 0, &imx_ccm_lock); > +} > + > static inline struct clk *imx_clk_gate_dis(const char *name, const char *parent, > void __iomem *reg, u8 shift) > { > @@ -137,6 +144,13 @@ static inline struct clk *imx_clk_gate2(const char *name, const char *parent, > shift, 0x3, 0, &imx_ccm_lock, NULL); > } > > +static inline struct clk *imx_clk_gate2_flags(const char *name, const char *parent, > + void __iomem *reg, u8 shift, unsigned long flags) > +{ > + return clk_register_gate2(NULL, name, parent, flags | CLK_SET_RATE_PARENT, reg, > + shift, 0x3, 0, &imx_ccm_lock, NULL); > +} > + Lucas' patch 'clk: imx: add clock driver for i.MX8MQ CCM' [1] adds an imx_clk_gate2_flags() as well, but with different implementation. Can you guys talk to each other to sort it out? Shawn [1] https://patchwork.kernel.org/patch/10195759/ > static inline struct clk *imx_clk_gate2_shared(const char *name, > const char *parent, void __iomem *reg, u8 shift, > unsigned int *share_count) > -- > 1.9.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: shawnguo@kernel.org (Shawn Guo) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 2/4] driver: clk: imx: add new gate/gate2 wrapper funtion Date: Sat, 24 Feb 2018 11:12:33 +0800 [thread overview] Message-ID: <20180224031232.GW3217@dragon> (raw) In-Reply-To: <1517968819-12869-2-git-send-email-ping.bai@nxp.com> + Lucas On Wed, Feb 07, 2018 at 10:00:17AM +0800, Bai Ping wrote: > Add new gate/gate2 wrapper function to register clocks with optional flags. > > Signed-off-by: Bai Ping <ping.bai@nxp.com> > --- > drivers/clk/imx/clk.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/clk/imx/clk.h b/drivers/clk/imx/clk.h > index d69c4bb..8076ec0 100644 > --- a/drivers/clk/imx/clk.h > +++ b/drivers/clk/imx/clk.h > @@ -123,6 +123,13 @@ static inline struct clk *imx_clk_gate(const char *name, const char *parent, > shift, 0, &imx_ccm_lock); > } > > +static inline struct clk *imx_clk_gate_flags(const char *name, const char *parent, > + void __iomem *reg, u8 shift, unsigned long flags) > +{ > + return clk_register_gate(NULL, name, parent, flags | CLK_SET_RATE_PARENT, reg, > + shift, 0, &imx_ccm_lock); > +} > + > static inline struct clk *imx_clk_gate_dis(const char *name, const char *parent, > void __iomem *reg, u8 shift) > { > @@ -137,6 +144,13 @@ static inline struct clk *imx_clk_gate2(const char *name, const char *parent, > shift, 0x3, 0, &imx_ccm_lock, NULL); > } > > +static inline struct clk *imx_clk_gate2_flags(const char *name, const char *parent, > + void __iomem *reg, u8 shift, unsigned long flags) > +{ > + return clk_register_gate2(NULL, name, parent, flags | CLK_SET_RATE_PARENT, reg, > + shift, 0x3, 0, &imx_ccm_lock, NULL); > +} > + Lucas' patch 'clk: imx: add clock driver for i.MX8MQ CCM' [1] adds an imx_clk_gate2_flags() as well, but with different implementation. Can you guys talk to each other to sort it out? Shawn [1] https://patchwork.kernel.org/patch/10195759/ > static inline struct clk *imx_clk_gate2_shared(const char *name, > const char *parent, void __iomem *reg, u8 shift, > unsigned int *share_count) > -- > 1.9.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-02-24 3:12 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-07 2:00 [PATCH v3 1/4] driver: clk: imx: Add CLK_IS_CRITICAL flag for busy diviver and busy mux Bai Ping 2018-02-07 2:00 ` Bai Ping 2018-02-07 2:00 ` [PATCH v3 2/4] driver: clk: imx: add new gate/gate2 wrapper funtion Bai Ping 2018-02-07 2:00 ` Bai Ping 2018-02-24 3:12 ` Shawn Guo [this message] 2018-02-24 3:12 ` Shawn Guo 2018-02-24 6:05 ` Jacky Bai 2018-02-24 6:05 ` Jacky Bai 2018-02-07 2:00 ` [PATCH v3 3/4] Document: dt: binding: imx: update clock doc for imx6sll Bai Ping 2018-02-07 2:00 ` Bai Ping 2018-02-24 3:20 ` Shawn Guo 2018-02-24 3:20 ` Shawn Guo 2018-02-24 6:07 ` Jacky Bai 2018-02-24 6:07 ` Jacky Bai 2018-02-07 2:00 ` [PATCH v3 4/4] driver: clk: imx: add clock driver " Bai Ping 2018-02-07 2:00 ` Bai Ping 2018-02-24 3:45 ` Shawn Guo 2018-02-24 3:45 ` Shawn Guo 2018-02-24 6:19 ` Jacky Bai 2018-02-24 6:19 ` Jacky Bai 2018-02-22 9:42 ` [PATCH v3 1/4] driver: clk: imx: Add CLK_IS_CRITICAL flag for busy diviver and busy mux Shawn Guo 2018-02-22 9:42 ` Shawn Guo 2018-02-22 9:52 ` Jacky Bai 2018-02-22 9:52 ` Jacky Bai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180224031232.GW3217@dragon \ --to=shawnguo@kernel.org \ --cc=aisheng.dong@nxp.com \ --cc=fabio.estevam@nxp.com \ --cc=jacky.baip@gmail.com \ --cc=kernel@pengutronix.de \ --cc=l.stach@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=ping.bai@nxp.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.