* [PATCH] clocksource/drivers/fsl_ftm_timer: fix error return checking
@ 2018-02-26 11:36 Colin King
2018-02-26 13:01 ` [tip:timers/urgent] clocksource/drivers/fsl_ftm_timer: Fix " tip-bot for Colin Ian King
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-02-26 11:36 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The error checks on freq for a negative error return always fails because
freq is unsigned and can never be negative. Fix this by making freq a
signed long.
Detected with Coccinelle:
drivers/clocksource/fsl_ftm_timer.c:287:5-9: WARNING: Unsigned expression
compared with zero: freq <= 0
drivers/clocksource/fsl_ftm_timer.c:291:5-9: WARNING: Unsigned expression
compared with zero: freq <= 0
Fixes: 2529c3a33079 ("clocksource: Add Freescale FlexTimer Module (FTM) timer support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/clocksource/fsl_ftm_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/fsl_ftm_timer.c b/drivers/clocksource/fsl_ftm_timer.c
index 3ee7e6fea621..846d18daf893 100644
--- a/drivers/clocksource/fsl_ftm_timer.c
+++ b/drivers/clocksource/fsl_ftm_timer.c
@@ -281,7 +281,7 @@ static int __init __ftm_clk_init(struct device_node *np, char *cnt_name,
static unsigned long __init ftm_clk_init(struct device_node *np)
{
- unsigned long freq;
+ long freq;
freq = __ftm_clk_init(np, "ftm-evt-counter-en", "ftm-evt");
if (freq <= 0)
--
2.15.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:timers/urgent] clocksource/drivers/fsl_ftm_timer: Fix error return checking
2018-02-26 11:36 [PATCH] clocksource/drivers/fsl_ftm_timer: fix error return checking Colin King
@ 2018-02-26 13:01 ` tip-bot for Colin Ian King
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Colin Ian King @ 2018-02-26 13:01 UTC (permalink / raw)
To: linux-tip-commits
Cc: mingo, colin.king, daniel.lezcano, hpa, tglx, linux-kernel
Commit-ID: f287eb9013ccf199cbfa4eabd80c36fedfc15a73
Gitweb: https://git.kernel.org/tip/f287eb9013ccf199cbfa4eabd80c36fedfc15a73
Author: Colin Ian King <colin.king@canonical.com>
AuthorDate: Mon, 26 Feb 2018 11:36:14 +0000
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 26 Feb 2018 13:56:05 +0100
clocksource/drivers/fsl_ftm_timer: Fix error return checking
The error checks on freq for a negative error return always fails because
freq is unsigned and can never be negative. Fix this by making freq a
signed long.
Detected with Coccinelle:
drivers/clocksource/fsl_ftm_timer.c:287:5-9: WARNING: Unsigned expression
compared with zero: freq <= 0
drivers/clocksource/fsl_ftm_timer.c:291:5-9: WARNING: Unsigned expression
compared with zero: freq <= 0
Fixes: 2529c3a33079 ("clocksource: Add Freescale FlexTimer Module (FTM) timer support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: kernel-janitors@vger.kernel.org
Link: https://lkml.kernel.org/r/20180226113614.3092-1-colin.king@canonical.com
---
drivers/clocksource/fsl_ftm_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/fsl_ftm_timer.c b/drivers/clocksource/fsl_ftm_timer.c
index 3ee7e6fea621..846d18daf893 100644
--- a/drivers/clocksource/fsl_ftm_timer.c
+++ b/drivers/clocksource/fsl_ftm_timer.c
@@ -281,7 +281,7 @@ static int __init __ftm_clk_init(struct device_node *np, char *cnt_name,
static unsigned long __init ftm_clk_init(struct device_node *np)
{
- unsigned long freq;
+ long freq;
freq = __ftm_clk_init(np, "ftm-evt-counter-en", "ftm-evt");
if (freq <= 0)
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-26 13:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-26 11:36 [PATCH] clocksource/drivers/fsl_ftm_timer: fix error return checking Colin King
2018-02-26 13:01 ` [tip:timers/urgent] clocksource/drivers/fsl_ftm_timer: Fix " tip-bot for Colin Ian King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.