[meta-oe][PATCH 1/2] cppzmq: 4.2.3 update

[meta-oe][PATCH 1/2] cppzmq: 4.2.3 update

[Justin Bronder]

Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
---
 meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
index a64745c94..9e8ad5151 100644
--- a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
+++ b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
@@ -4,8 +4,8 @@ LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=db174eaf7b55a34a7c89551197f66e94"
 DEPENDS = "zeromq"
 
-SRCREV = "68a7b09cfce01c4c279fba2cf91686fcfc566848"
-PV = "4.1.5+git${SRCPV}"
+PV = "4.2.3"
+SRCREV = "v${PV}"
 
 SRC_URI = "git://github.com/zeromq/cppzmq.git"
 
-- 
2.13.6

[meta-oe][PATCH 2/2] zeromq: 4.2.3 update

[Justin Bronder]

Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
---
 .../zeromq/{zeromq_4.1.6.bb => zeromq_4.2.3.bb}                     | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
 rename meta-oe/recipes-connectivity/zeromq/{zeromq_4.1.6.bb => zeromq_4.2.3.bb} (78%)

diff --git a/meta-oe/recipes-connectivity/zeromq/zeromq_4.1.6.bb b/meta-oe/recipes-connectivity/zeromq/zeromq_4.2.3.bb
similarity index 78%
rename from meta-oe/recipes-connectivity/zeromq/zeromq_4.1.6.bb
rename to meta-oe/recipes-connectivity/zeromq/zeromq_4.2.3.bb
index e126f3239..71d7e7cbf 100644
--- a/meta-oe/recipes-connectivity/zeromq/zeromq_4.1.6.bb
+++ b/meta-oe/recipes-connectivity/zeromq/zeromq_4.2.3.bb
@@ -6,11 +6,11 @@ LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=d5311495d952062e0e4fbba39cbf3de1"
 PACKAGECONFIG ??= "libsodium"
 PACKAGECONFIG[libsodium] = "--with-libsodium, --without-libsodium, libsodium"
 
-SRC_URI = "http://github.com/zeromq/zeromq4-1/releases/download/v${PV}/zeromq-${PV}.tar.gz \
+SRC_URI = "http://github.com/zeromq/libzmq/releases/download/v${PV}/zeromq-${PV}.tar.gz \
     file://run-ptest \
 "
-SRC_URI[md5sum] = "c89db4dbc0b90c34c9f4983cbff6d321"
-SRC_URI[sha256sum] = "02ebf60a43011e770799336365bcbce2eb85569e9b5f52aa0d8cc04672438a0a"
+SRC_URI[md5sum] = "c4e18bd0584ccd34213f152c11f54d6c"
+SRC_URI[sha256sum] = "8f1e2b2aade4dbfde98d82366d61baef2f62e812530160d2e6d0a5bb24e40bc0"
 
 S = "${WORKDIR}/zeromq-${PV}"
 
-- 
2.13.6

Re: [meta-oe][PATCH 1/2] cppzmq: 4.2.3 update

[akuster808]

On 02/26/2018 12:16 PM, Justin Bronder wrote:
> Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
> ---
>  meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> index a64745c94..9e8ad5151 100644
> --- a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> +++ b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> @@ -4,8 +4,8 @@ LICENSE = "MIT"
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=db174eaf7b55a34a7c89551197f66e94"
>  DEPENDS = "zeromq"
>  
> -SRCREV = "68a7b09cfce01c4c279fba2cf91686fcfc566848"
> -PV = "4.1.5+git${SRCPV}"
> +PV = "4.2.3"
If the recipe is renamed to cppzmq_4.2.3.bb, will that work too?

- armin
> +SRCREV = "v${PV}"
>  
>  SRC_URI = "git://github.com/zeromq/cppzmq.git"
>  

Re: [meta-oe][PATCH 2/2] zeromq: 4.2.3 update

[akuster808]

On 02/26/2018 12:16 PM, Justin Bronder wrote:
> Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
can you provide high-lights of what is in the update?

- armin
> ---
>  .../zeromq/{zeromq_4.1.6.bb => zeromq_4.2.3.bb}                     | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>  rename meta-oe/recipes-connectivity/zeromq/{zeromq_4.1.6.bb => zeromq_4.2.3.bb} (78%)
>
> diff --git a/meta-oe/recipes-connectivity/zeromq/zeromq_4.1.6.bb b/meta-oe/recipes-connectivity/zeromq/zeromq_4.2.3.bb
> similarity index 78%
> rename from meta-oe/recipes-connectivity/zeromq/zeromq_4.1.6.bb
> rename to meta-oe/recipes-connectivity/zeromq/zeromq_4.2.3.bb
> index e126f3239..71d7e7cbf 100644
> --- a/meta-oe/recipes-connectivity/zeromq/zeromq_4.1.6.bb
> +++ b/meta-oe/recipes-connectivity/zeromq/zeromq_4.2.3.bb
> @@ -6,11 +6,11 @@ LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=d5311495d952062e0e4fbba39cbf3de1"
>  PACKAGECONFIG ??= "libsodium"
>  PACKAGECONFIG[libsodium] = "--with-libsodium, --without-libsodium, libsodium"
>  
> -SRC_URI = "http://github.com/zeromq/zeromq4-1/releases/download/v${PV}/zeromq-${PV}.tar.gz \
> +SRC_URI = "http://github.com/zeromq/libzmq/releases/download/v${PV}/zeromq-${PV}.tar.gz \
>      file://run-ptest \
>  "
> -SRC_URI[md5sum] = "c89db4dbc0b90c34c9f4983cbff6d321"
> -SRC_URI[sha256sum] = "02ebf60a43011e770799336365bcbce2eb85569e9b5f52aa0d8cc04672438a0a"
> +SRC_URI[md5sum] = "c4e18bd0584ccd34213f152c11f54d6c"
> +SRC_URI[sha256sum] = "8f1e2b2aade4dbfde98d82366d61baef2f62e812530160d2e6d0a5bb24e40bc0"
>  
>  S = "${WORKDIR}/zeromq-${PV}"
>  

Re: cppzmq: 4.2.3 update

[Justin Bronder]

On 27/02/18 21:51 -0800, akuster808 wrote:
> 
> 
> On 02/26/2018 12:16 PM, Justin Bronder wrote:
> > Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
> > ---
> >  meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > index a64745c94..9e8ad5151 100644
> > --- a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > +++ b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > @@ -4,8 +4,8 @@ LICENSE = "MIT"
> >  LIC_FILES_CHKSUM = "file://LICENSE;md5=db174eaf7b55a34a7c89551197f66e94"
> >  DEPENDS = "zeromq"
> >  
> > -SRCREV = "68a7b09cfce01c4c279fba2cf91686fcfc566848"
> > -PV = "4.1.5+git${SRCPV}"
> > +PV = "4.2.3"
> If the recipe is renamed to cppzmq_4.2.3.bb, will that work too?

Keep the patch and also rename?  Yeah, I'd find that more clear but I wasn't
sure if using the git checkout (and hence _git suffix) was a feature so I didn't
want to change it.

> 
> - armin
> > +SRCREV = "v${PV}"
> >  
> >  SRC_URI = "git://github.com/zeromq/cppzmq.git"
> >  
> 

-- 
Justin Bronder

Re: zeromq: 4.2.3 update

[Justin Bronder]

On 27/02/18 21:52 -0800, akuster808 wrote:
> 
> 
> On 02/26/2018 12:16 PM, Justin Bronder wrote:
> > Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
> can you provide high-lights of what is in the update?

Just getting to 4.2 brings in quite a bit [1] with 4.2.3 providing a lot of bug
fixes.  The claim from upstream, validated by my own limited use, is that 4.2 is
backwards compatible all the way to 2.2.0 [2].

1. https://github.com/zeromq/libzmq/releases/tag/v4.2.0
2. http://zeromq.org/intro:get-the-software

> 
> - armin
> > ---
> >  .../zeromq/{zeromq_4.1.6.bb => zeromq_4.2.3.bb}                     | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >  rename meta-oe/recipes-connectivity/zeromq/{zeromq_4.1.6.bb => zeromq_4.2.3.bb} (78%)
> >
> > diff --git a/meta-oe/recipes-connectivity/zeromq/zeromq_4.1.6.bb b/meta-oe/recipes-connectivity/zeromq/zeromq_4.2.3.bb
> > similarity index 78%
> > rename from meta-oe/recipes-connectivity/zeromq/zeromq_4.1.6.bb
> > rename to meta-oe/recipes-connectivity/zeromq/zeromq_4.2.3.bb
> > index e126f3239..71d7e7cbf 100644
> > --- a/meta-oe/recipes-connectivity/zeromq/zeromq_4.1.6.bb
> > +++ b/meta-oe/recipes-connectivity/zeromq/zeromq_4.2.3.bb
> > @@ -6,11 +6,11 @@ LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=d5311495d952062e0e4fbba39cbf3de1"
> >  PACKAGECONFIG ??= "libsodium"
> >  PACKAGECONFIG[libsodium] = "--with-libsodium, --without-libsodium, libsodium"
> >  
> > -SRC_URI = "http://github.com/zeromq/zeromq4-1/releases/download/v${PV}/zeromq-${PV}.tar.gz \
> > +SRC_URI = "http://github.com/zeromq/libzmq/releases/download/v${PV}/zeromq-${PV}.tar.gz \
> >      file://run-ptest \
> >  "
> > -SRC_URI[md5sum] = "c89db4dbc0b90c34c9f4983cbff6d321"
> > -SRC_URI[sha256sum] = "02ebf60a43011e770799336365bcbce2eb85569e9b5f52aa0d8cc04672438a0a"
> > +SRC_URI[md5sum] = "c4e18bd0584ccd34213f152c11f54d6c"
> > +SRC_URI[sha256sum] = "8f1e2b2aade4dbfde98d82366d61baef2f62e812530160d2e6d0a5bb24e40bc0"
> >  
> >  S = "${WORKDIR}/zeromq-${PV}"
> >  
> 

-- 
Justin Bronder

Re: [meta-oe][PATCH 1/2] cppzmq: 4.2.3 update

[Andreas Oberritter]

Hi Justin,

On Mon, 26 Feb 2018 15:16:04 -0500
Justin Bronder <jsbronder@cold-front.org> wrote:

> Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
> ---
>  meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> index a64745c94..9e8ad5151 100644
> --- a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> +++ b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> @@ -4,8 +4,8 @@ LICENSE = "MIT"
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=db174eaf7b55a34a7c89551197f66e94"
>  DEPENDS = "zeromq"
>  
> -SRCREV = "68a7b09cfce01c4c279fba2cf91686fcfc566848"
> -PV = "4.1.5+git${SRCPV}"
> +PV = "4.2.3"
> +SRCREV = "v${PV}"

we usually don't use tags in SRCREV, because tags may change over time, and
therefore bitbake has to query the server each time it parses the recipe, IIRC.

Regards,
Andreas

Re: cppzmq: 4.2.3 update

[Justin Bronder]

On 01/03/18 16:36 +0100, Andreas Oberritter wrote:
> Hi Justin,
> 
> On Mon, 26 Feb 2018 15:16:04 -0500
> Justin Bronder <jsbronder@cold-front.org> wrote:
> 
> > Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
> > ---
> >  meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > index a64745c94..9e8ad5151 100644
> > --- a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > +++ b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > @@ -4,8 +4,8 @@ LICENSE = "MIT"
> >  LIC_FILES_CHKSUM = "file://LICENSE;md5=db174eaf7b55a34a7c89551197f66e94"
> >  DEPENDS = "zeromq"
> >  
> > -SRCREV = "68a7b09cfce01c4c279fba2cf91686fcfc566848"
> > -PV = "4.1.5+git${SRCPV}"
> > +PV = "4.2.3"
> > +SRCREV = "v${PV}"
> 
> we usually don't use tags in SRCREV, because tags may change over time, and
> therefore bitbake has to query the server each time it parses the recipe, IIRC.

Ok.  Should I submit a v2 with the file rename that akuster808 suggested and
pulling a tarball instead?


-- 
Justin Bronder

Re: cppzmq: 4.2.3 update

[Andreas Oberritter]

On Thu, 1 Mar 2018 10:47:02 -0500
Justin Bronder <jsbronder@cold-front.org> wrote:

> On 01/03/18 16:36 +0100, Andreas Oberritter wrote:
> > Hi Justin,
> > 
> > On Mon, 26 Feb 2018 15:16:04 -0500
> > Justin Bronder <jsbronder@cold-front.org> wrote:
> >   
> > > Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
> > > ---
> > >  meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > > index a64745c94..9e8ad5151 100644
> > > --- a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > > +++ b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > > @@ -4,8 +4,8 @@ LICENSE = "MIT"
> > >  LIC_FILES_CHKSUM = "file://LICENSE;md5=db174eaf7b55a34a7c89551197f66e94"
> > >  DEPENDS = "zeromq"
> > >  
> > > -SRCREV = "68a7b09cfce01c4c279fba2cf91686fcfc566848"
> > > -PV = "4.1.5+git${SRCPV}"
> > > +PV = "4.2.3"
> > > +SRCREV = "v${PV}"  
> > 
> > we usually don't use tags in SRCREV, because tags may change over time, and
> > therefore bitbake has to query the server each time it parses the recipe, IIRC.  
> 
> Ok.  Should I submit a v2 with the file rename that akuster808 suggested and
> pulling a tarball instead?

I'd say keep the filename and just update PV to 4.2.3+git${SRCPV} in v2. This
reduces the number of changed lines in case SRCREV gets advanced to a commit
between 4.2.3 and a future release.

Regards,
Andreas

Re: cppzmq: 4.2.3 update

[Justin Bronder]

On 01/03/18 17:14 +0100, Andreas Oberritter wrote:
> On Thu, 1 Mar 2018 10:47:02 -0500
> Justin Bronder <jsbronder@cold-front.org> wrote:
> 
> > On 01/03/18 16:36 +0100, Andreas Oberritter wrote:
> > > Hi Justin,
> > > 
> > > On Mon, 26 Feb 2018 15:16:04 -0500
> > > Justin Bronder <jsbronder@cold-front.org> wrote:
> > >   
> > > > Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
> > > > ---
> > > >  meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > > > index a64745c94..9e8ad5151 100644
> > > > --- a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > > > +++ b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > > > @@ -4,8 +4,8 @@ LICENSE = "MIT"
> > > >  LIC_FILES_CHKSUM = "file://LICENSE;md5=db174eaf7b55a34a7c89551197f66e94"
> > > >  DEPENDS = "zeromq"
> > > >  
> > > > -SRCREV = "68a7b09cfce01c4c279fba2cf91686fcfc566848"
> > > > -PV = "4.1.5+git${SRCPV}"
> > > > +PV = "4.2.3"
> > > > +SRCREV = "v${PV}"  
> > > 
> > > we usually don't use tags in SRCREV, because tags may change over time, and
> > > therefore bitbake has to query the server each time it parses the recipe, IIRC.  
> > 
> > Ok.  Should I submit a v2 with the file rename that akuster808 suggested and
> > pulling a tarball instead?
> 
> I'd say keep the filename and just update PV to 4.2.3+git${SRCPV} in v2. This
> reduces the number of changed lines in case SRCREV gets advanced to a commit
> between 4.2.3 and a future release.

Thanks, v2 sent.

-- 
Justin Bronder