All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org,
	mcoquelin.stm32@gmail.com, alexandre.torgue@st.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Benjamin Gaignard <benjamin.gaignard@st.com>
Subject: Re: [PATCH 3/3] ARM: mach-stm32: Add Extended TrustZone Protection driver
Date: Tue, 27 Feb 2018 17:14:19 +0000	[thread overview]
Message-ID: <20180227171419.3nlz23qzptvew2as@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <20180227140926.22996-4-benjamin.gaignard@st.com>

On Tue, Feb 27, 2018 at 03:09:26PM +0100, Benjamin Gaignard wrote:
 +
> +static const u32 stm32mp1_ip_addr[] = {
> +	0x5c008000,	/* 00 stgenc */
> +	0x54000000,	/* 01 bkpsram */
> +	0x5c003000,	/* 02 iwdg1 */
> +	0x5c000000,	/* 03 usart1 */
> +	0x5c001000,	/* 04 spi6 */
> +	0x5c002000,	/* 05 i2c4 */

...

This duplicates information that is in the DT, which is unfortunate.

Why can these not be marked disabled inthe DT instead? 

If it's dynamic form boot-to-boot, then the FW can probe this prior to
entering Linux, and patch the DT appropriately.

Thanks,
Mark.

WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: mach-stm32: Add Extended TrustZone Protection driver
Date: Tue, 27 Feb 2018 17:14:19 +0000	[thread overview]
Message-ID: <20180227171419.3nlz23qzptvew2as@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <20180227140926.22996-4-benjamin.gaignard@st.com>

On Tue, Feb 27, 2018 at 03:09:26PM +0100, Benjamin Gaignard wrote:
 +
> +static const u32 stm32mp1_ip_addr[] = {
> +	0x5c008000,	/* 00 stgenc */
> +	0x54000000,	/* 01 bkpsram */
> +	0x5c003000,	/* 02 iwdg1 */
> +	0x5c000000,	/* 03 usart1 */
> +	0x5c001000,	/* 04 spi6 */
> +	0x5c002000,	/* 05 i2c4 */

...

This duplicates information that is in the DT, which is unfortunate.

Why can these not be marked disabled inthe DT instead? 

If it's dynamic form boot-to-boot, then the FW can probe this prior to
entering Linux, and patch the DT appropriately.

Thanks,
Mark.

  reply	other threads:[~2018-02-27 17:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-27 14:09 [PATCH 0/3] STM32 Extended TrustZone Protection driver Benjamin Gaignard
2018-02-27 14:09 ` Benjamin Gaignard
2018-02-27 14:09 ` [PATCH 1/3] driver core: check notifier_call_chain return value Benjamin Gaignard
2018-02-27 14:09   ` Benjamin Gaignard
2018-03-15 17:10   ` Greg KH
2018-03-15 17:10     ` Greg KH
2018-03-16  8:53     ` Benjamin Gaignard
2018-03-16  8:53       ` Benjamin Gaignard
2018-02-27 14:09 ` [PATCH 2/3] dt-bindings: stm32: Add bindings for Extended TrustZone Protection Benjamin Gaignard
2018-02-27 14:09   ` Benjamin Gaignard
2018-02-27 14:09 ` [PATCH 3/3] ARM: mach-stm32: Add Extended TrustZone Protection driver Benjamin Gaignard
2018-02-27 14:09   ` Benjamin Gaignard
2018-02-27 17:14   ` Mark Rutland [this message]
2018-02-27 17:14     ` Mark Rutland
2018-02-27 19:23     ` Benjamin Gaignard
2018-02-27 19:23       ` Benjamin Gaignard
2018-02-27 17:11 ` [PATCH 0/3] STM32 " Mark Rutland
2018-02-27 17:11   ` Mark Rutland
2018-02-27 19:16   ` Benjamin Gaignard
2018-02-27 19:16     ` Benjamin Gaignard
2018-02-27 19:46     ` Robin Murphy
2018-02-27 19:46       ` Robin Murphy
2018-02-28  7:53       ` Benjamin Gaignard
2018-02-28  7:53         ` Benjamin Gaignard
2018-02-28 17:53         ` Mark Rutland
2018-02-28 17:53           ` Mark Rutland
2018-02-28 18:32           ` Robin Murphy
2018-02-28 18:32             ` Robin Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180227171419.3nlz23qzptvew2as@lakrids.cambridge.arm.com \
    --to=mark.rutland@arm.com \
    --cc=alexandre.torgue@st.com \
    --cc=benjamin.gaignard@linaro.org \
    --cc=benjamin.gaignard@st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.