From: Ido Schimmel <idosch@idosch.org>
To: Jiri Benc <jbenc@redhat.com>
Cc: Ido Schimmel <idosch@mellanox.com>,
netdev@vger.kernel.org, davem@davemloft.net, jiri@mellanox.com,
dsahern@gmail.com, mlxsw@mellanox.com
Subject: Re: [PATCH net-next] team: Use extack to report enslavement failures
Date: Tue, 27 Feb 2018 22:22:12 +0200 [thread overview]
Message-ID: <20180227202212.GA14835@splinter> (raw)
In-Reply-To: <20180227204235.7d4ab738@redhat.com>
On Tue, Feb 27, 2018 at 08:42:35PM +0100, Jiri Benc wrote:
> On Tue, 27 Feb 2018 17:38:08 +0200, Ido Schimmel wrote:
> > if (port_dev->flags & IFF_LOOPBACK) {
> > + NL_SET_ERR_MSG(extack, "Loopback device can't be added as a team port");
> > netdev_err(dev, "Device %s is loopback device. Loopback devices can't be added as a team port\n",
> > portname);
>
> Aren't the netdev_errs unnecessary now?
>
> Or do you keep them for people using old config tools with a new kernel?
Yes, that's the intention. I checked bond that was also converted to use
extack and the same thing happens there.
> If so, for how long? They should certainly be removed eventually. How
> do we ensure we don't forget?
>
> Seems to me it would be better to remove them right now.
I can do that unless someone objects.
next prev parent reply other threads:[~2018-02-27 20:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 15:38 [PATCH net-next] team: Use extack to report enslavement failures Ido Schimmel
2018-02-27 16:37 ` David Ahern
2018-02-27 19:42 ` Jiri Benc
2018-02-27 20:22 ` Ido Schimmel [this message]
2018-02-27 23:49 ` Jakub Kicinski
2018-02-28 7:12 ` Jiri Pirko
2018-02-28 7:21 ` Yuval Mintz
2018-02-28 8:58 ` Jiri Benc
2018-02-28 9:29 ` Jiri Pirko
2018-02-28 14:28 ` David Miller
2018-02-28 16:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227202212.GA14835@splinter \
--to=idosch@idosch.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=idosch@mellanox.com \
--cc=jbenc@redhat.com \
--cc=jiri@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.