* [Buildroot] [PATCH v1] sdl2: rpi video support needs OpenGL ES
@ 2018-02-28 9:04 Peter Seiderer
2018-02-28 13:55 ` Peter Korsgaard
0 siblings, 1 reply; 3+ messages in thread
From: Peter Seiderer @ 2018-02-28 9:04 UTC (permalink / raw)
To: buildroot
Fixes [1]:
.../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c: In function 'RPI_Create':
.../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c:126:39: error: 'RPI_GLES_DefaultProfileConfig' undeclared (first use in this function); did you mean 'RPI_GLES_DeleteContext'?
device->GL_DefaultProfileConfig = RPI_GLES_DefaultProfileConfig;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
RPI_GLES_DeleteContext
.../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c:126:39: note: each undeclared identifier is reported only once for each function it appears in
.../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c: In function 'RPI_CreateWindow':
.../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c:281:17: error: 'SDL_VideoDevice {aka struct SDL_VideoDevice}' has no member named 'egl_data'; did you mean 'gl_data'?
if (!_this->egl_data) {
^~~~~~~~
gl_data
.../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c:286:10: error: 'SDL_WindowData {aka struct SDL_WindowData}' has no member named 'egl_surface'
wdata->egl_surface = SDL_EGL_CreateSurface(_this, (NativeWindowType) &wdata->dispman_window);
^~
.../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c:286:26: warning: implicit declaration of function 'SDL_EGL_CreateSurface'; did you mean 'SDL_Vulkan_CreateSurface'? [-Wimplicit-function-declaration]
wdata->egl_surface = SDL_EGL_CreateSurface(_this, (NativeWindowType) &wdata->dispman_window);
^~~~~~~~~~~~~~~~~~~~~
SDL_Vulkan_CreateSurface
.../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c:288:14: error: 'SDL_WindowData {aka struct SDL_WindowData}' has no member named 'egl_surface'
if (wdata->egl_surface == EGL_NO_SURFACE) {
^~
[1] http://autobuild.buildroot.net/results/9612d43b192bbb88214a11fe18f8b8da6ad10313
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
package/sdl2/sdl2.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/sdl2/sdl2.mk b/package/sdl2/sdl2.mk
index 6cb24d9e75..6508e6b962 100644
--- a/package/sdl2/sdl2.mk
+++ b/package/sdl2/sdl2.mk
@@ -38,7 +38,7 @@ else
SDL2_CONF_OPTS += --disable-video-directfb
endif
-ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
+ifeq ($(BR2_PACKAGE_SDL2_OPENGLES)$(BR2_PACKAGE_RPI_USERLAND),yy)
SDL2_DEPENDENCIES += rpi-userland
SDL2_CONF_OPTS += --enable-video-rpi
else
--
2.16.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v1] sdl2: rpi video support needs OpenGL ES
2018-02-28 9:04 [Buildroot] [PATCH v1] sdl2: rpi video support needs OpenGL ES Peter Seiderer
@ 2018-02-28 13:55 ` Peter Korsgaard
2018-02-28 19:55 ` Guillermo A . Amaral
0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2018-02-28 13:55 UTC (permalink / raw)
To: buildroot
>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:
> Fixes [1]:
> .../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c: In function 'RPI_Create':
> .../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c:126:39: error: 'RPI_GLES_DefaultProfileConfig' undeclared (first use in this function); did you mean 'RPI_GLES_DeleteContext'?
device-> GL_DefaultProfileConfig = RPI_GLES_DefaultProfileConfig;
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> RPI_GLES_DeleteContext
> .../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c:126:39: note: each undeclared identifier is reported only once for each function it appears in
> .../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c: In function 'RPI_CreateWindow':
> .../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c:281:17: error: 'SDL_VideoDevice {aka struct SDL_VideoDevice}' has no member named 'egl_data'; did you mean 'gl_data'?
> if (!_this->egl_data) {
> ^~~~~~~~
> gl_data
> .../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c:286:10: error: 'SDL_WindowData {aka struct SDL_WindowData}' has no member named 'egl_surface'
wdata-> egl_surface = SDL_EGL_CreateSurface(_this, (NativeWindowType) &wdata->dispman_window);
> ^~
> .../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c:286:26: warning: implicit declaration of function 'SDL_EGL_CreateSurface'; did you mean 'SDL_Vulkan_CreateSurface'? [-Wimplicit-function-declaration]
wdata-> egl_surface = SDL_EGL_CreateSurface(_this, (NativeWindowType) &wdata->dispman_window);
> ^~~~~~~~~~~~~~~~~~~~~
> SDL_Vulkan_CreateSurface
> .../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c:288:14: error: 'SDL_WindowData {aka struct SDL_WindowData}' has no member named 'egl_surface'
> if (wdata->egl_surface == EGL_NO_SURFACE) {
> ^~
> [1] http://autobuild.buildroot.net/results/9612d43b192bbb88214a11fe18f8b8da6ad10313
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v1] sdl2: rpi video support needs OpenGL ES
2018-02-28 13:55 ` Peter Korsgaard
@ 2018-02-28 19:55 ` Guillermo A . Amaral
0 siblings, 0 replies; 3+ messages in thread
From: Guillermo A . Amaral @ 2018-02-28 19:55 UTC (permalink / raw)
To: buildroot
Ah! You guys beat me to the punch. Thanks for the fix! :-)
On Wed, Feb 28, 2018 at 02:55:39PM +0100, Peter Korsgaard wrote:
> >>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:
>
> > Fixes [1]:
> > .../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c: In function 'RPI_Create':
> > .../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c:126:39: error: 'RPI_GLES_DefaultProfileConfig' undeclared (first use in this function); did you mean 'RPI_GLES_DeleteContext'?
> device-> GL_DefaultProfileConfig = RPI_GLES_DefaultProfileConfig;
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > RPI_GLES_DeleteContext
> > .../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c:126:39: note: each undeclared identifier is reported only once for each function it appears in
> > .../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c: In function 'RPI_CreateWindow':
> > .../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c:281:17: error: 'SDL_VideoDevice {aka struct SDL_VideoDevice}' has no member named 'egl_data'; did you mean 'gl_data'?
> > if (!_this->egl_data) {
> > ^~~~~~~~
> > gl_data
> > .../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c:286:10: error: 'SDL_WindowData {aka struct SDL_WindowData}' has no member named 'egl_surface'
> wdata-> egl_surface = SDL_EGL_CreateSurface(_this, (NativeWindowType) &wdata->dispman_window);
> > ^~
> > .../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c:286:26: warning: implicit declaration of function 'SDL_EGL_CreateSurface'; did you mean 'SDL_Vulkan_CreateSurface'? [-Wimplicit-function-declaration]
> wdata-> egl_surface = SDL_EGL_CreateSurface(_this, (NativeWindowType) &wdata->dispman_window);
> > ^~~~~~~~~~~~~~~~~~~~~
> > SDL_Vulkan_CreateSurface
> > .../build/sdl2-2.0.7/src/video/raspberry/SDL_rpivideo.c:288:14: error: 'SDL_WindowData {aka struct SDL_WindowData}' has no member named 'egl_surface'
> > if (wdata->egl_surface == EGL_NO_SURFACE) {
> > ^~
>
> > [1] http://autobuild.buildroot.net/results/9612d43b192bbb88214a11fe18f8b8da6ad10313
>
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>
> Committed, thanks.
>
> --
> Bye, Peter Korsgaard
--
gamaral
http://about.me/gamaral
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-28 19:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-28 9:04 [Buildroot] [PATCH v1] sdl2: rpi video support needs OpenGL ES Peter Seiderer
2018-02-28 13:55 ` Peter Korsgaard
2018-02-28 19:55 ` Guillermo A . Amaral
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.