* [PATCH] f2fs: fix to restore whint_mode in ->remount_fs
@ 2018-02-28 14:01 ` Chao Yu
0 siblings, 0 replies; 5+ messages in thread
From: Chao Yu @ 2018-02-28 14:01 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-f2fs-devel, linux-kernel, Chao Yu
From: Chao Yu <yuchao0@huawei.com>
If we fail in ->remount_fs, it needs to restore old whint_mode as other
mount options.
Fixes: e25afe01822f ("f2fs: support passing down write hints given by users to block layer")
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
fs/f2fs/super.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 89abe4087e66..8a93f78efca2 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -1512,6 +1512,7 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data)
sbi->s_qf_names[i] = s_qf_names[i];
}
#endif
+ sbi->whint_mode = old_whint_mode;
sbi->mount_opt = org_mount_opt;
sbi->active_logs = active_logs;
sb->s_flags = old_sb_flags;
--
2.14.1.145.gb3622a4ee
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] f2fs: fix to restore whint_mode in ->remount_fs
@ 2018-02-28 14:01 ` Chao Yu
0 siblings, 0 replies; 5+ messages in thread
From: Chao Yu @ 2018-02-28 14:01 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-kernel, linux-f2fs-devel
From: Chao Yu <yuchao0@huawei.com>
If we fail in ->remount_fs, it needs to restore old whint_mode as other
mount options.
Fixes: e25afe01822f ("f2fs: support passing down write hints given by users to block layer")
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
fs/f2fs/super.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 89abe4087e66..8a93f78efca2 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -1512,6 +1512,7 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data)
sbi->s_qf_names[i] = s_qf_names[i];
}
#endif
+ sbi->whint_mode = old_whint_mode;
sbi->mount_opt = org_mount_opt;
sbi->active_logs = active_logs;
sb->s_flags = old_sb_flags;
--
2.14.1.145.gb3622a4ee
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] f2fs: fix to restore whint_mode in ->remount_fs
2018-02-28 14:01 ` Chao Yu
(?)
@ 2018-03-01 2:45 ` Jaegeuk Kim
2018-03-01 2:54 ` Chao Yu
-1 siblings, 1 reply; 5+ messages in thread
From: Jaegeuk Kim @ 2018-03-01 2:45 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-f2fs-devel, linux-kernel, Chao Yu
On 02/28, Chao Yu wrote:
> From: Chao Yu <yuchao0@huawei.com>
>
> If we fail in ->remount_fs, it needs to restore old whint_mode as other
> mount options.
>
> Fixes: e25afe01822f ("f2fs: support passing down write hints given by users to block layer")
Hi Chao,
It was not merged, so please allow me to integrate this into the original
patch.
Thanks,
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> fs/f2fs/super.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 89abe4087e66..8a93f78efca2 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1512,6 +1512,7 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data)
> sbi->s_qf_names[i] = s_qf_names[i];
> }
> #endif
> + sbi->whint_mode = old_whint_mode;
> sbi->mount_opt = org_mount_opt;
> sbi->active_logs = active_logs;
> sb->s_flags = old_sb_flags;
> --
> 2.14.1.145.gb3622a4ee
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] f2fs: fix to restore whint_mode in ->remount_fs
2018-03-01 2:45 ` Jaegeuk Kim
@ 2018-03-01 2:54 ` Chao Yu
0 siblings, 0 replies; 5+ messages in thread
From: Chao Yu @ 2018-03-01 2:54 UTC (permalink / raw)
To: Jaegeuk Kim, Chao Yu; +Cc: linux-f2fs-devel, linux-kernel
Hi Jaegeuk,
On 2018/3/1 10:45, Jaegeuk Kim wrote:
> On 02/28, Chao Yu wrote:
>> From: Chao Yu <yuchao0@huawei.com>
>>
>> If we fail in ->remount_fs, it needs to restore old whint_mode as other
>> mount options.
>>
>> Fixes: e25afe01822f ("f2fs: support passing down write hints given by users to block layer")
>
> Hi Chao,
>
> It was not merged, so please allow me to integrate this into the original
> patch.
No problem, please go ahead. ;)
Thanks,
>
> Thanks,
>
>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>> ---
>> fs/f2fs/super.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
>> index 89abe4087e66..8a93f78efca2 100644
>> --- a/fs/f2fs/super.c
>> +++ b/fs/f2fs/super.c
>> @@ -1512,6 +1512,7 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data)
>> sbi->s_qf_names[i] = s_qf_names[i];
>> }
>> #endif
>> + sbi->whint_mode = old_whint_mode;
>> sbi->mount_opt = org_mount_opt;
>> sbi->active_logs = active_logs;
>> sb->s_flags = old_sb_flags;
>> --
>> 2.14.1.145.gb3622a4ee
>
> .
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] f2fs: fix to restore whint_mode in ->remount_fs
@ 2018-03-01 2:54 ` Chao Yu
0 siblings, 0 replies; 5+ messages in thread
From: Chao Yu @ 2018-03-01 2:54 UTC (permalink / raw)
To: Jaegeuk Kim, Chao Yu; +Cc: linux-f2fs-devel, linux-kernel
Hi Jaegeuk,
On 2018/3/1 10:45, Jaegeuk Kim wrote:
> On 02/28, Chao Yu wrote:
>> From: Chao Yu <yuchao0@huawei.com>
>>
>> If we fail in ->remount_fs, it needs to restore old whint_mode as other
>> mount options.
>>
>> Fixes: e25afe01822f ("f2fs: support passing down write hints given by users to block layer")
>
> Hi Chao,
>
> It was not merged, so please allow me to integrate this into the original
> patch.
No problem, please go ahead. ;)
Thanks,
>
> Thanks,
>
>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>> ---
>> fs/f2fs/super.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
>> index 89abe4087e66..8a93f78efca2 100644
>> --- a/fs/f2fs/super.c
>> +++ b/fs/f2fs/super.c
>> @@ -1512,6 +1512,7 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data)
>> sbi->s_qf_names[i] = s_qf_names[i];
>> }
>> #endif
>> + sbi->whint_mode = old_whint_mode;
>> sbi->mount_opt = org_mount_opt;
>> sbi->active_logs = active_logs;
>> sb->s_flags = old_sb_flags;
>> --
>> 2.14.1.145.gb3622a4ee
>
> .
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-01 2:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-28 14:01 [PATCH] f2fs: fix to restore whint_mode in ->remount_fs Chao Yu
2018-02-28 14:01 ` Chao Yu
2018-03-01 2:45 ` Jaegeuk Kim
2018-03-01 2:54 ` Chao Yu
2018-03-01 2:54 ` Chao Yu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.