From: Keith Busch <keith.busch@intel.com> To: Ming Lei <ming.lei@redhat.com> Cc: Christoph Hellwig <hch@lst.de>, Jianchao Wang <jianchao.w.wang@oracle.com>, axboe@fb.com, sagi@grimberg.me, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH V2] nvme-pci: assign separate irq vectors for adminq and ioq0 Date: Thu, 1 Mar 2018 09:10:42 -0700 [thread overview] Message-ID: <20180301161042.GA14799@localhost.localdomain> (raw) In-Reply-To: <20180301150329.GB6795@ming.t460p> On Thu, Mar 01, 2018 at 11:03:30PM +0800, Ming Lei wrote: > If all CPUs for the 1st IRQ vector of admin queue are offline, then I > guess NVMe can't work any more. Yikes, with respect to admin commands, it appears you're right if your system allows offlining CPU0. > So looks it is a good idea to make admin queue's IRQ vector assigned as > non-managed IRQs. It'd still be considered managed even if it's a 'pre_vector', though it would get the default mask with all possible CPUs.
WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@intel.com (Keith Busch) Subject: [PATCH V2] nvme-pci: assign separate irq vectors for adminq and ioq0 Date: Thu, 1 Mar 2018 09:10:42 -0700 [thread overview] Message-ID: <20180301161042.GA14799@localhost.localdomain> (raw) In-Reply-To: <20180301150329.GB6795@ming.t460p> On Thu, Mar 01, 2018@11:03:30PM +0800, Ming Lei wrote: > If all CPUs for the 1st IRQ vector of admin queue are offline, then I > guess NVMe can't work any more. Yikes, with respect to admin commands, it appears you're right if your system allows offlining CPU0. > So looks it is a good idea to make admin queue's IRQ vector assigned as > non-managed IRQs. It'd still be considered managed even if it's a 'pre_vector', though it would get the default mask with all possible CPUs.
next prev parent reply other threads:[~2018-03-01 16:08 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-28 15:48 [PATCH V2] nvme-pci: assign separate irq vectors for adminq and ioq0 Jianchao Wang 2018-02-28 15:48 ` Jianchao Wang 2018-02-28 15:59 ` Andy Shevchenko 2018-02-28 15:59 ` Andy Shevchenko 2018-03-02 3:06 ` jianchao.wang 2018-03-02 3:06 ` jianchao.wang 2018-03-12 18:59 ` Keith Busch 2018-03-12 18:59 ` Keith Busch 2018-03-13 1:47 ` jianchao.wang 2018-03-13 1:47 ` jianchao.wang 2018-02-28 16:47 ` Christoph Hellwig 2018-02-28 16:47 ` Christoph Hellwig 2018-03-01 9:28 ` Sagi Grimberg 2018-03-01 9:28 ` Sagi Grimberg 2018-03-01 10:05 ` jianchao.wang 2018-03-01 10:05 ` jianchao.wang 2018-03-01 15:15 ` Keith Busch 2018-03-01 15:15 ` Keith Busch 2018-03-02 3:11 ` jianchao.wang 2018-03-02 3:11 ` jianchao.wang 2018-03-01 15:03 ` Ming Lei 2018-03-01 15:03 ` Ming Lei 2018-03-01 16:10 ` Keith Busch [this message] 2018-03-01 16:10 ` Keith Busch 2018-03-08 7:42 ` Christoph Hellwig 2018-03-08 7:42 ` Christoph Hellwig 2018-03-09 17:24 ` Keith Busch 2018-03-09 17:24 ` Keith Busch 2018-03-12 9:09 ` Ming Lei 2018-03-12 9:09 ` Ming Lei 2018-10-08 5:05 ` nvme-pci: number of queues off by one Prasun Ratn 2018-10-08 5:59 ` Dongli Zhang 2018-10-08 5:59 ` Dongli Zhang 2018-10-08 6:58 ` Dongli Zhang 2018-10-08 6:58 ` Dongli Zhang 2018-10-08 14:54 ` Keith Busch 2018-10-08 14:54 ` Keith Busch 2018-10-08 10:19 ` Ming Lei 2018-10-08 10:19 ` Ming Lei 2018-03-02 3:18 ` [PATCH V2] nvme-pci: assign separate irq vectors for adminq and ioq0 jianchao.wang 2018-03-02 3:18 ` jianchao.wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180301161042.GA14799@localhost.localdomain \ --to=keith.busch@intel.com \ --cc=axboe@fb.com \ --cc=hch@lst.de \ --cc=jianchao.w.wang@oracle.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=ming.lei@redhat.com \ --cc=sagi@grimberg.me \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.