[PATCH] staging: rtlwifi: remove condition where it has no effect

[PATCH] staging: rtlwifi: remove condition where it has no effect

[Santha Meena Ramamoorthy]

Remove condition where if and else branch are functionally identical.
Issue found using cond_no_effect.cocci Coccinelle script.

Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>
---
 drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c b/drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c
index ffff5b0..5b82640 100644
--- a/drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c
+++ b/drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c
@@ -2885,12 +2885,8 @@ static void halbtc8822b2ant_action_a2dp(struct btc_coexist *btcoexist)
 							     NORMAL_EXEC, 5);
 
 		} else {
-			if (wifi_turbo)
-				halbtc8822b2ant_coex_table_with_type(
-					btcoexist, NORMAL_EXEC, 10);
-			else
-				halbtc8822b2ant_coex_table_with_type(
-					btcoexist, NORMAL_EXEC, 10);
+			halbtc8822b2ant_coex_table_with_type(btcoexist,
+							     NORMAL_EXEC, 10);
 
 			halbtc8822b2ant_ps_tdma(btcoexist, NORMAL_EXEC, true,
 						109);
-- 
2.7.4

Re: [Outreachy kernel] [PATCH] staging: rtlwifi: remove condition where it has no effect

[Julia Lawall]

On Fri, 2 Mar 2018, Santha Meena Ramamoorthy wrote:

> Remove condition where if and else branch are functionally identical.
> Issue found using cond_no_effect.cocci Coccinelle script.

Actually, there are just identical, period.  It would be good to remove
"functionally".

Since having such code that is completely duplicated is a little bit
strange, it could be good to enlarge the recipient list to:

Ping-Ke Shih <pkshih@realtek.com>
(commit_signer:1/1=100%,authored:1/1=100%,added_lines:5225/5225=100%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/1=100%)
devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM)

Maybe someone out there would know if actually some different arguments
were intended.

julia

>
> Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>
> ---
>  drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c b/drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c
> index ffff5b0..5b82640 100644
> --- a/drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c
> +++ b/drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c
> @@ -2885,12 +2885,8 @@ static void halbtc8822b2ant_action_a2dp(struct btc_coexist *btcoexist)
>  							     NORMAL_EXEC, 5);
>
>  		} else {
> -			if (wifi_turbo)
> -				halbtc8822b2ant_coex_table_with_type(
> -					btcoexist, NORMAL_EXEC, 10);
> -			else
> -				halbtc8822b2ant_coex_table_with_type(
> -					btcoexist, NORMAL_EXEC, 10);
> +			halbtc8822b2ant_coex_table_with_type(btcoexist,
> +							     NORMAL_EXEC, 10);
>
>  			halbtc8822b2ant_ps_tdma(btcoexist, NORMAL_EXEC, true,
>  						109);
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1519984441-14752-1-git-send-email-santhameena13%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH] staging: rtlwifi: remove condition where it has no effect

[Santha Meena Ramamoorthy]

On Fri, Mar 02, 2018 at 11:03:38AM +0100, Julia Lawall wrote:
> 
> 
> On Fri, 2 Mar 2018, Santha Meena Ramamoorthy wrote:
> 
> > Remove condition where if and else branch are functionally identical.
> > Issue found using cond_no_effect.cocci Coccinelle script.
> 
> Actually, there are just identical, period.  It would be good to remove
> "functionally".
> 
> Since having such code that is completely duplicated is a little bit
> strange, it could be good to enlarge the recipient list to:
> 
> Ping-Ke Shih <pkshih@realtek.com>
> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:5225/5225=100%)
> Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/1=100%)
> devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM)
> 
> Maybe someone out there would know if actually some different arguments
> were intended.
> 
> julia
> 
Hi,

Sure, I will do it now. I guess that should be v2 of the patch. 
> >
> > Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>
> > ---
> >  drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c | 8 ++------
> >  1 file changed, 2 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c b/drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c
> > index ffff5b0..5b82640 100644
> > --- a/drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c
> > +++ b/drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c
> > @@ -2885,12 +2885,8 @@ static void halbtc8822b2ant_action_a2dp(struct btc_coexist *btcoexist)
> >  							     NORMAL_EXEC, 5);
> >
> >  		} else {
> > -			if (wifi_turbo)
> > -				halbtc8822b2ant_coex_table_with_type(
> > -					btcoexist, NORMAL_EXEC, 10);
> > -			else
> > -				halbtc8822b2ant_coex_table_with_type(
> > -					btcoexist, NORMAL_EXEC, 10);
> > +			halbtc8822b2ant_coex_table_with_type(btcoexist,
> > +							     NORMAL_EXEC, 10);
> >
> >  			halbtc8822b2ant_ps_tdma(btcoexist, NORMAL_EXEC, true,
> >  						109);
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1519984441-14752-1-git-send-email-santhameena13%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >

Re: [Outreachy kernel] [PATCH] staging: rtlwifi: remove condition where it has no effect

[Julia Lawall]

On Fri, 2 Mar 2018, Santha Meena Ramamoorthy wrote:

> On Fri, Mar 02, 2018 at 11:03:38AM +0100, Julia Lawall wrote:
> >
> >
> > On Fri, 2 Mar 2018, Santha Meena Ramamoorthy wrote:
> >
> > > Remove condition where if and else branch are functionally identical.
> > > Issue found using cond_no_effect.cocci Coccinelle script.
> >
> > Actually, there are just identical, period.  It would be good to remove
> > "functionally".
> >
> > Since having such code that is completely duplicated is a little bit
> > strange, it could be good to enlarge the recipient list to:
> >
> > Ping-Ke Shih <pkshih@realtek.com>
> > (commit_signer:1/1=100%,authored:1/1=100%,added_lines:5225/5225=100%)
> > Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/1=100%)
> > devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM)
> >
> > Maybe someone out there would know if actually some different arguments
> > were intended.
> >
> > julia
> >
> Hi,
>
> Sure, I will do it now. I guess that should be v2 of the patch.

Yes.  Change to the commit message and adding new recipients.

julia

> > >
> > > Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>
> > > ---
> > >  drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c | 8 ++------
> > >  1 file changed, 2 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c b/drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c
> > > index ffff5b0..5b82640 100644
> > > --- a/drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c
> > > +++ b/drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c
> > > @@ -2885,12 +2885,8 @@ static void halbtc8822b2ant_action_a2dp(struct btc_coexist *btcoexist)
> > >  							     NORMAL_EXEC, 5);
> > >
> > >  		} else {
> > > -			if (wifi_turbo)
> > > -				halbtc8822b2ant_coex_table_with_type(
> > > -					btcoexist, NORMAL_EXEC, 10);
> > > -			else
> > > -				halbtc8822b2ant_coex_table_with_type(
> > > -					btcoexist, NORMAL_EXEC, 10);
> > > +			halbtc8822b2ant_coex_table_with_type(btcoexist,
> > > +							     NORMAL_EXEC, 10);
> > >
> > >  			halbtc8822b2ant_ps_tdma(btcoexist, NORMAL_EXEC, true,
> > >  						109);
> > > --
> > > 2.7.4
> > >
> > > --
> > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1519984441-14752-1-git-send-email-santhameena13%40gmail.com.
> > > For more options, visit https://groups.google.com/d/optout.
> > >
>

Re: [Outreachy kernel] [PATCH] staging: rtlwifi: remove condition where it has no effect

[Santha Meena Ramamoorthy]

On Fri, Mar 02, 2018 at 11:12:17AM +0100, Julia Lawall wrote:
> 
> 
> On Fri, 2 Mar 2018, Santha Meena Ramamoorthy wrote:
> 
> > On Fri, Mar 02, 2018 at 11:03:38AM +0100, Julia Lawall wrote:
> > >
> > >
> > > On Fri, 2 Mar 2018, Santha Meena Ramamoorthy wrote:
> > >
> > > > Remove condition where if and else branch are functionally identical.
> > > > Issue found using cond_no_effect.cocci Coccinelle script.
> > >
> > > Actually, there are just identical, period.  It would be good to remove
> > > "functionally".
> > >
> > > Since having such code that is completely duplicated is a little bit
> > > strange, it could be good to enlarge the recipient list to:
> > >
> > > Ping-Ke Shih <pkshih@realtek.com>
> > > (commit_signer:1/1=100%,authored:1/1=100%,added_lines:5225/5225=100%)
> > > Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/1=100%)
> > > devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM)
> > >
> > > Maybe someone out there would know if actually some different arguments
> > > were intended.
> > >
> > > julia
> > >
> > Hi,
> >
> > Sure, I will do it now. I guess that should be v2 of the patch.
> 
> Yes.  Change to the commit message and adding new recipients.
> 
> julia

Thank you!
> 
> > > >
> > > > Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>
> > > > ---
> > > >  drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c | 8 ++------
> > > >  1 file changed, 2 insertions(+), 6 deletions(-)
> > > >
> > > > diff --git a/drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c b/drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c
> > > > index ffff5b0..5b82640 100644
> > > > --- a/drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c
> > > > +++ b/drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c
> > > > @@ -2885,12 +2885,8 @@ static void halbtc8822b2ant_action_a2dp(struct btc_coexist *btcoexist)
> > > >  							     NORMAL_EXEC, 5);
> > > >
> > > >  		} else {
> > > > -			if (wifi_turbo)
> > > > -				halbtc8822b2ant_coex_table_with_type(
> > > > -					btcoexist, NORMAL_EXEC, 10);
> > > > -			else
> > > > -				halbtc8822b2ant_coex_table_with_type(
> > > > -					btcoexist, NORMAL_EXEC, 10);
> > > > +			halbtc8822b2ant_coex_table_with_type(btcoexist,
> > > > +							     NORMAL_EXEC, 10);
> > > >
> > > >  			halbtc8822b2ant_ps_tdma(btcoexist, NORMAL_EXEC, true,
> > > >  						109);
> > > > --
> > > > 2.7.4
> > > >
> > > > --
> > > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1519984441-14752-1-git-send-email-santhameena13%40gmail.com.
> > > > For more options, visit https://groups.google.com/d/optout.
> > > >
> >