From: Mark Brown <broonie@kernel.org>
To: "Jernej Škrabec" <jernej.skrabec@siol.net>
Cc: kuninori.morimoto.gx@renesas.com,
maxime.ripard@free-electrons.com, wens@csie.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [BUG] Kernel crash on Allwinner H3 due to sound core changes
Date: Fri, 2 Mar 2018 12:40:50 +0000 [thread overview]
Message-ID: <20180302124050.GF6255@sirena.org.uk> (raw)
In-Reply-To: <63331816.68OamKINx1@jernej-laptop>
[-- Attachment #1: Type: text/plain, Size: 930 bytes --]
On Thu, Mar 01, 2018 at 11:23:57PM +0100, Jernej Škrabec wrote:
> I removed parts of the code from the sun4i codec driver and interestingly it
> doesn't crash if I remove following lines:
> ret = devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0);
> if (ret) {
> dev_err(&pdev->dev, "Failed to register against DMAEngine\n");
> goto err_assert_reset;
> }
> Is it possible that NULL pointer causes troubles somewhere down the line?
Shouldn't be, that's just the configuration which is optional and not
what we're crashing trying to register, we can mostly configure things
by querying the capabilities of the DMA controller via the dmaengine API
these days. You're removing all the DMA support there so cutting out a
huge segment of the initialization of both this driver and the machine
driver. Other sunxi devices seem to be starting happily in -next so
there's something system dependent here...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: "Jernej Škrabec" <jernej.skrabec@siol.net>
Cc: alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com,
linux-kernel@vger.kernel.org, wens@csie.org,
maxime.ripard@free-electrons.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [BUG] Kernel crash on Allwinner H3 due to sound core changes
Date: Fri, 2 Mar 2018 12:40:50 +0000 [thread overview]
Message-ID: <20180302124050.GF6255@sirena.org.uk> (raw)
In-Reply-To: <63331816.68OamKINx1@jernej-laptop>
[-- Attachment #1.1: Type: text/plain, Size: 930 bytes --]
On Thu, Mar 01, 2018 at 11:23:57PM +0100, Jernej Škrabec wrote:
> I removed parts of the code from the sun4i codec driver and interestingly it
> doesn't crash if I remove following lines:
> ret = devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0);
> if (ret) {
> dev_err(&pdev->dev, "Failed to register against DMAEngine\n");
> goto err_assert_reset;
> }
> Is it possible that NULL pointer causes troubles somewhere down the line?
Shouldn't be, that's just the configuration which is optional and not
what we're crashing trying to register, we can mostly configure things
by querying the capabilities of the DMA controller via the dmaengine API
these days. You're removing all the DMA support there so cutting out a
huge segment of the initialization of both this driver and the machine
driver. Other sunxi devices seem to be starting happily in -next so
there's something system dependent here...
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2018-03-02 12:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 21:02 [BUG] Kernel crash on Allwinner H3 due to sound core changes Jernej Škrabec
2018-02-28 21:02 ` Jernej Škrabec
2018-03-01 1:49 ` Kuninori Morimoto
2018-03-01 1:49 ` Kuninori Morimoto
2018-03-01 1:49 ` Kuninori Morimoto
2018-03-01 22:23 ` Jernej Škrabec
2018-03-01 22:23 ` Jernej Škrabec
2018-03-02 12:40 ` Mark Brown [this message]
2018-03-02 12:40 ` Mark Brown
2018-03-05 21:30 ` Jernej Škrabec
2018-03-05 21:30 ` Jernej Škrabec
2018-03-05 21:30 ` Jernej Škrabec
2018-03-07 21:11 ` Jernej Škrabec
2018-03-07 21:11 ` Jernej Škrabec
2018-03-08 1:21 ` Kuninori Morimoto
2018-03-08 1:21 ` Kuninori Morimoto
2018-03-08 1:21 ` Kuninori Morimoto
2018-03-08 6:03 ` [alsa-devel] " Jernej Škrabec
2018-03-08 6:03 ` Jernej Škrabec
2018-03-08 6:03 ` Jernej Škrabec
2018-03-08 11:13 ` Mark Brown
2018-03-08 23:49 ` Kuninori Morimoto
2018-03-08 23:49 ` Kuninori Morimoto
2018-03-09 6:33 ` [alsa-devel] " Jernej Škrabec
2018-03-09 6:33 ` Jernej Škrabec
2018-03-09 11:14 ` Mark Brown
2018-03-09 11:14 ` Mark Brown
2018-03-19 8:08 ` Applied "soc-core: don't call kfree() for component" to the asoc tree Mark Brown
2018-03-19 8:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302124050.GF6255@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jernej.skrabec@siol.net \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.