All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Agustin Vega-Frias <agustinv@codeaurora.org>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Namhyung Kim <namhyung@kernel.org>,
	timur@codeaurora.org
Subject: Re: [RFC V2 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events
Date: Sun, 4 Mar 2018 19:10:10 +0100	[thread overview]
Message-ID: <20180304181010.GA7030@krava> (raw)
In-Reply-To: <20180304171245.GB25017@tassilo.jf.intel.com>

On Sun, Mar 04, 2018 at 09:12:45AM -0800, Andi Kleen wrote:
> > > +#include <fnmatch.h>
> > >  #include <linux/compiler.h>
> > >  #include <linux/list.h>
> > >  #include <linux/types.h>
> > > @@ -241,7 +242,7 @@ PE_NAME opt_event_config
> > >  			if (!strncmp(name, "uncore_", 7) &&
> > >  			    strncmp($1, "uncore_", 7))
> > >  				name += 7;
> > > -			if (!strncmp($1, name, strlen($1))) {
> > > +			if (!strncmp($1, name, strlen($1)) || !fnmatch($1, name, 0)) {
> > 
> > could we now get rid of the strncmp in here and keep the
> > glob matching only? 
> 
> That would break existing command lines. Not a good idea.

I hoped that only you guys are using this and would rewrite your scripts ;-)

I had no idea there's fnmatch func before.. too bad, ok

jirka

WARNING: multiple messages have this Message-ID (diff)
From: jolsa@redhat.com (Jiri Olsa)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC V2 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events
Date: Sun, 4 Mar 2018 19:10:10 +0100	[thread overview]
Message-ID: <20180304181010.GA7030@krava> (raw)
In-Reply-To: <20180304171245.GB25017@tassilo.jf.intel.com>

On Sun, Mar 04, 2018 at 09:12:45AM -0800, Andi Kleen wrote:
> > > +#include <fnmatch.h>
> > >  #include <linux/compiler.h>
> > >  #include <linux/list.h>
> > >  #include <linux/types.h>
> > > @@ -241,7 +242,7 @@ PE_NAME opt_event_config
> > >  			if (!strncmp(name, "uncore_", 7) &&
> > >  			    strncmp($1, "uncore_", 7))
> > >  				name += 7;
> > > -			if (!strncmp($1, name, strlen($1))) {
> > > +			if (!strncmp($1, name, strlen($1)) || !fnmatch($1, name, 0)) {
> > 
> > could we now get rid of the strncmp in here and keep the
> > glob matching only? 
> 
> That would break existing command lines. Not a good idea.

I hoped that only you guys are using this and would rewrite your scripts ;-)

I had no idea there's fnmatch func before.. too bad, ok

jirka

  reply	other threads:[~2018-03-04 18:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-02 23:41 [RFC V2 0/3] perf stat: improvements for handling of multiple PMUs Agustin Vega-Frias
2018-03-02 23:41 ` Agustin Vega-Frias
2018-03-02 23:41 ` [RFC V2 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events Agustin Vega-Frias
2018-03-02 23:41   ` Agustin Vega-Frias
2018-03-03 14:34   ` Jiri Olsa
2018-03-03 14:34     ` Jiri Olsa
2018-03-04 17:12     ` Andi Kleen
2018-03-04 17:12       ` Andi Kleen
2018-03-04 18:10       ` Jiri Olsa [this message]
2018-03-04 18:10         ` Jiri Olsa
2018-03-05 15:08         ` Agustin Vega-Frias
2018-03-05 15:08           ` Agustin Vega-Frias
2018-03-05 17:55           ` Andi Kleen
2018-03-05 17:55             ` Andi Kleen
2018-03-05 19:09           ` Jiri Olsa
2018-03-05 19:09             ` Jiri Olsa
2018-03-05 20:10             ` Agustin Vega-Frias
2018-03-05 20:10               ` Agustin Vega-Frias
2018-03-05 21:51               ` Jiri Olsa
2018-03-05 21:51                 ` Jiri Olsa
2018-03-02 23:41 ` [RFC V2 2/3] perf, tools: Display pmu name when printing unmerged events in stat Agustin Vega-Frias
2018-03-02 23:41   ` Agustin Vega-Frias
2018-03-02 23:41 ` [RFC V2 3/3] perf pmu: Auto-merge PMU events created by prefix or glob match Agustin Vega-Frias
2018-03-02 23:41   ` Agustin Vega-Frias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180304181010.GA7030@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=agustinv@codeaurora.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.