* [U-Boot] [PATCH] mmc: fix return value check condition
@ 2018-03-05 8:20 ` Peng Fan
2018-03-08 2:13 ` Jaehoon Chung
[not found] ` <CGME20180426103025epcas1p150ea5acc2d767b952becefbb89b989b4@epcas1p1.samsung.com>
0 siblings, 2 replies; 3+ messages in thread
From: Peng Fan @ 2018-03-05 8:20 UTC (permalink / raw)
To: u-boot
sd_read_ssr returns 0, means no error.
Fixes: 5b2e72f32721484("mmc: read ssr only if MMC write support is enabled")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Cc: Jaehoon Chung <jh80.chung@samsung.com>
Cc: Jean-Jacques Hiblot <jjhiblot@ti.com>
---
drivers/mmc/mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index c930893300..92ea78b8af 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -1689,7 +1689,7 @@ static int sd_select_mode_and_width(struct mmc *mmc, uint card_caps)
#if CONFIG_IS_ENABLED(MMC_WRITE)
err = sd_read_ssr(mmc);
- if (!err)
+ if (err)
pr_warn("unable to read ssr\n");
#endif
if (!err)
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] mmc: fix return value check condition
2018-03-05 8:20 ` [U-Boot] [PATCH] mmc: fix return value check condition Peng Fan
@ 2018-03-08 2:13 ` Jaehoon Chung
[not found] ` <CGME20180426103025epcas1p150ea5acc2d767b952becefbb89b989b4@epcas1p1.samsung.com>
1 sibling, 0 replies; 3+ messages in thread
From: Jaehoon Chung @ 2018-03-08 2:13 UTC (permalink / raw)
To: u-boot
Hi Peng,
On 03/05/2018 05:20 PM, Peng Fan wrote:
> sd_read_ssr returns 0, means no error.
> Fixes: 5b2e72f32721484("mmc: read ssr only if MMC write support is enabled")
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> Cc: Jean-Jacques Hiblot <jjhiblot@ti.com>
Will apply your patch. I have a problem about firewall exception for git.denx.de.
After fixing my problem, re-send the email about applying a patch.
Best Regards,
Jaehoon Chung
> ---
> drivers/mmc/mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index c930893300..92ea78b8af 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -1689,7 +1689,7 @@ static int sd_select_mode_and_width(struct mmc *mmc, uint card_caps)
>
> #if CONFIG_IS_ENABLED(MMC_WRITE)
> err = sd_read_ssr(mmc);
> - if (!err)
> + if (err)
> pr_warn("unable to read ssr\n");
> #endif
> if (!err)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] mmc: fix return value check condition
[not found] ` <CGME20180426103025epcas1p150ea5acc2d767b952becefbb89b989b4@epcas1p1.samsung.com>
@ 2018-04-26 10:30 ` Jaehoon Chung
0 siblings, 0 replies; 3+ messages in thread
From: Jaehoon Chung @ 2018-04-26 10:30 UTC (permalink / raw)
To: u-boot
Hi,
On 03/05/2018 05:20 PM, Peng Fan wrote:
> sd_read_ssr returns 0, means no error.
> Fixes: 5b2e72f32721484("mmc: read ssr only if MMC write support is enabled")
Sorry for late. Applied to u-boot-mmc. Thanks!
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> Cc: Jean-Jacques Hiblot <jjhiblot@ti.com>
> ---
> drivers/mmc/mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index c930893300..92ea78b8af 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -1689,7 +1689,7 @@ static int sd_select_mode_and_width(struct mmc *mmc, uint card_caps)
>
> #if CONFIG_IS_ENABLED(MMC_WRITE)
> err = sd_read_ssr(mmc);
> - if (!err)
> + if (err)
> pr_warn("unable to read ssr\n");
> #endif
> if (!err)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-26 10:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20180305081917epcas5p4d9c34d63df359600f426ab7a41b7dccd@epcas5p4.samsung.com>
2018-03-05 8:20 ` [U-Boot] [PATCH] mmc: fix return value check condition Peng Fan
2018-03-08 2:13 ` Jaehoon Chung
[not found] ` <CGME20180426103025epcas1p150ea5acc2d767b952becefbb89b989b4@epcas1p1.samsung.com>
2018-04-26 10:30 ` [U-Boot] " Jaehoon Chung
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.