All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Ludovic Barre <ludovic.Barre@st.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	Gerald Baeza <gerald.baeza@st.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-mmc@vger.kernel.org
Subject: Re: [PATCH V2 3/5] ARM: dts: stm32: add sdmmc support for stm32h743
Date: Mon, 5 Mar 2018 19:41:42 -0600	[thread overview]
Message-ID: <20180306014142.kehlb55qc6c2tbaa@rob-hp-laptop> (raw)
In-Reply-To: <1519832844-28068-4-git-send-email-ludovic.Barre@st.com>

On Wed, Feb 28, 2018 at 04:47:22PM +0100, Ludovic Barre wrote:
> From: Ludovic Barre <ludovic.barre@st.com>
> 
> This patch adds sdmmc support for stm32h743.
> 2×SD/SDIO/MMC interfaces (up to 125 MHz)
> 
> Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
> ---
>  arch/arm/boot/dts/stm32h743.dtsi | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/stm32h743.dtsi b/arch/arm/boot/dts/stm32h743.dtsi
> index bbfcbac..5e85538 100644
> --- a/arch/arm/boot/dts/stm32h743.dtsi
> +++ b/arch/arm/boot/dts/stm32h743.dtsi
> @@ -217,6 +217,19 @@
>  			};
>  		};
>  
> +		sdmmc2: sdmmc@48022400 {

Like I said in the binding example:

mmc@...

> +			compatible = "st,stm32h7-sdmmc";
> +			reg = <0x48022400 0x400>;
> +			reg-names = "sdmmc";

Not in the binding definition (And don't add it, -names for a single 
item is pointless).

> +			interrupts = <124>;
> +			clocks = <&rcc SDMMC2_CK>;
> +			resets = <&rcc STM32H7_AHB2_RESET(SDMMC2)>;
> +			cap-sd-highspeed;
> +			cap-mmc-highspeed;
> +			max-frequency = <125000000>;
> +			status = "disabled";
> +		};
> +
>  		mdma1: dma@52000000 {
>  			compatible = "st,stm32h7-mdma";
>  			reg = <0x52000000 0x1000>;
> @@ -227,6 +240,19 @@
>  			dma-requests = <32>;
>  		};
>  
> +		sdmmc1: sdmmc@52007000 {
> +			compatible = "st,stm32h7-sdmmc";
> +			reg = <0x52007000 0x1000>;
> +			reg-names = "sdmmc";
> +			interrupts = <49>;
> +			clocks = <&rcc SDMMC1_CK>;
> +			resets = <&rcc STM32H7_AHB3_RESET(SDMMC1)>;
> +			cap-sd-highspeed;
> +			cap-mmc-highspeed;
> +			max-frequency = <125000000>;
> +			status = "disabled";
> +		};
> +
>  		lptimer2: timer@58002400 {
>  			#address-cells = <1>;
>  			#size-cells = <0>;
> -- 
> 2.7.4
> 

WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 3/5] ARM: dts: stm32: add sdmmc support for stm32h743
Date: Mon, 5 Mar 2018 19:41:42 -0600	[thread overview]
Message-ID: <20180306014142.kehlb55qc6c2tbaa@rob-hp-laptop> (raw)
In-Reply-To: <1519832844-28068-4-git-send-email-ludovic.Barre@st.com>

On Wed, Feb 28, 2018 at 04:47:22PM +0100, Ludovic Barre wrote:
> From: Ludovic Barre <ludovic.barre@st.com>
> 
> This patch adds sdmmc support for stm32h743.
> 2?SD/SDIO/MMC interfaces (up to 125 MHz)
> 
> Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
> ---
>  arch/arm/boot/dts/stm32h743.dtsi | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/stm32h743.dtsi b/arch/arm/boot/dts/stm32h743.dtsi
> index bbfcbac..5e85538 100644
> --- a/arch/arm/boot/dts/stm32h743.dtsi
> +++ b/arch/arm/boot/dts/stm32h743.dtsi
> @@ -217,6 +217,19 @@
>  			};
>  		};
>  
> +		sdmmc2: sdmmc at 48022400 {

Like I said in the binding example:

mmc at ...

> +			compatible = "st,stm32h7-sdmmc";
> +			reg = <0x48022400 0x400>;
> +			reg-names = "sdmmc";

Not in the binding definition (And don't add it, -names for a single 
item is pointless).

> +			interrupts = <124>;
> +			clocks = <&rcc SDMMC2_CK>;
> +			resets = <&rcc STM32H7_AHB2_RESET(SDMMC2)>;
> +			cap-sd-highspeed;
> +			cap-mmc-highspeed;
> +			max-frequency = <125000000>;
> +			status = "disabled";
> +		};
> +
>  		mdma1: dma at 52000000 {
>  			compatible = "st,stm32h7-mdma";
>  			reg = <0x52000000 0x1000>;
> @@ -227,6 +240,19 @@
>  			dma-requests = <32>;
>  		};
>  
> +		sdmmc1: sdmmc at 52007000 {
> +			compatible = "st,stm32h7-sdmmc";
> +			reg = <0x52007000 0x1000>;
> +			reg-names = "sdmmc";
> +			interrupts = <49>;
> +			clocks = <&rcc SDMMC1_CK>;
> +			resets = <&rcc STM32H7_AHB3_RESET(SDMMC1)>;
> +			cap-sd-highspeed;
> +			cap-mmc-highspeed;
> +			max-frequency = <125000000>;
> +			status = "disabled";
> +		};
> +
>  		lptimer2: timer at 58002400 {
>  			#address-cells = <1>;
>  			#size-cells = <0>;
> -- 
> 2.7.4
> 

  reply	other threads:[~2018-03-06  1:41 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-28 15:47 [PATCH V2 0/5] mmc: add stm32 sdmmc controller Ludovic Barre
2018-02-28 15:47 ` Ludovic Barre
2018-02-28 15:47 ` Ludovic Barre
2018-02-28 15:47 ` [PATCH V2 1/5] dt-bindings: mmc: document the stm32 sdmmc bindings Ludovic Barre
2018-02-28 15:47   ` Ludovic Barre
2018-02-28 15:47   ` Ludovic Barre
2018-03-06  1:31   ` Rob Herring
2018-03-06  1:31     ` Rob Herring
2018-02-28 15:47 ` [PATCH V2 2/5] mmc: add stm32 sdmmc controller driver Ludovic Barre
2018-02-28 15:47   ` Ludovic Barre
2018-02-28 15:47   ` Ludovic Barre
2018-02-28 15:47 ` [PATCH V2 3/5] ARM: dts: stm32: add sdmmc support for stm32h743 Ludovic Barre
2018-02-28 15:47   ` Ludovic Barre
2018-02-28 15:47   ` Ludovic Barre
2018-03-06  1:41   ` Rob Herring [this message]
2018-03-06  1:41     ` Rob Herring
2018-02-28 15:47 ` [PATCH V2 4/5] ARM: dts: stm32: add sdmmc1 support for stm32h743i-eval Ludovic Barre
2018-02-28 15:47   ` Ludovic Barre
2018-02-28 15:47   ` Ludovic Barre
2018-02-28 15:47 ` [PATCH V2 5/5] ARM: configs: stm32: add mmc and ext2/3/4 support Ludovic Barre
2018-02-28 15:47   ` Ludovic Barre
2018-02-28 15:47   ` Ludovic Barre
2018-03-01  9:06 ` [PATCH V2 0/5] mmc: add stm32 sdmmc controller Ulf Hansson
2018-03-01  9:06   ` Ulf Hansson
2018-03-01  9:06   ` Ulf Hansson
2018-03-01  9:57   ` Ludovic BARRE
2018-03-01  9:57     ` Ludovic BARRE
2018-03-01  9:57     ` Ludovic BARRE
2018-03-01 10:44     ` Ulf Hansson
2018-03-01 10:44       ` Ulf Hansson
2018-03-02  8:51       ` Ludovic BARRE
2018-03-02  8:51         ` Ludovic BARRE
2018-03-02  8:51         ` Ludovic BARRE
2018-03-02  8:56         ` Ludovic BARRE
2018-03-02  8:56           ` Ludovic BARRE
2018-03-05 12:53         ` Ulf Hansson
2018-03-05 12:53           ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180306014142.kehlb55qc6c2tbaa@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=alexandre.torgue@st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gerald.baeza@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ludovic.Barre@st.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.