* [PATCH][net-next] net: mvpp2: make function mvpp2_check_hw_buf_num static
@ 2018-03-06 15:25 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2018-03-06 15:25 UTC (permalink / raw)
To: David S . Miller, Antoine Tenart, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function mvpp2_check_hw_buf_num is local to the source and does
not need to be in global scope, so make it static.
Cleans up sparse warning:
drivers/net/ethernet/marvell/mvpp2.c:4298:5: warning: symbol
'mvpp2_check_hw_buf_num' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/marvell/mvpp2.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c
index ac0a0dc8f157..61c6896d0d62 100644
--- a/drivers/net/ethernet/marvell/mvpp2.c
+++ b/drivers/net/ethernet/marvell/mvpp2.c
@@ -4295,7 +4295,8 @@ static void mvpp2_bm_bufs_free(struct device *dev, struct mvpp2 *priv,
}
/* Check number of buffers in BM pool */
-int mvpp2_check_hw_buf_num(struct mvpp2 *priv, struct mvpp2_bm_pool *bm_pool)
+static int mvpp2_check_hw_buf_num(struct mvpp2 *priv,
+ struct mvpp2_bm_pool *bm_pool)
{
int buf_num = 0;
--
2.15.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH][net-next] net: mvpp2: make function mvpp2_check_hw_buf_num static
@ 2018-03-06 15:25 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2018-03-06 15:25 UTC (permalink / raw)
To: David S . Miller, Antoine Tenart, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function mvpp2_check_hw_buf_num is local to the source and does
not need to be in global scope, so make it static.
Cleans up sparse warning:
drivers/net/ethernet/marvell/mvpp2.c:4298:5: warning: symbol
'mvpp2_check_hw_buf_num' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/marvell/mvpp2.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c
index ac0a0dc8f157..61c6896d0d62 100644
--- a/drivers/net/ethernet/marvell/mvpp2.c
+++ b/drivers/net/ethernet/marvell/mvpp2.c
@@ -4295,7 +4295,8 @@ static void mvpp2_bm_bufs_free(struct device *dev, struct mvpp2 *priv,
}
/* Check number of buffers in BM pool */
-int mvpp2_check_hw_buf_num(struct mvpp2 *priv, struct mvpp2_bm_pool *bm_pool)
+static int mvpp2_check_hw_buf_num(struct mvpp2 *priv,
+ struct mvpp2_bm_pool *bm_pool)
{
int buf_num = 0;
--
2.15.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH][net-next] net: mvpp2: make function mvpp2_check_hw_buf_num static
2018-03-06 15:25 ` Colin King
@ 2018-03-06 15:32 ` Antoine Tenart
-1 siblings, 0 replies; 6+ messages in thread
From: Antoine Tenart @ 2018-03-06 15:32 UTC (permalink / raw)
To: Colin King
Cc: David S . Miller, Antoine Tenart, netdev, kernel-janitors, linux-kernel
Hi Colin,
On Tue, Mar 06, 2018 at 04:25:17PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function mvpp2_check_hw_buf_num is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/net/ethernet/marvell/mvpp2.c:4298:5: warning: symbol
> 'mvpp2_check_hw_buf_num' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Antoine Tenart <antoine.tenart@bootlin.com>
Thanks!
Antoine
> ---
> drivers/net/ethernet/marvell/mvpp2.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c
> index ac0a0dc8f157..61c6896d0d62 100644
> --- a/drivers/net/ethernet/marvell/mvpp2.c
> +++ b/drivers/net/ethernet/marvell/mvpp2.c
> @@ -4295,7 +4295,8 @@ static void mvpp2_bm_bufs_free(struct device *dev, struct mvpp2 *priv,
> }
>
> /* Check number of buffers in BM pool */
> -int mvpp2_check_hw_buf_num(struct mvpp2 *priv, struct mvpp2_bm_pool *bm_pool)
> +static int mvpp2_check_hw_buf_num(struct mvpp2 *priv,
> + struct mvpp2_bm_pool *bm_pool)
> {
> int buf_num = 0;
>
> --
> 2.15.1
>
--
Antoine Ténart, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][net-next] net: mvpp2: make function mvpp2_check_hw_buf_num static
@ 2018-03-06 15:32 ` Antoine Tenart
0 siblings, 0 replies; 6+ messages in thread
From: Antoine Tenart @ 2018-03-06 15:32 UTC (permalink / raw)
To: Colin King
Cc: David S . Miller, Antoine Tenart, netdev, kernel-janitors, linux-kernel
Hi Colin,
On Tue, Mar 06, 2018 at 04:25:17PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function mvpp2_check_hw_buf_num is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/net/ethernet/marvell/mvpp2.c:4298:5: warning: symbol
> 'mvpp2_check_hw_buf_num' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Antoine Tenart <antoine.tenart@bootlin.com>
Thanks!
Antoine
> ---
> drivers/net/ethernet/marvell/mvpp2.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c
> index ac0a0dc8f157..61c6896d0d62 100644
> --- a/drivers/net/ethernet/marvell/mvpp2.c
> +++ b/drivers/net/ethernet/marvell/mvpp2.c
> @@ -4295,7 +4295,8 @@ static void mvpp2_bm_bufs_free(struct device *dev, struct mvpp2 *priv,
> }
>
> /* Check number of buffers in BM pool */
> -int mvpp2_check_hw_buf_num(struct mvpp2 *priv, struct mvpp2_bm_pool *bm_pool)
> +static int mvpp2_check_hw_buf_num(struct mvpp2 *priv,
> + struct mvpp2_bm_pool *bm_pool)
> {
> int buf_num = 0;
>
> --
> 2.15.1
>
--
Antoine Ténart, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][net-next] net: mvpp2: make function mvpp2_check_hw_buf_num static
2018-03-06 15:25 ` Colin King
@ 2018-03-07 18:25 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2018-03-07 18:25 UTC (permalink / raw)
To: colin.king; +Cc: antoine.tenart, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Tue, 6 Mar 2018 16:25:17 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> The function mvpp2_check_hw_buf_num is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/net/ethernet/marvell/mvpp2.c:4298:5: warning: symbol
> 'mvpp2_check_hw_buf_num' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Someone else submitted this already, but thanks for the submission.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][net-next] net: mvpp2: make function mvpp2_check_hw_buf_num static
@ 2018-03-07 18:25 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2018-03-07 18:25 UTC (permalink / raw)
To: colin.king; +Cc: antoine.tenart, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Tue, 6 Mar 2018 16:25:17 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> The function mvpp2_check_hw_buf_num is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/net/ethernet/marvell/mvpp2.c:4298:5: warning: symbol
> 'mvpp2_check_hw_buf_num' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Someone else submitted this already, but thanks for the submission.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-03-07 18:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-06 15:25 [PATCH][net-next] net: mvpp2: make function mvpp2_check_hw_buf_num static Colin King
2018-03-06 15:25 ` Colin King
2018-03-06 15:32 ` Antoine Tenart
2018-03-06 15:32 ` Antoine Tenart
2018-03-07 18:25 ` David Miller
2018-03-07 18:25 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.