* [PATCH] enic: fix boolreturn.cocci warnings
[not found] <201803070200.EDzyfosu%fengguang.wu@intel.com>
@ 2018-03-06 18:23 ` kbuild test robot
2018-03-07 18:37 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2018-03-06 18:23 UTC (permalink / raw)
To: Govindarajulu Varadarajan
Cc: kbuild-all, Christian Benvenuti, Parvi Kaustubhi, netdev, linux-kernel
From: Fengguang Wu <fengguang.wu@intel.com>
drivers/net/ethernet/cisco/enic/vnic_dev.c:1294:9-10: WARNING: return of 0/1 in function 'vnic_dev_capable_udp_rss' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: 48398b6e7065 ("enic: set UDP rss flag")
CC: Govindarajulu Varadarajan <gvaradar@cisco.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
vnic_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/ethernet/cisco/enic/vnic_dev.c
+++ b/drivers/net/ethernet/cisco/enic/vnic_dev.c
@@ -1291,7 +1291,7 @@ bool vnic_dev_capable_udp_rss(struct vni
err = vnic_dev_cmd(vdev, CMD_CAPABILITY, &a0, &a1, wait);
if (err || !a0)
- return 0;
+ return false;
rss_hash_type = (a1 >> NIC_CFG_RSS_HASH_TYPE_SHIFT) &
NIC_CFG_RSS_HASH_TYPE_MASK_FIELD;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] enic: fix boolreturn.cocci warnings
2018-03-06 18:23 ` [PATCH] enic: fix boolreturn.cocci warnings kbuild test robot
@ 2018-03-07 18:37 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-03-07 18:37 UTC (permalink / raw)
To: fengguang.wu; +Cc: gvaradar, kbuild-all, benve, pkaustub, netdev, linux-kernel
From: kbuild test robot <fengguang.wu@intel.com>
Date: Wed, 7 Mar 2018 02:23:23 +0800
> From: Fengguang Wu <fengguang.wu@intel.com>
>
> drivers/net/ethernet/cisco/enic/vnic_dev.c:1294:9-10: WARNING: return of 0/1 in function 'vnic_dev_capable_udp_rss' with return type bool
>
> Return statements in functions returning bool should use
> true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> Fixes: 48398b6e7065 ("enic: set UDP rss flag")
> CC: Govindarajulu Varadarajan <gvaradar@cisco.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-07 18:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <201803070200.EDzyfosu%fengguang.wu@intel.com>
2018-03-06 18:23 ` [PATCH] enic: fix boolreturn.cocci warnings kbuild test robot
2018-03-07 18:37 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.