All of lore.kernel.org
 help / color / mirror / Atom feed
* [2/2] USB: serial: option: use mass-storage class define
@ 2018-03-07 10:49 Johan Hovold
  0 siblings, 0 replies; 3+ messages in thread
From: Johan Hovold @ 2018-03-07 10:49 UTC (permalink / raw)
  To: linux-usb; +Cc: Johan Hovold

Use the USB class define rather than a magic number when refusing to
bind to mass-storage interfaces.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/option.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 96b6a5c6913d..ede0145b8ec9 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -2117,7 +2117,7 @@ static int option_probe(struct usb_serial *serial,
 	const struct option_blacklist_info *blacklist;
 
 	/* Never bind to the CD-Rom emulation interface	*/
-	if (iface_desc->bInterfaceClass == 0x08)
+	if (iface_desc->bInterfaceClass == USB_CLASS_MASS_STORAGE)
 		return -ENODEV;
 
 	/*

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [2/2] USB: serial: option: use mass-storage class define
@ 2018-03-12 10:34 Johan Hovold
  0 siblings, 0 replies; 3+ messages in thread
From: Johan Hovold @ 2018-03-12 10:34 UTC (permalink / raw)
  To: Greg KH; +Cc: Johan Hovold, linux-usb

On Wed, Mar 07, 2018 at 06:57:14AM -0800, Greg Kroah-Hartman wrote:
> On Wed, Mar 07, 2018 at 11:49:56AM +0100, Johan Hovold wrote:
> > Use the USB class define rather than a magic number when refusing to
> > bind to mass-storage interfaces.
> > 
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Thanks for reviewing. Both patches applied for -next.

Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [2/2] USB: serial: option: use mass-storage class define
@ 2018-03-07 14:57 Greg Kroah-Hartman
  0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2018-03-07 14:57 UTC (permalink / raw)
  To: Johan Hovold; +Cc: linux-usb

On Wed, Mar 07, 2018 at 11:49:56AM +0100, Johan Hovold wrote:
> Use the USB class define rather than a magic number when refusing to
> bind to mass-storage interfaces.
> 
> Signed-off-by: Johan Hovold <johan@kernel.org>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-03-12 10:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-07 10:49 [2/2] USB: serial: option: use mass-storage class define Johan Hovold
2018-03-07 14:57 Greg Kroah-Hartman
2018-03-12 10:34 Johan Hovold

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.