Re: [Qemu-devel] [PATCH v2 4/9] chardev: allow telnet gsource to switch gcontext

From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 4/9] chardev: allow telnet gsource to switch gcontext
Date: Wed, 7 Mar 2018 12:28:26 +0000	[thread overview]
Message-ID: <20180307122826.GY20201@redhat.com> (raw)
In-Reply-To: <20180306053320.15401-5-peterx@redhat.com>

On Tue, Mar 06, 2018 at 01:33:15PM +0800, Peter Xu wrote:
> It was originally created by qio_channel_add_watch() so it's always
> assigning the task to main context.  Now we use the new API called
> qio_channel_add_watch_source() so that we get the GSource handle rather
> than the tag ID.
> 
> Meanwhile, caching the gsource and TCPChardevTelnetInit (which holds the
> handshake data) in SocketChardev.telnet_source so that we can also do
> dynamic context switch when update read handlers.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  chardev/char-socket.c | 67 +++++++++++++++++++++++++++++++++++++++------------
>  1 file changed, 51 insertions(+), 16 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|